September 2019 - Devel - NFS Ganesha List Archives

rsize and wsize on centos7.2 not working
by QR 25 Sep '19

25 Sep '19

In CentOS7.2 under v4.0, the wsize is 1048576, but when writing 1048576 bytes on a file, ganesha receives 4 requests.The problem is who splits the 1MB request to 4 requests(256KB)?Is anyone know about this? Thanks in advance. Ganesha server info ganesha version: V2.7.6 FSAL : glusternfs client info nfs version : nfs v4.0 client info : CentOS Linux release 7.2.1511(3.10.0-327.el7.x86_64)

2 1

Change in ...nfs-ganesha[next]: MDCACHE - Put ref on root
by Daniel Gryniewicz (GerritHub) 24 Sep '19

24 Sep '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469274 ) Change subject: MDCACHE - Put ref on root ...................................................................... MDCACHE - Put ref on root 1974118562edd4f3d1f686649bdcc0271d69dc84 introduced a change that got a ref on the root object, but never put it. Put this ref to avoid a ref leak. Change-Id: I3698a7ec6abe4d2ce8d32edbeacc9574edcb1345 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/469274/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469274 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3698a7ec6abe4d2ce8d32edbeacc9574edcb1345 Gerrit-Change-Number: 469274 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

MDCACHE refcount debug patch
by Daniel Gryniewicz 24 Sep '19

24 Sep '19

Hi, Malahal. Here's the debug patch that I use for tracking down refcount issues in mdcache. Daniel

1 0

dnfs + nfsv4 support
by Satish Chandra Kilaru 24 Sep '19

24 Sep '19

Hi All, I have been experimenting with dnfs with nfs-ganesha. It works fine with NFSv3 but not v4. I noticed 2 issues with v4. 1. SetClientID fails as TAG sent by dnfs is not a valid utf8 string. NFS-ganesha is returning NFS4ERR_INVAL in this case. However, nfs-ganesha is using the converted string just for logging. If we skip this check dnfs can proceed further. 2. If length of file handle is not a multiple 4 then dnfs fails. In case of NFSv3 file handles are explicitly padded to make them multiples of 4. Can we do the same for NFSv4. --Satish

3 2

Change in ...nfs-ganesha[next]: WIP Make NFSv3 READDIR use xdr_putbuffs
by Frank Filz (GerritHub) 23 Sep '19

23 Sep '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469192 ) Change subject: WIP Make NFSv3 READDIR use xdr_putbuffs ...................................................................... WIP Make NFSv3 READDIR use xdr_putbuffs Encode all the directory entries into an xdrmem buffer that can then be added to the ioq via xdr_putbufs. We also do a more exact calulation of the space available for the directory entries so significantly more entries can be returned if the entries are small. NOTE: At the moment, this triggers an error in ntirpc because it tries to add entries to the xdrmem buffer until there is a problem with them fitting. xdr_string_encode logs an error if putting the length of the name into the buffer fails. Change-Id: I456cfd7dd6cf3efd129c9657844878660a140434 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs3_readdirplus.c M src/Protocols/XDR/xdr_nfs23.c M src/include/nfs23.h 3 files changed, 169 insertions(+), 104 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/469192/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469192 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I456cfd7dd6cf3efd129c9657844878660a140434 Gerrit-Change-Number: 469192 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Change nfs3_FSALattr_To_Fattr to nfs3_Fixup_FSALattr to save copy
by Frank Filz (GerritHub) 23 Sep '19

23 Sep '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469191 ) Change subject: Change nfs3_FSALattr_To_Fattr to nfs3_Fixup_FSALattr to save copy ...................................................................... Change nfs3_FSALattr_To_Fattr to nfs3_Fixup_FSALattr to save copy In a future patch, we will serialize READDIRPLUS response as we go so we would like to save copying the attributes. By moving the copy out to the caller, we will be able to do that. In order to save the copy, we add an fsid3 field to struct attrlist so we can fixup the fsid in the copy passed up on the readdir callback without damaging the cached attributes. Change-Id: I61f58c65ff762f0d328cceafd9e99f9aeae44d2b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs3_getattr.c M src/Protocols/NFS/nfs3_readdirplus.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/fsal_types.h M src/include/nfs_proto_tools.h 5 files changed, 31 insertions(+), 32 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/469191/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469191 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I61f58c65ff762f0d328cceafd9e99f9aeae44d2b Gerrit-Change-Number: 469191 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Usw struct attrlist for NFSv3 attributes
by Frank Filz (GerritHub) 23 Sep '19

23 Sep '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469190 ) Change subject: Usw struct attrlist for NFSv3 attributes ...................................................................... Usw struct attrlist for NFSv3 attributes Defer conversion from struct attrlist to struct fattr3 into xdr_fattr3. Also standardize the NFS v3 32 and 64 bit types to standard types. Change-Id: Ie662c2f0a2f1dbb37fbb46de4d431b528e94db12 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/fsal_convert.c M src/Protocols/NFS/nfs3_fsinfo.c M src/Protocols/NFS/nfs3_fsstat.c M src/Protocols/NFS/nfs_proto_tools.c M src/Protocols/XDR/xdr_nfs23.c M src/include/fsal_convert.h M src/include/nfs23.h 7 files changed, 183 insertions(+), 177 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/469190/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469190 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie662c2f0a2f1dbb37fbb46de4d431b528e94db12 Gerrit-Change-Number: 469190 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: RQUOTA: Get credentials for GETQUOTA/SETQUOTA requests
by Madhu Thorat (GerritHub) 22 Sep '19

22 Sep '19

Madhu Thorat has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469084 ) Change subject: RQUOTA: Get credentials for GETQUOTA/SETQUOTA requests ...................................................................... RQUOTA: Get credentials for GETQUOTA/SETQUOTA requests After commit b7813190eeac05e067d1909dba37e1bcbe65280f nfs_req_creds() doesn't get called for GETQUOTA/SETQUOTA requests as 'op_ctx->ctx_export' is NULL for RQUOTAD calls. As credentials are not set, GETQUOTA/SETQUOTA requests fail with EPERM error. To fix this in rquota_getquota()/do_rquota_setquota() we now set 'op_ctx->ctx_export' and call nfs_req_creds(), before calling FSAL specific get_quota()/set_quota() for the export. Change-Id: Ia02bb0aa8d37fbdc9372a9d9b66ebe76f696557c Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/Protocols/RQUOTA/rquota_getquota.c M src/Protocols/RQUOTA/rquota_setquota.c 2 files changed, 66 insertions(+), 29 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/469084/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/469084 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia02bb0aa8d37fbdc9372a9d9b66ebe76f696557c Gerrit-Change-Number: 469084 Gerrit-PatchSet: 1 Gerrit-Owner: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Announce Push of V2.9-dev.9
by Frank Filz 20 Sep '19

20 Sep '19

Branch next Tag:V2.9-dev.9 Release Highlights * build: add dbus_status_reply() to exports from libganesha_nfsd.so * Fix when use glusterfs, copy read only file error. * Handle ETIMEDOUT error from DMAPI environments * heap use after free for component_log_level Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 5cc42b5 Frank S. Filz V2.9-dev.9 1c60a82 ashish.sangwan heap use after free for component_log_level 8350a36 Malahal Naineni Handle ETIMEDOUT error from DMAPI environments 6079d59 Jingbo Cao Fix when use glusterfs, copy read only file error. Bug URL: https://bugzilla.redhat.com/show_bug.cgi?id=1543996 https://github.com/nfs-ganesha/nfs-ganesha/issues/262 c125711 Kaleb S. KEITHLEY build: add dbus_status_reply() to exports from libganesha_nfsd.so

1 0

GPFS LogCrit on lock_op2
by Frank Filz 20 Sep '19

20 Sep '19

On the call, I mentioned I would look at bypassing permission check for the file owner for the open_func call in fsal_find_fd with open_for_locks. It turns out there is a difference between FSAL_GPFS and FSAL_VFS FSAL_VFS makes the ultimate call to open_by_handle as root, and therefor even a non-owner of the file will not be an issue in opening the file read/write. GPFS calls GPFSFSAL_open which calls fsal_set_credentials so if the permissions do not allow read/write when open_for_locks occurs, then the file will instead be opened in the same mode as the OPEN stateid. I think it would be good to evaluate when GPFSFSAL_open actually needs to be called, and whether open_func should make a more direct call to fsal_internal_handle2fd. Frank

3 4