Change in ...nfs-ganesha[next]: Initialize the client node for comparison
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481894 )
Change subject: Initialize the client node for comparison
......................................................................
Initialize the client node for comparison
During address cleanup, the initialization of the client node was lost,
but it's still being used for comparison. Initialize it properly.
Change was 9e806a7dc903aef22b92360ddfdf012b2cde5bf1
Change-Id: I24cdf1be5d7d6febe53931e8e1329a8804761291
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/support/client_mgr.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/481894/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481894
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I24cdf1be5d7d6febe53931e8e1329a8804761291
Gerrit-Change-Number: 481894
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 10 months
Default KRB Principal name with new rpc.gssd
by Pushpesh Sharma
Hi All,
We are trying to use ganehsa with KRB. On NFS client centos7.5 we are joining Active Directory based using sssd(AD based KRB Realm). For root user we are getting krb ticket using kinit and valid AD user.
Client principal while joining domain using sssd a default principal of shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM> is always generated. gss.rpcd by default send this principal as principal user name to ganesha server. Client do have other principal like nfs/client_fdqn(a)REALM.COM<mailto:nfs/client_fdqn@REALM.COM>. But as per rpc.gssd documentation<mailto:rpc.gssd%20documentation> as well first choice would be shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM>.
Due to this server always recognize root user as someone else i.e. shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM>.
We do see in src/idmapper/idmapper.c<https://github.com/nfs-ganesha/nfs-ganesha/blob/next/src/idmapper/idmappe...> handling for mapping three principal patterns nfs/* , root/*, host/* to uid=0, gid=0. So this left shorthostname$(a)REALM.COM<mailto:horthostname$@REALM.COM> principal not being recognized as root.
We are of the opinion that doing a small fix in above idmapper code to add this pattern as well can fix this issue.
But we wanted to know any security concern around it? Or if the client behavior can be change in any way, so we don't need this fix?
If we try removing this shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM> principal after domain join, sssd cannot be re-loaded and complains about not finding this principal.
Thanks
-pushpesh
4 years, 10 months
Change in ...nfs-ganesha[next]: Fix nfs3_readdirplus error return
by Name of user not set (GerritHub)
wei.qiaomiao(a)zte.com.cn has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481804 )
Change subject: Fix nfs3_readdirplus error return
......................................................................
Fix nfs3_readdirplus error return
in nfs3_readdirplus function, we should use res_readdirplus3 instead of res_readdir3
Change-Id: Ibaeba7c5a6575294ceea099945a16a016ecb168a
Signed-off-by: Wei Qiaomiao <wei.qiaomiao(a)zte.com.cn>
---
M src/Protocols/NFS/nfs3_readdirplus.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/481804/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481804
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ibaeba7c5a6575294ceea099945a16a016ecb168a
Gerrit-Change-Number: 481804
Gerrit-PatchSet: 1
Gerrit-Owner: wei.qiaomiao(a)zte.com.cn
Gerrit-MessageType: newchange
4 years, 10 months
nfs_rpc_process_request spends 150 seconds
by QR
In Windows nfs client, nfs_rpc_process_request(lookup/readdir etc) sometimes takes more than 150 seconds(v3_full).
I think this is weird, because 150 seconds too long.
Is anyone know what's going on during the period? Thanks in advance.
Ganesha server info ganesha version: V2.7.6 FSAL : In housenfs client info nfs version : nfs v3 client info : Windows server 2012
4 years, 10 months
Change in ...nfs-ganesha[next]: Fix use of dupreqs with DUPREQ_DELETED state
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481399 )
Change subject: Fix use of dupreqs with DUPREQ_DELETED state
......................................................................
Fix use of dupreqs with DUPREQ_DELETED state
DUPREQ_DELETED is set just before deleting the dupreq in
nfs_dupreq_delete(). This is called on requests that get dropped! So
these dupreqs should not be used but nfs_dupreq_start() ends up using it
as its state is not DUPREQ_START.
No need to set DUPREQ_DELETED as the dupreq is getting deleted anyway.
Change-Id: Iecd82fae45400d30cea31b4afb1995a0c2d795c0
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/RPCAL/nfs_dupreq.c
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/481399/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481399
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Iecd82fae45400d30cea31b4afb1995a0c2d795c0
Gerrit-Change-Number: 481399
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
4 years, 11 months
Change in ...nfs-ganesha[next]: DNS related stats are added to ganesha_stats auth command
by Trishali Nayar (GerritHub)
Trishali Nayar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/480042 )
Change subject: DNS related stats are added to ganesha_stats auth command
......................................................................
DNS related stats are added to ganesha_stats auth command
Change-Id: I4e3228e1d9dfb1514040a00d2a55f69ba4f811dd
Signed-off-by: Trishali Nayar <ntrishal(a)in.ibm.com>
---
M src/Protocols/NFS/nfs4_op_exchange_id.c
M src/Protocols/NLM/nlm_async.c
M src/RPCAL/gss_credcache.c
M src/SAL/nfs4_recovery.c
M src/idmapper/idmapper.c
M src/include/common_utils.h
M src/include/idmapper.h
M src/include/server_stats_private.h
M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py
M src/support/exports.c
M src/support/nfs_ip_name.c
11 files changed, 133 insertions(+), 11 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/480042/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/480042
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4e3228e1d9dfb1514040a00d2a55f69ba4f811dd
Gerrit-Change-Number: 480042
Gerrit-PatchSet: 1
Gerrit-Owner: Trishali Nayar <ntrishal(a)in.ibm.com>
Gerrit-MessageType: newchange
4 years, 11 months
Announce Push of V4-dev.1
by Frank Filz
Branch next
Tag:V4-dev.1
Merge Highlights
* Support for POSIX ACL xattrs for CEPH
* Remove unused DUPREQ_ERROR and DUPREQ_INSERT_MALLOC_ERROR
* Fix responding with NFS version mismatch.
* Fix get_state_obj_export_owner_refs() fail case
* Fix accessing object handle after freeing its last state
* core: multiple definitions of 'common' data compiling with gcc-10
* CEPH: Fix size of handle
* Fix double couting of READ, WRITE op
* Fix typo in lib_dbus_stats.py
* Throttle the health warning
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
9903c67 Frank S. Filz V4-dev.1
91f0302 Daniel Gryniewicz Throttle the health warning
db67193 Sachin Punadikar Fix typo in lib_dbus_stats.py
16b6c6b Sachin Punadikar Fix double couting of READ, WRITE ops
4bfdb31 Wei Qiaomiao CEPH: Fix size of handle
fc62d0d Kaleb S. KEITHLEY core: multiple definitions of 'common' data
compiling with gcc-10
2a9d219 Shangzhong Zhu Enable ACL disable option for FSAL_CEPH
abbe630 Shangzhong Zhu Add get and set ACLs attr support for FSAL_CEPH
d354583 Shangzhong Zhu Add get and set ACLs API for FSAL_CEPH
fe895ee Shangzhong Zhu Convert POSIX ACL to extented attribute
a3f51c0 Malahal Naineni Fix accessing object handle after freeing its last
state
42afe22 Malahal Naineni Fix get_state_obj_export_owner_refs() fail case
fe8cebb Malahal Naineni Fix responding with NFS version mismatch.
1c3789b Malahal Naineni Remove unused DUPREQ_ERROR and
DUPREQ_INSERT_MALLOC_ERROR
4 years, 11 months
Change in ...nfs-ganesha[next]: Throttle the health warning
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/479965 )
Change subject: Throttle the health warning
......................................................................
Throttle the health warning
If there is a period of low traffic from clients, then the heartbeat can
fire just after the first op in a while. This causes a suprious health
warn message in the logs.
Raise the threshold for health warn to 2, rather than 1, to avoid these
messages.
Change-Id: Id3ade7b919290a71409f0f668735a3fc1ca89e5d
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/MainNFSD/nfs_init.c
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/479965/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/479965
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Id3ade7b919290a71409f0f668735a3fc1ca89e5d
Gerrit-Change-Number: 479965
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 11 months
Change in ...nfs-ganesha[next]: Fix typo
by Sachin Punadikar (GerritHub)
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/479775 )
Change subject: Fix typo
......................................................................
Fix typo
"compound" was mis-spelled as "compond". Fixed it.
Change-Id: I4c49e48eefb353f5ce8f8cfde1322c3fca9c82a7
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/479775/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/479775
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4c49e48eefb353f5ce8f8cfde1322c3fca9c82a7
Gerrit-Change-Number: 479775
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
Gerrit-MessageType: newchange
4 years, 11 months
