February 2020 - Devel - NFS Ganesha List Archives

Config of export failover mounts using IPv6
by prebenj＠dk.ibm.com 14 Feb '20

14 Feb '20

Hi I need to configura a ganesha NFS service with failover in a IPv6 network, keeping the active mounts. I have not been able to find any information on this - ???

1 0

Change in ...nfs-ganesha[next]: C++ - Don't load rpcent.h in C++ code, it conflicts with system headers
by Daniel Gryniewicz (GerritHub) 13 Feb '20

13 Feb '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484806 ) Change subject: C++ - Don't load rpcent.h in C++ code, it conflicts with system headers ...................................................................... C++ - Don't load rpcent.h in C++ code, it conflicts with system headers Change-Id: I6344e231fbfe92fdf6d2ce13e7604d00d89f0d79 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/gtest/fsal_api/test_close2_latency.cc M src/gtest/fsal_api/test_close_latency.cc M src/gtest/fsal_api/test_commit2_latency.cc M src/gtest/fsal_api/test_getattrs_latency.cc M src/gtest/fsal_api/test_handle_to_key_latency.cc M src/gtest/fsal_api/test_handle_to_wire_latency.cc M src/gtest/fsal_api/test_link_latency.cc M src/gtest/fsal_api/test_lock_op2_latency.cc M src/gtest/fsal_api/test_lookup_latency.cc M src/gtest/fsal_api/test_mkdir_latency.cc M src/gtest/fsal_api/test_mknode_latency.cc M src/gtest/fsal_api/test_open2_latency.cc M src/gtest/fsal_api/test_read2_latency.cc M src/gtest/fsal_api/test_readdir_correctness.cc M src/gtest/fsal_api/test_readdir_latency.cc M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_release_latency.cc M src/gtest/fsal_api/test_rename_latency.cc M src/gtest/fsal_api/test_reopen2_latency.cc M src/gtest/fsal_api/test_setattr2_latency.cc M src/gtest/fsal_api/test_symlink_latency.cc M src/gtest/fsal_api/test_unlink_latency.cc M src/gtest/fsal_api/test_write2_latency.cc M src/gtest/gtest.hh M src/gtest/gtest_nfs4.hh M src/gtest/test_ci_hash_dist1.cc M src/gtest/test_rbt.cc 27 files changed, 54 insertions(+), 46 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/484806/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484806 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6344e231fbfe92fdf6d2ce13e7604d00d89f0d79 Gerrit-Change-Number: 484806 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE - Set next_ck on prev chunk
by Daniel Gryniewicz (GerritHub) 13 Feb '20

13 Feb '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484805 ) Change subject: MDCACHE - Set next_ck on prev chunk ...................................................................... MDCACHE - Set next_ck on prev chunk When we load the first entry in a new chunk, set the next_ck on the previous chunk, if it is known. Change-Id: I8c9a60d0945c743f5d1915944f128dbfd80fc5bc Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/484805/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484805 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c9a60d0945c743f5d1915944f128dbfd80fc5bc Gerrit-Change-Number: 484805 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Don't convert posix acl to fsal acl when no access acl
by Shangzhong Zhu (GerritHub) 11 Feb '20

11 Feb '20

Shangzhong Zhu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484630 ) Change subject: Don't convert posix acl to fsal acl when no access acl ...................................................................... Don't convert posix acl to fsal acl when no access acl Signed-off-by: Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn> Change-Id: Icdc7756a5128192fb026c7f34dbf775999460770 --- M src/FSAL/FSAL_CEPH/internal.c 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/484630/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484630 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icdc7756a5128192fb026c7f34dbf775999460770 Gerrit-Change-Number: 484630 Gerrit-PatchSet: 1 Gerrit-Owner: Shangzhong Zhu <zhu.shangzhong(a)zte.com.cn> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL: Skip additional file system types
by Frank Filz (GerritHub) 11 Feb '20

11 Feb '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484595 ) Change subject: FSAL: Skip additional file system types ...................................................................... FSAL: Skip additional file system types Change-Id: I950a472146058d7ab8ed962bf23fefc02544f3be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/commonlib.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/484595/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484595 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I950a472146058d7ab8ed962bf23fefc02544f3be Gerrit-Change-Number: 484595 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL on file system reload, remove no longer available file systems
by Frank Filz (GerritHub) 11 Feb '20

11 Feb '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484594 ) Change subject: FSAL on file system reload, remove no longer available file systems ...................................................................... FSAL on file system reload, remove no longer available file systems A file system is removed if: stat() fails on fs->path if fs->path is no longer a directory if fs->dev does not match st.dev Change-Id: I6e94ef37300906a75f5ed2b5323ec0629fa51e34 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/commonlib.c 1 file changed, 41 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/484594/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484594 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6e94ef37300906a75f5ed2b5323ec0629fa51e34 Gerrit-Change-Number: 484594 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Allow NFSv4 Reads when file is opened with write delegation
by Name of user not set (GerritHub) 10 Feb '20

10 Feb '20

des(a)vmware.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484494 ) Change subject: Allow NFSv4 Reads when file is opened with write delegation ...................................................................... Allow NFSv4 Reads when file is opened with write delegation When file is opened with OPEN4_SHARE_ACCESS_WRITE and delegation is granted, ganesha does not allow the client to read the write delegated file. But according to RFC read should be allowed on a file opened with share access write. With this fix we remove the conflict check altogether because file read by same client should not conflict with write delegation. Change-Id: I63b3e8359768d53369e757810bc8f88b5a73d9fc Signed-off-by: Deepthi Shivaramu <des(a)vmware.com> --- M src/Protocols/NFS/nfs4_op_read.c 1 file changed, 5 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/484494/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484494 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I63b3e8359768d53369e757810bc8f88b5a73d9fc Gerrit-Change-Number: 484494 Gerrit-PatchSet: 1 Gerrit-Owner: des(a)vmware.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: "ganesha_stats help" should return 0
by Sachin Punadikar (GerritHub) 10 Feb '20

10 Feb '20

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484394 ) Change subject: "ganesha_stats help" should return 0 ...................................................................... "ganesha_stats help" should return 0 "ganesha_stats help" command displays the help, but with return code 1. As the "help" option succeeded, return code should be 0. Change-Id: Ic74a0184fb8bd3904753a431f6d9c7ff8de903fb Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com> (cherry picked from commit ff5fd8bc8703c2a23a0b11cb408793330a8a49a7) --- M src/scripts/ganeshactl/ganesha_stats.py 1 file changed, 35 insertions(+), 33 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/484394/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484394 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic74a0184fb8bd3904753a431f6d9c7ff8de903fb Gerrit-Change-Number: 484394 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix lru_reap_chunk_impl racing with mdcache_lru_unref()
by Malahal (GerritHub) 08 Feb '20

08 Feb '20

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484339 ) Change subject: Fix lru_reap_chunk_impl racing with mdcache_lru_unref() ...................................................................... Fix lru_reap_chunk_impl racing with mdcache_lru_unref() lru_reap_chunk_impl() gets a ref on chunk->parent but its lru refcount could be zero by then. When a directory gets removed or one of its operations receives ESTALE error from FSAL, mdcache would eventually call mdcache_lru_unref() to free up the directory handle. mdcache_lru_unref() frees its chunks after the directory handle *refcount goes to zero*, so lru_reap_chunk_impl() could increment the directory handle refcount after it was already zero. This leads to the original thread that was freeing the directory handle as well as the thread calling lru_reap_chunk_impl() will try to free the same directory entry leading to use after free crashes. Change-Id: I4a77f10cbd4640e2aea7b9f05b2d47f2dfdb16e2 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 14 insertions(+), 21 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/484339/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484339 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4a77f10cbd4640e2aea7b9f05b2d47f2dfdb16e2 Gerrit-Change-Number: 484339 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix chunk->next_ck didn't work when readahead not supported by FSAL
by sepia-liu (GerritHub) 07 Feb '20

07 Feb '20

sepia-liu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484315 ) Change subject: Fix chunk->next_ck didn't work when readahead not supported by FSAL ...................................................................... Fix chunk->next_ck didn't work when readahead not supported by FSAL When FSAL not supported readahead,only a chunk will be created in mdcache_populate_dir_chunk func,and the connection between the pre_chunk will not be established. Change-Id: Ia2f126b84ba6f5b59d3a6b64cecf5e92bff22ad6 Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/484315/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/484315 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia2f126b84ba6f5b59d3a6b64cecf5e92bff22ad6 Gerrit-Change-Number: 484315 Gerrit-PatchSet: 1 Gerrit-Owner: sepia-liu <liuwei_coder(a)163.com> Gerrit-MessageType: newchange

1 0