Announce Push of V4-dev.5
by Frank Filz
Branch next
Tag:V4-dev.5
Merge Highlights
* Add filesystem type to log messages for POSIX filesystem scan
* RADOS_URLS: restore rados_urls watch on new configuration
* Fix seg fault when NFSv4 compound op fails for regular files.
* Fix git clone url of official nfs-ganesha repository
* Fix compilation errors on xfs ioctl syscall structs
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
367ecac Frank S. Filz V4-dev.5
9534ade Anthony Iliopoulos Fix compilation errors on xfs ioctl syscall
structs
f2b4571 Anthony Iliopoulos Fix git clone url of official nfs-ganesha
repository
bbc9221 ashish.sangwan Fix seg fault when NFSv4 compound op fails for
regular files.
640e387 Denis Kondratenko RADOS_URLS: restore rados_urls watch on new
configuration
8c21af3 Frank S. Filz Add filesystem type to log messages for POSIX
filesystem scan
4 years, 10 months
NFSv4 Read not allowed on file opened with OPEN4_SHARE_ACCESS_WRITE and got write delegation(OPEN_DELEGATE_WRITE)
by des@vmware.com
According to page 112 in RFC 7530, NFSv4 read operation should be allowed on a open state with share access OPEN4_SHARE_ACCESS_WRITE to accommodate clients whose write implementation may unavoidably do reads (e.g., due to buffer cache constraints).
This condition is taken care in normal flow in nfs4_read() in here:
https://github.com/nfs-ganesha/nfs-ganesha/blob/next/src/Protocols/NFS/nf...
But if the open has granted a write delegation(OPEN_DELEGATE_WRITE), then the check for deleg state in nfs4_read() does not allow Read op as per RFC mentioned above but return NFS4ERR_BAD_STATEID.
https://github.com/nfs-ganesha/nfs-ganesha/blob/next/src/Protocols/NFS/nf...
case STATE_TYPE_DELEG:
/* Check if the delegation state allows READ or
* if the open share state allows READ access
* in case of WRITE delegation */
sdeleg = &state_found->state_data.deleg;
if (!((sdeleg->sd_type & OPEN_DELEGATE_READ) ||
(sdeleg->share_access & OPEN4_SHARE_ACCESS_READ))) {
/* Invalid delegation for this operation. */
LogDebug(COMPONENT_STATE,
"Delegation type:%d state:%d",
sdeleg->sd_type,
sdeleg->sd_state);
res_READ4->status = NFS4ERR_BAD_STATEID;
goto out;
}
state_open = NULL;
break;
The ubuntu nfs client when it wants to write data, always opens file with OPEN4_SHARE_ACCESS_WRITE and not OPEN4_SHARE_ACCESS_BOTH like other linux clients, so with delegation enabled if we just do "echo data > file.txt ; cat file.txt", it hangs forever with read op getting NFS4ERR_BAD_STATEID and client retrying forever.
I feel this whole block under 'case STATE_TYPE_DELEG' is not needed at all, as the share access check will anyway happen below and we need not check the delegation state while doing read operation.
4 years, 10 months
Dedicated mailing list for centos-ci test results for nfs-ganesha
by Arjun Sharma
Hello,
In a brief discussion with Matt Benjamin and Kaleb Keithley it was
suggested that we have a dedicated mailing list for sending out centos
ci test results especially for test like iozone. Since the test are
triggered for every patch sent we plan on emailing like a digest of
results to avoid flooding of emails.
Would also love to hear if there are any other test results that
should be included apart from iozone, kindly share your thoughts.
Thanks!
- Arjun
4 years, 10 months
Change in ...nfs-ganesha[next]: Fix compilation errors on xfs ioctl syscall structs
by Name of user not set (GerritHub)
ailiopoulos(a)suse.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/483907 )
Change subject: Fix compilation errors on xfs ioctl syscall structs
......................................................................
Fix compilation errors on xfs ioctl syscall structs
Upstream xfsprogs has removed some typedef on bulk requst ioctls as of
commit b46789e2 ("xfs: remove various bulk request typedef usage"), and
as such compilation fails with xfsprogs headers >= v5.3.0. Replace
typedef declarations with their corresponding struct types and unbreak
compilation.
Change-Id: Ibb5be001b73c5d11e3f879f632b73687909f6ff9
Signed-off-by: Anthony Iliopoulos <ailiopoulos(a)suse.com>
---
M src/FSAL/FSAL_VFS/xfs/handle_syscalls.c
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/483907/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/483907
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ibb5be001b73c5d11e3f879f632b73687909f6ff9
Gerrit-Change-Number: 483907
Gerrit-PatchSet: 1
Gerrit-Owner: ailiopoulos(a)suse.com
Gerrit-MessageType: newchange
4 years, 10 months
FSAL_RGW: support fast S3 attrs feature
by Denis Kondratenko
Hi guys,
There was new feature, that actually changed Ceph rados API:
https://github.com/ceph/ceph/pull/28664
Ganesha side:
https://github.com/nfs-ganesha/nfs-ganesha/commit/d197efbad9b353a562581ac...
It was backported to Nautilus, Luminous
Backporting make this affect downstream nfs-ganesha (2.8.3 for example),
after Ceph update, it doesn't build, not probably works any more.
Also it could be seen in Jenkins jobs here:
https://ci.centos.org/job/nfs-ganesha_trigger-fsal_rgw/
As result 2.8.3 ganesha couldn't be build with recent Ceph Nautilus,
Luminous and etc.
Question, how to be with it ?
I see couple of options:
1. revert API changes to Ceph and create new API function rgw_lookup2,
fix ganesha
2. backport feature to 2.8.x and maybe other supported branches
3. revert Ceph backports ?
4. other ?
BTW another question, is what are current release model for the nfs-ganesha?
I see last stable branch is V2.8-stable, there was no 2.9 or 3.0.
Are there plans for stable branches ?
Another question :) what is the current plans for 4.x release ?
Thanks,
--
Denis Kondratenko
Engineering Manager SUSE Linux Enterprise Storage
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nuremberg
Germany
(HRB 36809, AG Nürnberg)
Managing Director: Felix Imendörffer
4 years, 10 months
Change in ...nfs-ganesha[next]: selinux: add local policy for FSAL_VFS and FSAL_RGW
by Kaleb KEITHLEY (GerritHub)
Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/483661 )
Change subject: selinux: add local policy for FSAL_VFS and FSAL_RGW
......................................................................
selinux: add local policy for FSAL_VFS and FSAL_RGW
rhbz#1796160, rhbz#1788541, partial (?) fix for rhbz#1788563
Add allow rules generated by audit2allow
Change-Id: Ief66664a98dacf2a9b3ca91f5657e46fd1deefe0
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
---
M src/selinux/ganesha.te
1 file changed, 139 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/483661/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/483661
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ief66664a98dacf2a9b3ca91f5657e46fd1deefe0
Gerrit-Change-Number: 483661
Gerrit-PatchSet: 1
Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 10 months