April 2020 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Reduce log level for rpc.statd communication failures
by Malahal (GerritHub) 02 Apr '20

02 Apr '20

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488640 ) Change subject: Reduce log level for rpc.statd communication failures ...................................................................... Reduce log level for rpc.statd communication failures rpc.statd is a single thread process and is prone to not respond in time when there are DNS timeout failures. Since all of these failures result in NFS clients resending lock requests and retrying, reduced the log level from CRIT to EVENT. It is also rate limited, just in case! Change-Id: I2e45725d3a19f2e839bc4fdd7e6ba441906ebc81 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/Protocols/NLM/nsm.c 1 file changed, 16 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/488640/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488640 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2e45725d3a19f2e839bc4fdd7e6ba441906ebc81 Gerrit-Change-Number: 488640 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Make parser tokens case sensitive
by Malahal (GerritHub) 02 Apr '20

02 Apr '20

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488612 ) Change subject: Make parser tokens case sensitive ...................................................................... Make parser tokens case sensitive Currently parser tokens are case insensitive because of strcasecmp while looking for a token. If you export two directories with path "/path" and "/PATH", the parser would return the former token from its list while scanning the latter instead of creating a new one. Replaced strcasecmp by strcmp in save_token(). Change-Id: I5d7c473d1bcf8ac1f7f35079e4045870fcde471f Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/config_parsing/analyse.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/488612/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488612 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5d7c473d1bcf8ac1f7f35079e4045870fcde471f Gerrit-Change-Number: 488612 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fixup style concerns and add Doxygen comments.
by Solomon Boulos (GerritHub) 01 Apr '20

01 Apr '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488573 ) Change subject: Fixup style concerns and add Doxygen comments. ...................................................................... Fixup style concerns and add Doxygen comments. Change-Id: I57e120505c93b95005827ec0146ac309967adc37 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/nlm.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h M src/FSAL/FSAL_PROXY_V3/rpc.c M src/FSAL/FSAL_PROXY_V3/utils.c 5 files changed, 1,196 insertions(+), 531 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/488573/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488573 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I57e120505c93b95005827ec0146ac309967adc37 Gerrit-Change-Number: 488573 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Make fullpath and pseudopath gsh_refstr and keep a ref in op_ctx
by Frank Filz (GerritHub) 01 Apr '20

01 Apr '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488570 ) Change subject: Make fullpath and pseudopath gsh_refstr and keep a ref in op_ctx ...................................................................... Make fullpath and pseudopath gsh_refstr and keep a ref in op_ctx The pseudopath is going to be changeable in a following patch so we must make a stable version easily accessible. Use gsh_refstr to accomplish that. Also, for consistency handle fullpath the same way. It may actually be possible to allow changing of it also and in the meantime, code that picks one or the other of pseudopath and fullpath will not have to deal with different rules for access to those strings. Change-Id: I40270796f6508f1d2f9cc7659347ab24189a03ff Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/main.c M src/FSAL/FSAL_GLUSTER/export.c M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_LIZARDFS/export.c M src/FSAL/FSAL_LIZARDFS/main.c M src/FSAL/FSAL_MEM/mem_export.c M src/FSAL/FSAL_PROXY/export.c M src/FSAL/FSAL_PSEUDO/export.c M src/FSAL/FSAL_RGW/main.c M src/FSAL/FSAL_VFS/export.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/subfsal_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c M src/FSAL/commonlib.c M src/FSAL/fsal_helper.c M src/FSAL_UP/fsal_up_top.c M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_worker_thread.c M src/Protocols/9P/9p_attach.c M src/Protocols/9P/9p_proto_tools.c M src/Protocols/NFS/mnt_Export.c M src/Protocols/NFS/mnt_Mnt.c M src/Protocols/NFS/nfs3_create.c M src/Protocols/NFS/nfs3_mkdir.c M src/Protocols/NFS/nfs3_mknod.c M src/Protocols/NFS/nfs3_symlink.c M src/Protocols/NFS/nfs3_write.c M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_allocate.c M src/Protocols/NFS/nfs4_op_create.c M src/Protocols/NFS/nfs4_op_free_stateid.c M src/Protocols/NFS/nfs4_op_layoutreturn.c M src/Protocols/NFS/nfs4_op_lookup.c M src/Protocols/NFS/nfs4_op_lookupp.c M src/Protocols/NFS/nfs4_op_putfh.c M src/Protocols/NFS/nfs4_op_putrootfh.c M src/Protocols/NFS/nfs4_op_readdir.c M src/Protocols/NFS/nfs4_op_restorefh.c M src/Protocols/NFS/nfs4_op_secinfo.c M src/Protocols/NFS/nfs4_op_write.c M src/Protocols/NFS/nfs4_pseudo.c M src/Protocols/NFS/nfs_proto_tools.c M src/Protocols/RQUOTA/rquota_common.c M src/Protocols/RQUOTA/rquota_getquota.c M src/Protocols/RQUOTA/rquota_setquota.c M src/SAL/nfs4_state.c M src/SAL/state_deleg.c M src/SAL/state_layout.c M src/SAL/state_lock.c M src/SAL/state_share.c M src/gtest/gtest.hh M src/gtest/test_ci_hash_dist1.cc M src/include/export_mgr.h M src/include/fsal.h M src/include/fsal_api.h M src/include/mount.h M src/include/nfs_exports.h M src/include/nfs_proto_data.h M src/include/sal_data.h M src/support/export_mgr.c M src/support/exports.c M src/support/nfs_creds.c 65 files changed, 881 insertions(+), 427 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/488570/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488570 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I40270796f6508f1d2f9cc7659347ab24189a03ff Gerrit-Change-Number: 488570 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL: rename fullpath identifiers for easier code xref
by Frank Filz (GerritHub) 01 Apr '20

01 Apr '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488569 ) Change subject: FSAL: rename fullpath identifiers for easier code xref ...................................................................... FSAL: rename fullpath identifiers for easier code xref The fullpath and pseudopath symbols should now be reserved for the members of the gsh_export structure. This makes it easier to audit the code for correctness in handling those special strings. Change-Id: I8a4c0731007f21528340c49bd5cdd7821eae15a0 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/FSAL/FSAL_RGW/main.c 2 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/488569/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488569 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8a4c0731007f21528340c49bd5cdd7821eae15a0 Gerrit-Change-Number: 488569 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add gsh_refstr_dup function to simplify setting up a refstr
by Frank Filz (GerritHub) 01 Apr '20

01 Apr '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488568 ) Change subject: Add gsh_refstr_dup function to simplify setting up a refstr ...................................................................... Add gsh_refstr_dup function to simplify setting up a refstr When setting up a refstr that has an already known value simplify its creation. Change-Id: I929bfa4ce02dce44a7c12d75c61c1b04847eabe9 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/gsh_refstr.h 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/488568/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488568 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I929bfa4ce02dce44a7c12d75c61c1b04847eabe9 Gerrit-Change-Number: 488568 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add wrapper for pthread_mutex_trylock
by Frank Filz (GerritHub) 01 Apr '20

01 Apr '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488567 ) Change subject: Add wrapper for pthread_mutex_trylock ...................................................................... Add wrapper for pthread_mutex_trylock Change-Id: I18a9ef97c82bf6d1ed764215350a6029881f4a0c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/common_utils.h 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/488567/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488567 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I18a9ef97c82bf6d1ed764215350a6029881f4a0c Gerrit-Change-Number: 488567 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: doc: clarify the User_Id setting in the sample config
by Jeff Layton (GerritHub) 01 Apr '20

01 Apr '20

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488556 ) Change subject: doc: clarify the User_Id setting in the sample config ...................................................................... doc: clarify the User_Id setting in the sample config Ceph has a qualified usernames, and whatever is passed in here will be prefixed with "client.". Make that clear in the sample config. Change-Id: I28bba996ca8edd107e2131d078a554e98e852f45 Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/config_samples/ceph.conf 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/488556/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488556 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I28bba996ca8edd107e2131d078a554e98e852f45 Gerrit-Change-Number: 488556 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Clear no_cleanup while holding state_lock
by Madhu Thorat (GerritHub) 01 Apr '20

01 Apr '20

Madhu Thorat has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488545 ) Change subject: Clear no_cleanup while holding state_lock ...................................................................... Clear no_cleanup while holding state_lock Currently with d3b90cfb73d15f4dfc4f917f4609a3a79cae37d1, in open4_ex() we are setting 'no_cleanup=false' after releasing state_lock. It is possible that a thread A may release the state_lock, but before it could set 'no_cleanup=false' another thread B may take the same lock and set 'no_cleanup=true'. So since thread A may set 'no_cleanup=false' after thread B had set 'no_cleanup=true', this would lead to a crash (abort) in state_wipe_file() as 'no_cleanup=false' but 'state_lock' was already acquired. So we now set 'no_cleanup=false' while holding state_lock. Change-Id: Iefe2a7d979901d8f291b32ac0838a03d1ca08fb0 Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/Protocols/NFS/nfs4_op_open.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/488545/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488545 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iefe2a7d979901d8f291b32ac0838a03d1ca08fb0 Gerrit-Change-Number: 488545 Gerrit-PatchSet: 1 Gerrit-Owner: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Make sure no_cleanup is set under the state_lock
by Malahal (GerritHub) 01 Apr '20

01 Apr '20

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488542 ) Change subject: Make sure no_cleanup is set under the state_lock ...................................................................... Make sure no_cleanup is set under the state_lock We do set no_cleanup to true under the lock, we set it to false after dropping the lock at times! If two threads work on the same object, thread A could acquire the state lock and set this no_cleanup to true, while another thread could set it to false leading to thread A's call stack trying to call state_wipe_file. This would result into lock failure! Always modify no_cleanup under write mode state_lock to avoid this issue. Change-Id: I2313c3849289db4b3d190edb4958a670a4f9ac8f Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/Protocols/NFS/nfs4_op_open.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/488542/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488542 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2313c3849289db4b3d190edb4958a670a4f9ac8f Gerrit-Change-Number: 488542 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0