Change in ...nfs-ganesha[next]: Clean up DRC code
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488525 )
Change subject: Clean up DRC code
......................................................................
Clean up DRC code
nfs_dupreq_delete() and nfs_dupreq_finish() don't return anything other
than DUPREQ_SUCCESS, so changed them to return void. Also reorganised
code in complete_request().
Change-Id: I85a2870f6c0f3081411927ae0fbc4df61141f93f
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/MainNFSD/nfs_worker_thread.c
M src/RPCAL/nfs_dupreq.c
M src/include/nfs_dupreq.h
3 files changed, 51 insertions(+), 75 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/25/488525/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488525
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I85a2870f6c0f3081411927ae0fbc4df61141f93f
Gerrit-Change-Number: 488525
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
4 years, 8 months
Change in ...nfs-ganesha[next]: Fix Segmentation fault.
by xijinyu (GerritHub)
xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488515 )
Change subject: Fix Segmentation fault.
......................................................................
Fix Segmentation fault.
When exporting a directory that does not exist in GlusterFS volume,
occur seg-fault and the Ganesha process crashes.
We are hitting this seg-fault on V4-dev.2 and V4-dev.9:
Breakpoint 1, mdcache_exp_release (exp_hdl=0x7fd75c009770) at
/usr/src/debug/nfs-ganesha-4-dev.2/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c:184
184 struct mdcache_fsal_export *exp = mdc_export(exp_hdl);
Missing separate debuginfos, use: debuginfo-install openssl-libs-1.0.2k-8.el7.x86_64
(gdb) n
185 struct fsal_export *sub_export = exp->mfe_exp.sub_export;
(gdb)
188 fsal_hdl = sub_export->fsal;
(gdb)
190 LogInfo(COMPONENT_FSAL, "Releasing %s export %" PRIu16 " for %s",
(gdb)
Program received signal SIGSEGV, Segmentation fault.
0x00007fd8124777ad in mdcache_exp_release (exp_hdl=0x7fd75c009770) at
/usr/src/debug/nfs-ganesha-4-dev.2/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c:190
190 LogInfo(COMPONENT_FSAL, "Releasing %s export %" PRIu16 " for %s",
(gdb) l
185 struct fsal_export *sub_export = exp->mfe_exp.sub_export;
186 struct fsal_module *fsal_hdl;
187
188 fsal_hdl = sub_export->fsal;
189
190 LogInfo(COMPONENT_FSAL, "Releasing %s export %" PRIu16 " for %s",
191 fsal_hdl->name, op_ctx->ctx_export->export_id,
192 export_path(op_ctx->ctx_export));
193
194 /* Stop the dirmap thread */
(gdb) p fsal_hdl->name
$1 = 0x7fd75c009750 "GLUSTER"
(gdb) p op_ctx->ctx_export->export_id
Cannot access memory at address 0x68
(gdb) p op_ctx->ctx_export
Cannot access memory at address 0x68
Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com>
Change-Id: I10c6ef3d6d904434e9da595de56aa7d3698d47b2
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/488515/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488515
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I10c6ef3d6d904434e9da595de56aa7d3698d47b2
Gerrit-Change-Number: 488515
Gerrit-PatchSet: 1
Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com>
Gerrit-MessageType: newchange
4 years, 9 months
Change in ...nfs-ganesha[next]: nfs4 readdir: fix use of NFS3 errors in NFS4 code
by Dominique Martinet (GerritHub)
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488507 )
Change subject: nfs4 readdir: fix use of NFS3 errors in NFS4 code
......................................................................
nfs4 readdir: fix use of NFS3 errors in NFS4 code
Change-Id: I5dc4b88b8f7c990c460bd85ca234cf06f5302fdf
Reported-By: clang
Fixes: f6edd32b5f7321a6 ("Make NFSv4 READDIR use xdr_putbuffs")
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/Protocols/NFS/nfs4_op_readdir.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/488507/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488507
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I5dc4b88b8f7c990c460bd85ca234cf06f5302fdf
Gerrit-Change-Number: 488507
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
Gerrit-MessageType: newchange
4 years, 9 months
Change in ...nfs-ganesha[next]: client_mgr: fix free of static data
by Dominique Martinet (GerritHub)
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488506 )
Change subject: client_mgr: fix free of static data
......................................................................
client_mgr: fix free of static data
hostaddr_str is now part of the gsh_client struct
Reported-By: clang
Change-Id: I32e73855ef2284e9580aa2f3d2f439dcca8ad10d
Fixes: 9e806a7dc903 ("Rework client_mgr to use rpc_tools.c/gsh_rpc.h and related cleanup")
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/support/client_mgr.c
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/488506/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488506
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I32e73855ef2284e9580aa2f3d2f439dcca8ad10d
Gerrit-Change-Number: 488506
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
Gerrit-MessageType: newchange
4 years, 9 months
FW: Spring 2020 NFS Bake-a-thon is CANCELLED
by Frank Filz
In case anyone wasn't sure...
Frank
-----Original Message-----
From: linux-nfs-owner(a)vger.kernel.org
[mailto:linux-nfs-owner@vger.kernel.org] On Behalf Of Bill Baker
Sent: Tuesday, March 31, 2020 8:14 AM
To: nfsv4(a)ietf.org; linux-nfs <linux-nfs(a)vger.kernel.org>;
fall-2019-bakeathon(a)googlegroups.com
Subject: Spring 2020 NFS Bake-a-thon is CANCELLED
Greetings,
In light of the ongoing pandemic, the Spring 2020 NFS Bake-a-thon is
*CANCELLED*.
Stay tuned to this same BAT-channel for announcements concerning the Fall
Bake-a-thon.
Meanwhile, stay safe.
--
Bill Baker - Oracle NFS development
4 years, 9 months
Change in ...nfs-ganesha[next]: Rename the V4 proxy names from pxy_ to proxyv4.
by Solomon Boulos (GerritHub)
Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488473 )
Change subject: Rename the V4 proxy names from pxy_ to proxyv4.
......................................................................
Rename the V4 proxy names from pxy_ to proxyv4.
As part of making the V3 proxy, ffilz asked that I rename a lot of the code in
the existing V4 proxy. One caveat is that load_fsal performs a dlopen() of the
name of the FSAL given in a config, so we cannot rename the output PROXY_V4
unless we wish to break existing configs. Seems like a future breaking change.
Change-Id: Ib7c94b0480cf9b05f303591c20585345e5e3e711
Signed-off-by: Solomon Boulos <boulos(a)google.com>
---
M src/CMakeLists.txt
M src/FSAL/FSAL_PROXY_V4/CMakeLists.txt
M src/FSAL/FSAL_PROXY_V4/export.c
M src/FSAL/FSAL_PROXY_V4/fsal_nfsv4_macros.h
M src/FSAL/FSAL_PROXY_V4/handle.c
M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping.c
M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping.h
M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_db.c
M src/FSAL/FSAL_PROXY_V4/main.c
A src/FSAL/FSAL_PROXY_V4/proxyv4_fsal_methods.h
D src/FSAL/FSAL_PROXY_V4/pxy_fsal_methods.h
M src/FSAL/FSAL_PROXY_V4/xattrs.c
M src/cmake/build_configurations/everything.cmake
M src/include/config-h.in.cmake
M src/nfs-ganesha.spec-in.cmake
15 files changed, 1,235 insertions(+), 1,097 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/488473/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488473
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ib7c94b0480cf9b05f303591c20585345e5e3e711
Gerrit-Change-Number: 488473
Gerrit-PatchSet: 1
Gerrit-Owner: Solomon Boulos <boulos(a)google.com>
Gerrit-MessageType: newchange
4 years, 9 months
Change in ...nfs-ganesha[next]: Rename FSAL_PROXY => FSAL_PROXY_V4.
by Solomon Boulos (GerritHub)
Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488472 )
Change subject: Rename FSAL_PROXY => FSAL_PROXY_V4.
......................................................................
Rename FSAL_PROXY => FSAL_PROXY_V4.
Now that there will be a PROXY_V3, Frank asked me to rename this as
PROXY_V4. This first change just does the rename and basic CMake-related
updates. Next up: allowing both PROXY and PROXY_V4 as the FSAL name.
Change-Id: Id7eea79a77ca57c59e2d983243abdfed9070dd66
Signed-off-by: Solomon Boulos <boulos(a)google.com>
---
M src/CMakeLists.txt
M src/FSAL/CMakeLists.txt
R src/FSAL/FSAL_PROXY_V4/CMakeLists.txt
R src/FSAL/FSAL_PROXY_V4/export.c
R src/FSAL/FSAL_PROXY_V4/fsal_nfsv4_macros.h
R src/FSAL/FSAL_PROXY_V4/handle.c
R src/FSAL/FSAL_PROXY_V4/handle_mapping/CMakeLists.txt
R src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping.c
R src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping.h
R src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_db.c
R src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_db.h
R src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_internal.h
R src/FSAL/FSAL_PROXY_V4/handle_mapping/test_handle_mapping.c
R src/FSAL/FSAL_PROXY_V4/handle_mapping/test_handle_mapping_db.c
R src/FSAL/FSAL_PROXY_V4/main.c
R src/FSAL/FSAL_PROXY_V4/pxy_fsal_methods.h
R src/FSAL/FSAL_PROXY_V4/xattrs.c
M src/cmake/build_configurations/bsd10.cmake
M src/cmake/build_configurations/gpfs.cmake
M src/cmake/build_configurations/vfs_only.cmake
M src/doc/man/CMakeLists.txt
M src/nfs-ganesha.spec-in.cmake
M src/scripts/runcp.sh
23 files changed, 25 insertions(+), 16 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/488472/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488472
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Id7eea79a77ca57c59e2d983243abdfed9070dd66
Gerrit-Change-Number: 488472
Gerrit-PatchSet: 1
Gerrit-Owner: Solomon Boulos <boulos(a)google.com>
Gerrit-MessageType: newchange
4 years, 9 months
