October 2021 - Devel - Nfs Ganesha List Archives

Change in ...nfs-ganesha[next]: Fix up SM_NOTIFY caller_name

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526274 ) Change subject: Fix up SM_NOTIFY caller_name ...................................................................... Fix up SM_NOTIFY caller_name When the client is configured to use the IP address as the caller name instead of host name, we must convert that IP address string to a sockaddr_t that will be set as op_ctx->caller_addr. In this case, since we don't have gsh_client (we can't find the existing one because we don't have the client port), we also set op_cxt->client to NULL. SM_NOTIFY MUST always come from the loop back interface. Note that get_nsm_client will ALWAYS use the caller name from the SM_NOTIFY, the only question is what IP address stuff we set. If nsm_use_caller_name is false AND op_ctx->client is NULL, get_nsm_client is being called for SM_NOTIFY and will just use caller name instead of trying to convert a client IP address to a string. This actually saves a bunch of work... NOTE: This effort makes it clear the client and server MUST agree about get_nsm_client... ALSO the client and server MUST agrees how an IPv4 address encapsulated into IPv6 is handled (Linux kernel and now Ganesha with a previous patch just use the IPv4 address string, not the IPv6 encapsulated string). Change-Id: I59dae62fb3a06e4b930c47b4725e5e5994f2ea1c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NLM/nlm_Sm_Notify.c M src/SAL/nlm_owner.c 2 files changed, 51 insertions(+), 98 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/526274/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526274 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I59dae62fb3a06e4b930c47b4725e5e5994f2ea1c Gerrit-Change-Number: 526274 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: NLM: Use IPv4 address instead of encapsulated for caller_name

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526273 ) Change subject: NLM: Use IPv4 address instead of encapsulated for caller_name ...................................................................... NLM: Use IPv4 address instead of encapsulated for caller_name If nsm_use_caller_name is false, and the client is an IPv4 address encapsulated in IPv6, we want to use the IPv4 address not the IPv6 encapsulated address for caller_name. Change-Id: I0e0ac0a0836bbdcd8aa22fda7253f4bad6abab4e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/nlm_owner.c 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/526273/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526273 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0e0ac0a0836bbdcd8aa22fda7253f4bad6abab4e Gerrit-Change-Number: 526273 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Remove nlm_owner reference count held by nlm_state

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526272 ) Change subject: Remove nlm_owner reference count held by nlm_state ...................................................................... Remove nlm_owner reference count held by nlm_state The nlm_state only exists in conjunction with an nlm_owner and will be removed when the nlm_ownner is released. Without this fix, nlm_owner and nlm_state will never be released since they cross reference each other. Change-Id: Ief8a750102f812ffe09f739651ccbef71359c73b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/nlm_state.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/526272/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526272 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ief8a750102f812ffe09f739651ccbef71359c73b Gerrit-Change-Number: 526272 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: nsm client always has a caller_name, don't use ssc_client in hash

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526271 ) Change subject: nsm client always has a caller_name, don't use ssc_client in hash ...................................................................... nsm client always has a caller_name, don't use ssc_client in hash Clarify the caller_name is always present and also clarify that a deep copy is done of it. Since when hashing by IP address, caller_name is the string form of the IP address, so just hash and search by that and not the actual IP address. Because of this, it is also OK if there is no op_ctx->client since we don't reference it. NOTE: There WILL always be an op_ctx->client any time we are establishing a new nsm client since a lock request needs to come from a client. This allowance is made for SM_NOTIFY which always comes from loop back and not a real client. Change-Id: I00ec438e4661dd1fe0c41a7a64e1fca292b80a58 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/nlm_owner.c M src/include/sal_data.h 2 files changed, 47 insertions(+), 34 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/526271/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526271 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I00ec438e4661dd1fe0c41a7a64e1fca292b80a58 Gerrit-Change-Number: 526271 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Improve nsm_client debugging

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526270 ) Change subject: Improve nsm_client debugging ...................................................................... Improve nsm_client debugging inc_nsm_client_ref and dec_nsm_client_ref now log the line they were called from instead of lines inside those functions which makes it easier to track where the refcount is being manipulated. Also fix an logging issue in get_nsm_client where we needed to clear out the log buffer before displaying the found nsm client. Change-Id: Ic9f85a0d8969020a32d93f13cabdd89884bdeab5 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/nlm_owner.c M src/include/sal_functions.h 2 files changed, 58 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/526270/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526270 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic9f85a0d8969020a32d93f13cabdd89884bdeab5 Gerrit-Change-Number: 526270 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Remove unused parameter from get_nsm_client

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526269 ) Change subject: Remove unused parameter from get_nsm_client ...................................................................... Remove unused parameter from get_nsm_client Change-Id: I857079be8046a6e8356178bd2bc22fea4cb7a50f Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NLM/nlm_Cancel.c M src/Protocols/NLM/nlm_Free_All.c M src/Protocols/NLM/nlm_Lock.c M src/Protocols/NLM/nlm_Test.c M src/Protocols/NLM/nlm_Unlock.c M src/Protocols/NLM/nlm_util.c M src/SAL/nlm_owner.c M src/include/sal_functions.h 8 files changed, 10 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/526269/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526269 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I857079be8046a6e8356178bd2bc22fea4cb7a50f Gerrit-Change-Number: 526269 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Move convert_ipv6_to_ipv4 to rpc_tools.c and add is_loopback

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526268 ) Change subject: Move convert_ipv6_to_ipv4 to rpc_tools.c and add is_loopback ...................................................................... Move convert_ipv6_to_ipv4 to rpc_tools.c and add is_loopback Some general IP address tools... Change-Id: If902ebd516d8e14ea341743e11b5bd28b3a05212 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/RPCAL/rpc_tools.c M src/include/gsh_rpc.h M src/support/exports.c 3 files changed, 108 insertions(+), 50 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/526268/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526268 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If902ebd516d8e14ea341743e11b5bd28b3a05212 Gerrit-Change-Number: 526268 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Fix readdir stuck. When ceph-radosgw returns part of the dirs results...

by Name of user not set (GerritHub)

18817316690(a)163.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526076 ) Change subject: Fix readdir stuck. When ceph-radosgw returns part of the dirs results, ganesha marks the last result as DIR_TERMINATE and rescan, caused an endless loop. ...................................................................... Fix readdir stuck. When ceph-radosgw returns part of the dirs results, ganesha marks the last result as DIR_TERMINATE and rescan, caused an endless loop. Signed-off-by: fenghua Zhen <18817316690(a)163.com> Change-Id: I25f41c62a697b98a6a4c936f7a6a671f2cdb9c04 --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/526076/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526076 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I25f41c62a697b98a6a4c936f7a6a671f2cdb9c04 Gerrit-Change-Number: 526076 Gerrit-PatchSet: 1 Gerrit-Owner: 18817316690(a)163.com Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 / 0

Announce Push of V4-rc1

by Frank Filz

Branch next Tag:V4-rc1 Ganesha V4.0 is in sight! Merge Highlights * FSAL_VFS: Make sure fsid is set properly when filling attrs from stat * LIZARDFS: fix compile issues * Get time_delta from FSAL dynamic fsinfo * Change from default of 1 second for time_delta to 100 ns. * Add O_TRUNC, O_EXCL, and mode setting to multilock test tool * Make OPEN create EXCLUSIVE4_1 work correctly * FSAL: Make sure the exclusive create verifier fits * Several minor code cleanups * Account for terminating null character for readlink() in FSAL_PROXY_V3. * MDCACHE - Ensure ATTR4_FS_LOCATIONS and ATTR4_SEC_LABEL bits aren't lost Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 464af038b Frank S. Filz V4-rc1 7979a8548 Daniel Gryniewicz MDCACHE - Ensure ATTR4_FS_LOCATIONS and ATTR4_SEC_LABEL bits aren't lost a0f930a6e Matthew DeVore Remove ambiguous use of "export" in header file 3363e77a8 Xi Jinyu Remove duplicate code ce7413b58 Bjorn Leffler Account for terminating null character for readlink() in FSAL_PROXY_V3. 2ef48f405 Bjorn Leffler Fix number formatting for 64 bit number types. a2a08c2dc Frank S. Filz FSAL: Make sure the exclusive create verifier fits e896e8275 Frank S. Filz Make OPEN create EXCLUSIVE4_1 work correctly 355012f8a Frank S. Filz Add O_TRUNC, O_EXCL, and mode setting to multilock test tool ee224fa49 Frank S. Filz Change from default of 1 second for time_delta to 100 ns. 7d706e044 Frank S. Filz Get time_delta from FSAL dynamic fsinfo 50308fff6 Frank S. Filz LIZARDFS: fix compile issues 05920748e Frank S. Filz FSAL_VFS: Make sure fsid is set properly when filling attrs from stat

2 years, 5 months

1
0
0 / 0

Ganesha V4.0 will be released soon - first rc1 Thursday this week

by Frank Filz

Hello all, It's been a long road, almost two years. It's time for a release, so V4-rc1 will be pushed tomorrow and we hope to wrap up and finalize V4.0 before the end of the year. If you are working on or have submitted an open github issue, please check it out and let's see if we can get some of those resolved during the rc process. If you have patches submitted to gerrithub that have not been merged, please revisit them and let's figure out what needs to be done to get them to a mergable state. Thanks Frank Filz

2 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel October 2021