May 2021 - Devel - NFS Ganesha List Archives

FSAL read and ERR_FSAL_DELAY
by Suhrud Patankar 17 May '21

17 May '21

Hello All, We want to serve read in case of a slow backend and would like the client to retry the read op. mdc_read_super_cb() calls mdcache_kill_entry() if FSAL returns eDelay. This ends up cleaning the state for the file including any byte range locks. Does this mean eDealy is not a valid error for FSAL read? How do I return ERR_FSAL_DELAY from FSAL without losing the state? Thanks in advance for your help! Thanks & Regards, Suhrud

4 4

Change in ...nfs-ganesha[next]: Don't kill mdache entry on error delay
by Suhrud Patankar (GerritHub) 17 May '21

17 May '21

Suhrud Patankar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516839 ) Change subject: Don't kill mdache entry on error delay ...................................................................... Don't kill mdache entry on error delay mdcache should kill the entry only for stale error. Change-Id: I50be8fc1330efff64b4fe464f54945958ef39b14 Signed-off-by: Suhrud Patankar <suhrudpatankar(a)gmail.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/516839/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516839 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I50be8fc1330efff64b4fe464f54945958ef39b14 Gerrit-Change-Number: 516839 Gerrit-PatchSet: 1 Gerrit-Owner: Suhrud Patankar <suhrudpatankar(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: To support existing AFM filesets which stored NFSv3 file handles to ...
by Name of user not set (GerritHub) 17 May '21

17 May '21

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516777 ) Change subject: To support existing AFM filesets which stored NFSv3 file handles to work with NFSv4 mount ...................................................................... To support existing AFM filesets which stored NFSv3 file handles to work with NFSv4 mount (cherry picked from commit 5b4adb0afa82cae2eeaff3e8ee1fa28c7d0499f8) Change-Id: I992f01ca43b9949cc336a4860fbce8f77f1c91fd Signed-off-by: Yogendra Charya <yogendra.charya(a)ibm.com> --- M src/include/nfs_file_handle.h M src/support/nfs_filehandle_mgmt.c 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/516777/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516777 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I992f01ca43b9949cc336a4860fbce8f77f1c91fd Gerrit-Change-Number: 516777 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-MessageType: newchange

1 0

No merge this week - too many problems
by Frank Filz 14 May '21

14 May '21

Fedora 34 is beating me up. Now pynfs 4.0 isn't working because it's getting EADDRINUSE while trying to get a port < 1024 I'm not sure why. Other issues I had was non-existence of /dev/null made Ganesha not able to daemon()ize and several compile issues. Welcome to the new and improved world. Frank

1 0

Change in ...nfs-ganesha[next]: Initialize some avl tree keys to 0 to avoid uninitialized error
by Frank Filz (GerritHub) 14 May '21

14 May '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516675 ) Change subject: Initialize some avl tree keys to 0 to avoid uninitialized error ...................................................................... Initialize some avl tree keys to 0 to avoid uninitialized error Change-Id: Icbfb68a7d87688d888cc987253375e9b82af7f8b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_VFS/state.c M src/FSAL/FSAL_VFS/vfs/attrs.c 3 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/516675/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516675 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icbfb68a7d87688d888cc987253375e9b82af7f8b Gerrit-Change-Number: 516675 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Missing or corrupt files over single NFS client after large change
by philipmjewell＠gmail.com 14 May '21

14 May '21

Looking to see if there is any config that needs to be set to prevent this issue or if any logs needs to be provided for further debug? Any assistance is appreciated. To kind of help paint a picture on our implementation, we have gone ahead and created the following miro board: https://miro.com/app/board/o9J_lE0WOvs=/ We go ahead and make a large change to the NFS filesystem from one of the NFS clients by deleting and adding 8,000+ files - no particular file size. During this bulk file update, we see missing or corrupt file appear on one of the NFS clients. The problem file(s) differ on each given time these operations happen. All other NFS clients show the file correctly. We have been able to consistently replicate this issue over NFS 3 as well as NFS 4.2. Only thing that seems to get logged when enabling rpcdebug for nfs seems to have the below pattern for the problem file(s) where the permissions seem to use an int of '1' instead of the ID associated with the given file like all the other files that successfully go through this process. (We are not sure if this log is relevant but this seems to be displayed when we see the error) NFS: nfs_update_inode(0:104/11627611431409627202 fh_crc=0x4d950748 ct=1 info=0x27e7f) NFS: nfs_lookup_revalidate_done(<MISSING_FILE_HERE>) is valid NFS: dentry_delete(<MISSING_FILE_HERE>, 48084c) NFS: permission(0:104/1), mask=0x1, res=0 Note: Gluster configuration has up-call enabled. Gluster version: glusterfs 8.2 Ganesha version: NFS-Ganesha Release = V3.3

3 2

Change in ...nfs-ganesha[next]: ClientID - Add an upper limit on the number of ClientIDs.
by Name of user not set (GerritHub) 13 May '21

13 May '21

pradeepthomas(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516613 ) Change subject: ClientID - Add an upper limit on the number of ClientIDs. ...................................................................... ClientID - Add an upper limit on the number of ClientIDs. With filesystem recovery backend, each ClientID translates to one directory. With load generators like LDX, this could lead reaching inode limits of the root filesystem (if /var/lib/nfs/ganesha is part of it). Once inode limit is reached, system become unusable until recovery directories are cleaned up (either by lease expiry or manually). This patch adds an upper limit to guardrail against getting into such scenarios. The limit is disabled by default. Change-Id: Ib40cd4184812ef65e051f8907ddc99f0ef4b15cd Signed-off-by: Pradeep <pradeepthomas(a)gmail.com> --- M src/SAL/nfs4_clientid.c M src/config_samples/config.txt M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/516613/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516613 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib40cd4184812ef65e051f8907ddc99f0ef4b15cd Gerrit-Change-Number: 516613 Gerrit-PatchSet: 1 Gerrit-Owner: pradeepthomas(a)gmail.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Stats - Prevent RPC time from going negative.
by Name of user not set (GerritHub) 11 May '21

11 May '21

pradeepthomas(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516434 ) Change subject: Stats - Prevent RPC time from going negative. ...................................................................... Stats - Prevent RPC time from going negative. CLOCK_REALTIME can go backwards at times making RPC latency computation to go negative. Using actual times and doing timespec_diff makes sure that negative times are never used. Change-Id: I5009b9f20b3277448a2246112cdc14233e122f28 Signed-off-by: Pradeep <pradeepthomas(a)gmail.com> --- M src/MainNFSD/nfs_worker_thread.c M src/Protocols/NFS/nfs4_Compound.c M src/include/fsal_api.h M src/include/nfs_proto_data.h M src/include/server_stats.h M src/support/server_stats.c 6 files changed, 24 insertions(+), 21 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/516434/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516434 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5009b9f20b3277448a2246112cdc14233e122f28 Gerrit-Change-Number: 516434 Gerrit-PatchSet: 1 Gerrit-Owner: pradeepthomas(a)gmail.com Gerrit-MessageType: newchange

1 0

No merge this week
by Frank Filz 07 May '21

07 May '21

Nothing is ready yet, I can do a merge Monday or Tuesday if the patches up for review currently are reviewed. Thanks Frank

1 0

Change in ...nfs-ganesha[next]: multilock: fix compile warning due to ignoring snprintf return
by Frank Filz (GerritHub) 07 May '21

07 May '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516102 ) Change subject: multilock: fix compile warning due to ignoring snprintf return ...................................................................... multilock: fix compile warning due to ignoring snprintf return Change-Id: I1149821da274274f2d6290361d578f8b86150558 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/tools/multilock/multilock.h 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/516102/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516102 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1149821da274274f2d6290361d578f8b86150558 Gerrit-Change-Number: 516102 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0