May 2021 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Monitoring in Ganesha?
by Bjorn Leffler 22 Nov '21

22 Nov '21

Apart from the counters that you can access through dbus, is there any other monitoring built into Ganesha? I'm thinking of adding it with this higher level plan: - Exporting metrics from Ganesha to Prometheus. - Aggregate data in Prometheus. - Display monitoring consoles and graphs with Grafana. - Package up Prometheus, Grafana and the preconfigured rules/dashboards as a Docker image. - This makes it straightforward to deploy monitoring alongside a Gansha binary. My rough coding plan for the code is to: - Add a USE_MONITORING directive to the CMakeLists.txt files. - Add a build dependency to the Prometheus C client <https://github.com/digitalocean/prometheus-client-c>. - Create a src/monitoring directory for the new source files and templates. - Increment counters and timers throughout the code. - Use histograms to compute latency percentiles, heatmaps, etc. Is this a good idea? Any objections or suggestions? Thanks, Bjorn

3 6

Change in ...nfs-ganesha[next]: Remove init.d/nfs-ganesha.gpfs
by Dominique Martinet (GerritHub) 28 May '21

28 May '21

Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517876 ) Change subject: Remove init.d/nfs-ganesha.gpfs ...................................................................... Remove init.d/nfs-ganesha.gpfs GPFS doesn't support any init.d based systems anymore. Change-Id: I8c83b8dad3c0e36289e8a440711cb60610a94adc Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr> --- D src/scripts/init.d/nfs-ganesha.gpfs 1 file changed, 0 insertions(+), 393 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/517876/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517876 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c83b8dad3c0e36289e8a440711cb60610a94adc Gerrit-Change-Number: 517876 Gerrit-PatchSet: 1 Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: vfs_getextattr_value: fix posix2fsal_error parameter
by Dominique Martinet (GerritHub) 28 May '21

28 May '21

Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517874 ) Change subject: vfs_getextattr_value: fix posix2fsal_error parameter ...................................................................... vfs_getextattr_value: fix posix2fsal_error parameter fgetxattr returns -1 on error, we need to look at errno Change-Id: I381b2759cb1582804a945dc26e10510f16a04bb1 Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr> --- M src/FSAL/FSAL_VFS/xattrs.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/517874/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517874 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I381b2759cb1582804a945dc26e10510f16a04bb1 Gerrit-Change-Number: 517874 Gerrit-PatchSet: 1 Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: CMakefiles: cleanup mooshika-related conf
by Dominique Martinet (GerritHub) 28 May '21

28 May '21

Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517873 ) Change subject: CMakefiles: cleanup mooshika-related conf ...................................................................... CMakefiles: cleanup mooshika-related conf - MOOSHIKA_PREFIX was added twice, remove one - MOOSHIKA_LIBRARIES can be always used to link with ganesha_nfsd, if 9P_RDMA is not configured then the variable will just be empty Change-Id: I2331c9cffd265802e986029f9482c19c75abb1a8 Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr> --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt 2 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/517873/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517873 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2331c9cffd265802e986029f9482c19c75abb1a8 Gerrit-Change-Number: 517873 Gerrit-PatchSet: 1 Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org> Gerrit-MessageType: newchange

1 0

Announce Push of V4-dev.61
by Frank Filz 27 May '21

27 May '21

Branch next Tag:V4-dev.61 Merge Highlights * Fix dbus spec violation in export_show_exports. * remove unused assignments * log the permission set fail * Make parser tokens case sensitive Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: a1127c520 Frank S. Filz V4-dev.61 88ecb55dc Björn Fischer Fix dbus spec violation in export_show_exports. 95687c522 FloridSleeves remove unused assignments 4a518443d FloridSleeves log the permission set fail 4cd8bd97c Malahal Naineni Make parser tokens case sensitive

1 0

NFS over UNIX domain socket
by matvore＠comcast.net 27 May '21

27 May '21

Hello, It turns out that the macOS NFS client supports connecting to an NFS server over AF_LOCAL (UNIX domain) sockets. It is undocumented, but a hint of this is here: https://github.com/apple/darwin-xnu/blob/xnu-7195.101.1/bsd/nfs/nfs_subs.c#… This has performance improvements over using IP loopback. I'm wondering if this area has ever been explored or worked on? After a quick look I feel it should be an approachable task. There is already AF_VSOCK support, which sounds very similar. FWIW it looks like this was upgraded from a debug build feature around 2020-02: https://github.com/apple/darwin-xnu/blame/18c0ee9fc565c37827391eaa2f42f265a… Thank you, Matt

4 4

Change in ...nfs-ganesha[next]: Fix dbus spec violation in export_show_exports. Move arg type string ...
by Björn Fischer (GerritHub) 22 May '21

22 May '21

Björn Fischer has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517402 ) Change subject: Fix dbus spec violation in export_show_exports. Move arg type string assembly to cpp phase entirely. ...................................................................... Fix dbus spec violation in export_show_exports. Move arg type string assembly to cpp phase entirely. Change-Id: I756831f6b40eb381424277a776f695a29d60e9a7 Signed-off-by: Björn Fischer <bf(a)CeBiTec.Uni-Bielefeld.DE> --- M src/support/export_mgr.c 1 file changed, 22 insertions(+), 84 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/517402/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517402 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I756831f6b40eb381424277a776f695a29d60e9a7 Gerrit-Change-Number: 517402 Gerrit-PatchSet: 1 Gerrit-Owner: Björn Fischer <bf(a)CeBiTec.Uni-Bielefeld.DE> Gerrit-MessageType: newchange

1 0

Announce Push of V4-dev.60
by Frank Filz 21 May '21

21 May '21

Branch next Tag:V4-dev.60 Merge Highlights * fix various build and compile issues * v4_recovery: off-by-one error, v4_recov_dir is truncated * ClientID - Add an upper limit on the number of ClientIDs. * Don't kill mdache entry on error delay * Stats - Prevent RPC time from going negative. Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 5115fcc50 Frank S. Filz V4-dev.60 1261b7f31 Pradeep Stats - Prevent RPC time from going negative. 1ebec8701 Suhrud Patankar Don't kill mdache entry on error delay b146e7cca Pradeep ClientID - Add an upper limit on the number of ClientIDs. 43dbe8155 Frank S. Filz Allow building rados_grace with ASAN dbf74d640 Frank S. Filz Initialize some avl tree keys to 0 to avoid uninitialized error 5e987a174 Kaleb S. KEITHLEY v4_recovery: off-by-one error, v4_recov_dir is truncated 83d2f5037 Frank S. Filz multilock: fix compile warning due to ignoring snprintf return

1 0

Change in ...nfs-ganesha[next]: Allow building rados_grace with ASAN
by Frank Filz (GerritHub) 18 May '21

18 May '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516995 ) Change subject: Allow building rados_grace with ASAN ...................................................................... Allow building rados_grace with ASAN Change-Id: I638f28bdf2eb3f8c1a12d91c7e738434e81a2704 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/516995/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516995 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I638f28bdf2eb3f8c1a12d91c7e738434e81a2704 Gerrit-Change-Number: 516995 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0