April 2022 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: mdcache: fix weird request_mask manipulation in mdcache_refresh_attrs
by Jeff Layton (GerritHub) 26 Apr '22

26 Apr '22

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537150 ) Change subject: mdcache: fix weird request_mask manipulation in mdcache_refresh_attrs ...................................................................... mdcache: fix weird request_mask manipulation in mdcache_refresh_attrs I suspect we meant to add ATTR4_SEC_LABEL here, and not everything but. Change-Id: Id236f7899ab6d35000e5acaeb5cac1af6ca54ae6 Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/537150/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537150 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id236f7899ab6d35000e5acaeb5cac1af6ca54ae6 Gerrit-Change-Number: 537150 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Increase LEASE_LIFETIME_DEFAULT from 60 to 120
by liyinshu (GerritHub) 24 Apr '22

24 Apr '22

liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537027 ) Change subject: Increase LEASE_LIFETIME_DEFAULT from 60 to 120 ...................................................................... Increase LEASE_LIFETIME_DEFAULT from 60 to 120 In our cluster, when LEASE_LIFETIME_DEFAULT is 60, cause lease expired, and recreate session, every 5 minutes. So change it from 60 to 120. Change-Id: I1bfe1d4f5b8f7a482a98ed1c362141dd992b13fd Signed-off-by: liyinshu <liyinshu(a)bytedance.com> --- M src/support/nfs_read_conf.c M src/include/gsh_config.h 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/537027/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537027 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1bfe1d4f5b8f7a482a98ed1c362141dd992b13fd Gerrit-Change-Number: 537027 Gerrit-PatchSet: 1 Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Reap entry when higher than fds_hiwat
by liyinshu (GerritHub) 23 Apr '22

23 Apr '22

liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536998 ) Change subject: Reap entry when higher than fds_hiwat ...................................................................... Reap entry when higher than fds_hiwat Currently we compare open_fd_count and lru_state.entries_hiwat, to determine whether to reap entry from L1 to L2. But open_fd_count always be zero, because when touch file, NFSv4.1 only call OP_OPEN, rather than OP_CREATE which increase open_fd_count. To avoid this case in future, we compare current entries_used and lru_state_entries_hiwat to determine whether reap entry. Change-Id: I9d786f60ddfd49e02bb838637f96b234051c2e68 Signed-off-by: liyinshu <liyinshu(a)bytedance.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 18 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/536998/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536998 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9d786f60ddfd49e02bb838637f96b234051c2e68 Gerrit-Change-Number: 536998 Gerrit-PatchSet: 1 Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com> Gerrit-MessageType: newchange

1 0

Reminder: Spring 2022 NFS Bake-a-thon
by Chuck Lever III 22 Apr '22

22 Apr '22

Greetings, This is a reminder that the Spring 2022 NFS bake-a-thon is happening next week, April 25 - 29, as a virtual event. More information about about the event and registration instructions are here: http://www.nfsv4bat.org/Events/2022/Apr/BAT/index.html Looking forward to seeing you (virtually) next week! -- Chuck Lever

1 0

FSAL_VFS ACL mapping and FreeBSD
by Martin Schwenke 13 Apr '22

13 Apr '22

TL;DR: I have implemented NFSv4 -> POSIX ACL mapping in FSAL_VFS. I would like to submit a simplified version that doesn't attempt to build on FreeBSD. That would vastly simplify the code and reduce the amount of review required. It would look something like this: https://github.com/martin-schwenke/nfs-ganesha/commits/vfs-acls-no-freebsd Some of the "build" commits could be squashed together if desired. Details: I have implemented NFSv4 -> POSIX ACL mapping in FSAL_VFS. Once I understood what needed to be done, this was a fairly simple plumbing job... apart from FreeBSD compatibility. This is currently sitting in https://github.com/martin-schwenke/nfs-ganesha/commits/vfs-acls However, before putting it up for review, I have some questions, mostly about FreeBSD support. First, the ACL part of the discussion... Although FreeBSD supports POSIX ACLs, I don't think anyone wants to use a mapping to POSIX ACLs on FreeBSD. I think they would want to use FreeBSD's NFSv4 ACLs on ZFS. That would mean including some entirely different hunks of code in src/FSAL/FSAL_VFS/vfs/attrs.c, or perhaps even src/FSAL/FSAL_VFS/zfs/. I think my attempts at fixing the FreeBSD build (see below) show that I'm not qualified to attempt this. It should be done by an experienced FreeBSD developer. Now for the build problems... While getting this to compile I found several places where NFS Ganesha wouldn't compile on FreeBSD. Some of this might be because I was using the default clang compiler, but switching to gcc made things fail in different places, so I stuck with the default. The simplest solution was this: cmake -DUSE_9P=OFF -DUSE_NFS3=OFF \ -DUSE_FSAL_PROXY_V4=OFF -DUSE_FSAL_GPFS=OFF \ -DUSE_GSS=OFF \ ../nfs-ganesha/src Then I only needed a couple the first couple of fixes from: https://github.com/martin-schwenke/nfs-ganesha/commits/freebsd-build-fixes * If I switch on 9p and NFS3 then I need the rest, but those "fixes" become increasingly dodgy. * It seems clear that the GPFS support should be more cooperative about disabling itself without being forced off. I'll look into that some other time. * Building with GSS support has link-time problems resolving symbols in Kerberos libraries. My lack of understanding about FreeBSD's different Kerberos versions and how to make them play nicely with cmake made me shrug my shoulders and move on. This isn't fixed in the above branch. * I'm happy to take advice on which of the above fixes I should submit for upstream inclusion. The first 3 or 4 seem fairly obvious. In summary, the FreeBSD build seems quite broken. NFS Ganesha was removed from FreeBSD's ports and it seems that not many people care. If people agree then, to simplify the code, I can drop all of the FreeBSD compatibility and only enable the ACL mapping if Linux's acl/libacl.h is available. Thanks... peace & happiness, martin

3 5

Change in ...nfs-ganesha[next]: FSAL_VFS: Implement NFSv4 to POSIX ACL mapping
by Martin Schwenke (GerritHub) 13 Apr '22

13 Apr '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536259 ) Change subject: FSAL_VFS: Implement NFSv4 to POSIX ACL mapping ...................................................................... FSAL_VFS: Implement NFSv4 to POSIX ACL mapping Implemented in vfs subfsal via sub-ops, using libacl and the Linux acl_{get,set}_fd_np() replacements. Based on similar implementations in FSAL_CEPH and FSAL_GLUSTER. ENABLE_VFS_POSIX_ACL is now ON by default, so this will be built when possible. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I23b13738818271f80f43b903acb1f0bf4b1bdc0c --- M src/FSAL/FSAL_VFS/vfs/attrs.c M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt M src/CMakeLists.txt 3 files changed, 199 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/536259/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536259 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I23b13738818271f80f43b903acb1f0bf4b1bdc0c Gerrit-Change-Number: 536259 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: build: Add ENABLE_VFS_POSIX_ACL
by Martin Schwenke (GerritHub) 13 Apr '22

13 Apr '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536258 ) Change subject: build: Add ENABLE_VFS_POSIX_ACL ...................................................................... build: Add ENABLE_VFS_POSIX_ACL This will enable NFSv4 to POSIX ACL mapping in FSAL_VFS. It currently defaults to OFF to avoid breaking bisection while code is being added. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I08c3fa49db317629458d3cc28752ee43efb0eaf2 --- M src/CMakeLists.txt M src/include/config-h.in.cmake 2 files changed, 59 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/536258/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536258 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I08c3fa49db317629458d3cc28752ee43efb0eaf2 Gerrit-Change-Number: 536258 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_VFS: Put debug ACL code under a single #ifdef
by Martin Schwenke (GerritHub) 13 Apr '22

13 Apr '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536257 ) Change subject: FSAL_VFS: Put debug ACL code under a single #ifdef ...................................................................... FSAL_VFS: Put debug ACL code under a single #ifdef More code is coming here. Having more #ifdef's sprinkled through the function bodies is going to make this unreadable and unmaintainable. So, create a single section of code to be used when ENABLE_VFS_DEBUG_ACL is enabled. Factor out the bits that are reusable. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: Ic9044e66cd034e1aeb9ec8aea59e17fb89a45b63 --- M src/FSAL/FSAL_VFS/vfs/attrs.c 1 file changed, 79 insertions(+), 38 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/536257/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536257 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic9044e66cd034e1aeb9ec8aea59e17fb89a45b63 Gerrit-Change-Number: 536257 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_VFS: Fix comment typo
by Martin Schwenke (GerritHub) 13 Apr '22

13 Apr '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536256 ) Change subject: FSAL_VFS: Fix comment typo ...................................................................... FSAL_VFS: Fix comment typo Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: If2793b46497f8a3a900fb150ccfbf723f8c99be8 --- M src/FSAL/FSAL_VFS/vfs/attrs.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/536256/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536256 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If2793b46497f8a3a900fb150ccfbf723f8c99be8 Gerrit-Change-Number: 536256 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: build: Add ENABLE_VFS_ACL
by Martin Schwenke (GerritHub) 13 Apr '22

13 Apr '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536255 ) Change subject: build: Add ENABLE_VFS_ACL ...................................................................... build: Add ENABLE_VFS_ACL This is used to enable ACL-specific code in FSAL_VFS. For now this is only used when setting VFS_SUPPORTED_ATTRIBUTES and XFS_SUPPORTED_ATTRIBUTES. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: Iea7243db061114ad83ce4a3cb72517b7e68742a8 --- M src/FSAL/FSAL_VFS/xfs/main.c M src/CMakeLists.txt M src/include/config-h.in.cmake M src/FSAL/FSAL_VFS/vfs/main-c.in.cmake 4 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/536255/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/536255 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iea7243db061114ad83ce4a3cb72517b7e68742a8 Gerrit-Change-Number: 536255 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0