Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 )
Change subject: Allow EXPORT pseudo path to be changed during export update
......................................................................
Allow EXPORT pseudo path to be changed during export update
This also fully allows adding or removing NFSv4 support from an export
since we can now handle the PseudoFS swizzing that occurs.
Note that an explicit PseudoFS export may be removed or added, though
you can not change it from export_id 0 because we currently don't allow
changing the export_id.
Note that this patch doesn't handle DBUS add or remove export though
that is an option to improve. I may add them to this patch (it wouldn't
be that hard) but I want to get this reviewed as is right now.
There are implications to a client of changing the PseudoFS. I have
tested moving an export in the PseudoFS with a client mounted. The
client will be able to continue accessing the export, though it may
see an ESTALE error if it navigates out of the export. The current
working directory will go bad and the pwd comment will fail indicating
a disconnected mount. I have also seen referencing .. from the root of
the export wrapping around back to the root (I believe this is how
disconnected mounts are set up).
FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3
handle where the inode isn't cached) which fail during an export update
are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or
NFS3ERR_JUKEBOX to force the client to retry under the completed update.
Change-Id: I507dc17a651936936de82303ff1291677ce136be
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_PSEUDO/handle.c
M src/MainNFSD/libganesha_nfsd.ver
M src/Protocols/NFS/nfs4_pseudo.c
M src/include/export_mgr.h
M src/include/nfs_proto_functions.h
M src/support/export_mgr.c
M src/support/exports.c
7 files changed, 560 insertions(+), 203 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be
Gerrit-Change-Number: 490334
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
10 months, 2 weeks
Re: Ganesha crash while doing Delegation recall
by Frank Filz
V2.8 is pretty old and no longer supported. Additionally, I don't know if
delegations have been tested or supported recently at all so I doubt there's
any fixes but you could certainly try a newer release, or look through the
git history.
Frank
From: Sunil Bhargo [mailto:sbhargo@vmware.com]
Sent: Thursday, April 28, 2022 6:21 AM
To: devel(a)lists.nfs-ganesha.org
Cc: ffilzlnx(a)mindspring.com; dang(a)redhat.com; Sriram Patil
<sriramp(a)vmware.com>
Subject: [NFS-Ganesha-Devel] Ganesha crash while doing Delegation recall
Hi,
Currently seeing the following crash and it is a recurrent crash. We
are using ganesha 2.8.4. Can someone please help in telling if this is a
known issue and whether it is fixed in later releases ?
(gdb) bt
#0 0x00007fcc26df6570 in pthread_mutex_lock () from /lib/libpthread.so.0
#1 0x00007fcc2760906c in svc_rqst_expire_insert () from
/lib/libntirpc.so.1.8
#2 0x00007fcc275f2e19 in clnt_req_callback () from /lib/libntirpc.so.1.8
#3 0x00007fcc27855c3e in nfs_rpc_call () from /lib/libganesha_nfsd.so.2.8
#4 0x00007fcc27856a13 in nfs_rpc_cb_single () from
/lib/libganesha_nfsd.so.2.8
#5 0x00007fcc278837a4 in delegrecall_one () from
/lib/libganesha_nfsd.so.2.8
#6 0x00007fcc27884422 in delegrecall_impl () from
/lib/libganesha_nfsd.so.2.8
#7 0x00007fcc27886900 in queue_delegrecall () from
/lib/libganesha_nfsd.so.2.8
#8 0x00007fcc278e6da9 in fridgethr_start_routine () from
/lib/libganesha_nfsd.so.2.8
#9 0x00007fcc26df3f87 in start_thread () from /lib/libpthread.so.0
#10 0x00007fcc268755bf in clone () from /lib/libc.so.6
This seems like a channel is removed while it is being accessed by the
backchannel.
Thanks,
Sunil Bhargo
2 years, 8 months
Announce Push of V4.0.5
by Frank Filz
Branch next
Tag:V4.0.5
Merge Highlights
* mdcache: fix weird request_mask manipulation in mdcache_refresh_attrs
* NFS: fix handling of unrecognized attrs (2 patches)
* Increase the max value of Lease_Lifetime from 120 to 180
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
c7a1fc537 Frank S. Filz V4.0.5
7ecb78e79 liyinshu Increase the max value of Lease_Lifetime from 120 to 180
8a94e1b9f Jeff Layton NFS: fix handling of unrecognized attrs in
GETATTR/VERIFY/NVERIFY
d1b172acf Jeff Layton NFS: return NFS4ERR_ATTRNOTSUPP when client attempts
to set unknown attribute
68703b6da Jeff Layton mdcache: fix weird request_mask manipulation in
mdcache_refresh_attrs
2 years, 8 months
Change in ...nfs-ganesha[next]: test commit #1
by Rakshitha Kamath (GerritHub)
Rakshitha Kamath has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537317 )
Change subject: test commit #1
......................................................................
test commit #1
Change-Id: Idc9c10cce8be0bb5924c384e44dda4198c32fa98
Signed-off-by: rakshithakamath94(a)gmail.com <rkamath(a)redhat.com>
---
M README.md
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/537317/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537317
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Idc9c10cce8be0bb5924c384e44dda4198c32fa98
Gerrit-Change-Number: 537317
Gerrit-PatchSet: 1
Gerrit-Owner: Rakshitha Kamath <rkamath(a)redhat.com>
Gerrit-MessageType: newchange
2 years, 8 months
Change in ...nfs-ganesha[next]: testing
by Kaleb KEITHLEY (GerritHub)
Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537301 )
Change subject: testing
......................................................................
testing
Change-Id: Iaa6dc4aeb36649237bb2de1793630b88b67b3a0f
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
---
M src/MainNFSD/nfs_main.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/537301/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537301
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Iaa6dc4aeb36649237bb2de1793630b88b67b3a0f
Gerrit-Change-Number: 537301
Gerrit-PatchSet: 1
Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>
Gerrit-MessageType: newchange
2 years, 8 months
Change in ...nfs-ganesha[next]: test new centos CI
by Kaleb KEITHLEY (GerritHub)
Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537300 )
Change subject: test new centos CI
......................................................................
test new centos CI
Change-Id: I5bd70adeb716a9e75dd4d03efd8e7b2a34e83655
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
---
M src/MainNFSD/nfs_main.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/537300/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537300
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I5bd70adeb716a9e75dd4d03efd8e7b2a34e83655
Gerrit-Change-Number: 537300
Gerrit-PatchSet: 1
Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>
Gerrit-MessageType: newchange
2 years, 8 months
Ganesha crash while doing Delegation recall
by Sunil Bhargo
Hi,
Currently seeing the following crash and it is a recurrent crash. We are using ganesha 2.8.4. Can someone please help in telling if this is a known issue and whether it is fixed in later releases ?
(gdb) bt
#0 0x00007fcc26df6570 in pthread_mutex_lock () from /lib/libpthread.so.0
#1 0x00007fcc2760906c in svc_rqst_expire_insert () from /lib/libntirpc.so.1.8
#2 0x00007fcc275f2e19 in clnt_req_callback () from /lib/libntirpc.so.1.8
#3 0x00007fcc27855c3e in nfs_rpc_call () from /lib/libganesha_nfsd.so.2.8
#4 0x00007fcc27856a13 in nfs_rpc_cb_single () from /lib/libganesha_nfsd.so.2.8
#5 0x00007fcc278837a4 in delegrecall_one () from /lib/libganesha_nfsd.so.2.8
#6 0x00007fcc27884422 in delegrecall_impl () from /lib/libganesha_nfsd.so.2.8
#7 0x00007fcc27886900 in queue_delegrecall () from /lib/libganesha_nfsd.so.2.8
#8 0x00007fcc278e6da9 in fridgethr_start_routine () from /lib/libganesha_nfsd.so.2.8
#9 0x00007fcc26df3f87 in start_thread () from /lib/libpthread.so.0
#10 0x00007fcc268755bf in clone () from /lib/libc.so.6
This seems like a channel is removed while it is being accessed by the backchannel.
Thanks,
Sunil Bhargo
2 years, 8 months
Change in ...nfs-ganesha[next]: NFS: fix handling of unrecognized attrs in GETATTR/VERIFY/NVERIFY
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537152 )
Change subject: NFS: fix handling of unrecognized attrs in GETATTR/VERIFY/NVERIFY
......................................................................
NFS: fix handling of unrecognized attrs in GETATTR/VERIFY/NVERIFY
In the case of VERIFY/NVERIFY we want to return NFS4ERR_ATTRNOTSUPP,
since that's what the spec recommends. For a GETATTR request however,
just ignore the error and return whatever values we can in the reply.
Change-Id: I2bc6f635c939d220f8fc8268444816442e1bd217
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs_proto_tools.c
M src/Protocols/NFS/nfs4_op_getattr.c
2 files changed, 20 insertions(+), 6 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/537152/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537152
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2bc6f635c939d220f8fc8268444816442e1bd217
Gerrit-Change-Number: 537152
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
2 years, 8 months
Change in ...nfs-ganesha[next]: NFS: return NFS4ERR_ATTRNOTSUPP when client attemps to set unknown at...
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537151 )
Change subject: NFS: return NFS4ERR_ATTRNOTSUPP when client attemps to set unknown attribute
......................................................................
NFS: return NFS4ERR_ATTRNOTSUPP when client attemps to set unknown attribute
RFC5661 says this in the SETATTR section:
"If the server does not support an attribute as requested by the client,
the server SHOULD return NFS4ERR_ATTRNOTSUPP."
Fix the error return here.
Change-Id: Ie6db9936409c2792b053c6a859c8eee04850189f
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs_proto_tools.c
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/537151/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537151
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie6db9936409c2792b053c6a859c8eee04850189f
Gerrit-Change-Number: 537151
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
2 years, 8 months