August 2022 - Devel - NFS Ganesha List Archives

Announce Push of V4.0.8
by Frank Filz 05 Aug '22

05 Aug '22

Branch next Tag:V4.0.8 Merge Highlights * Fix for NLM_DENIED for lock requests (issue#834) * Fix check return value of encode_posix_acl * MDCACHE: Avoid refreshing valid mdcache attrs. * CONFIG: Add alt name for block * MDCACHE: Use new altname for config block to correct use of either name Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 98fc2a9bb Frank S. Filz V4.0.8 64c52da15 Frank S. Filz MULTILOCK: Make compile with latest ceph 4645b019f Yogendra Charya Fix for NLM_DENIED for lock requests (issue#834) 9629ad115 Gaurav Gangalwar MDCACHE: Avoid refreshing valid mdcache attrs. ed3861472 liyinshu Fix check return value of encode_posix_acl efb447b6a Frank S. Filz MDCACHE: Use new altname for config block to correct use of either name 4fc7981c6 Frank S. Filz CONFIG: Add alt name for block

1 0

[M] Change in ...nfs-ganesha[next]: Fix crash at inc/dec_state_t_ref
by liyinshu (GerritHub) 05 Aug '22

05 Aug '22

liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542008 ) Change subject: Fix crash at inc/dec_state_t_ref ...................................................................... Fix crash at inc/dec_state_t_ref If state's ref count is 1, reproduce crash as follows: thread1: nfs4_op_close.c:180 inc ref to 2. thread2: nfs4_op_lock:178 inc ref to 3. thread1: nfs4_op_close.c:306 dec ref to 2. thread1: nfs4_op_close.c:336 dec ref to 1. thread2: nfs4_op_lock.c:742 dec ref to 0 and free this state. thread3: nfs4_op_read.c:465 inc ref of this freed state. So get openstate from hashtable every time. Change-Id: Ib5782c6cab422df1131748dfd552ff38dbb9d8c3 Signed-off-by: liyinshu <liyinshu(a)bytedance.com> --- M src/FSAL/commonlib.c M src/Protocols/NFS/nfs4_op_allocate.c M src/Protocols/NFS/nfs4_op_lock.c M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_setattr.c M src/Protocols/NFS/nfs4_op_write.c M src/SAL/nfs4_state.c M src/include/FSAL/fsal_commonlib.h M src/include/sal_data.h 9 files changed, 85 insertions(+), 41 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/542008/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542008 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib5782c6cab422df1131748dfd552ff38dbb9d8c3 Gerrit-Change-Number: 542008 Gerrit-PatchSet: 1 Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: config: Reverse sense of result from block check() method
by Martin Schwenke (GerritHub) 04 Aug '22

04 Aug '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542002 ) Change subject: config: Reverse sense of result from block check() method ...................................................................... config: Reverse sense of result from block check() method Logically, a check() function should return true on success. However, this one returns true on failure. check_export_duplicate() is currently the only instance of check(), so swap the meaning of the result before a confusing anti-pattern is established. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: If82672e7e1498a08843ee51a7ae21d81f960b996 --- M src/config_parsing/config_parsing.c M src/support/exports.c 2 files changed, 23 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/542002/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542002 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If82672e7e1498a08843ee51a7ae21d81f960b996 Gerrit-Change-Number: 542002 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Fix crash at data->slot->cached_result is NULL
by liyinshu (GerritHub) 01 Aug '22

01 Aug '22

liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541868 ) Change subject: Fix crash at data->slot->cached_result is NULL ...................................................................... Fix crash at data->slot->cached_result is NULL Change-Id: Ib123af995e581f07b3b4d9139992d8c0f041dc60 Signed-off-by: liyinshu <liyinshu(a)bytedance.com> --- M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_sequence.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/541868/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541868 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib123af995e581f07b3b4d9139992d8c0f041dc60 Gerrit-Change-Number: 541868 Gerrit-PatchSet: 1 Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com> Gerrit-MessageType: newchange

1 0