[XL] Change in ...nfs-ganesha[next]: Split CLIENT list out to separate handling
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548332 )
Change subject: Split CLIENT list out to separate handling
......................................................................
Split CLIENT list out to separate handling
The Clients list matching for EXPORT CLIENT blocks is extracted for
general client matching.
Change-Id: I52c0f331228ea14c914e2a824ccbb762e6065629
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/Protocols/NFS/mnt_Export.c
M src/include/client_mgr.h
M src/include/nfs_exports.h
M src/support/client_mgr.c
M src/support/export_mgr.c
M src/support/exports.c
6 files changed, 738 insertions(+), 535 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/548332/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548332
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I52c0f331228ea14c914e2a824ccbb762e6065629
Gerrit-Change-Number: 548332
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
1 year, 11 months
Symbolic Links Issue on FSAL_VFS
by Frank Filz
Prabhu,
What filesystem are you exporting with FSAL_VFS? And any chance you are
running Ganesha on FreeBSD?
I looked into symlinks on EXT4 on Linux and it seems just fine. I forced a
"create_handle" for a symlink and it worked just fine (I did an ls -l of a
directory with a symlink, then restarted Ganesha, then did a cat
/mnt/export/dir/the-link which worked fine and showed open_by_handle_at
opening the symlink object and allowing stat etc. on it. However, I see in
FreeBSD open_by_handle_at can return -EMLINK so that might be your issue.
And I also just forced the issue without a restart by having a large dirent
cache but a small entry cache and causing the entry cache to be flushed.
Please turn on READDIR and FSAL FULL_DEBUG and let's see if we can figure
out what's going on.
Frank
1 year, 11 months
[S] Change in ...nfs-ganesha[next]: Fixed nfs-service down issue when 3rd export got added
by Name of user not set (GerritHub)
yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548115 )
Change subject: Fixed nfs-service down issue when 3rd export got added
......................................................................
Fixed nfs-service down issue when 3rd export got added
private_data not assigned with gpfs_fs if the filesystem
claimed already.
Change-Id: I0ca3f732e2f78ec49f2336e5aea660d4f7d15eda
Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com>
---
M src/FSAL/FSAL_GPFS/export.c
M src/FSAL/localfs.c
2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/548115/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548115
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I0ca3f732e2f78ec49f2336e5aea660d4f7d15eda
Gerrit-Change-Number: 548115
Gerrit-PatchSet: 1
Gerrit-Owner: yogendra858(a)yahoo.com
Gerrit-MessageType: newchange
1 year, 12 months
[S] Change in ...nfs-ganesha[next]: Fix crash for used after free of res_compound4_extended when replay r...
by liyinshu (GerritHub)
liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548005 )
Change subject: Fix crash for used after free of res_compound4_extended when replay request
......................................................................
Fix crash for used after free of res_compound4_extended when replay request
This caused by commit 5f06bd1c40b89c726ccb0f0284caace66d12a1d0, which first
release_nfs4_res_compound(data->res->res_compound4_extended), then assign
res_SEQUENCE4->sr_status with NFS4_OK. Because res_SEQUENCE4 is in
data->res->res_compound4_extended, so heap used after free happens.
Actually we did not need to assign res_SEQUENCE4->sr_status with NFS4_OK
for replay request, because it will comes from slot->cached_result.
Even before commit 5f06bd1c40b89c726ccb0f0284caace66d12a1d0,
the res_SEQUENCE4 also will be freed in complete_op by release_nfs4_res_compound,
so we did not need to assign the value of res_SEQUENCE4.
Change-Id: I9e3f4823e23718bf421c5237cc78a878b6f3014e
Signed-off-by: liyinshu <liyinshu(a)bytedance.com>
---
M src/Protocols/NFS/nfs4_op_sequence.c
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/548005/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548005
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I9e3f4823e23718bf421c5237cc78a878b6f3014e
Gerrit-Change-Number: 548005
Gerrit-PatchSet: 1
Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com>
Gerrit-MessageType: newchange
2 years