July 2023 - Devel - Nfs Ganesha List Archives

by Frank Filz

Branch next Tag:V5.3.3 Merge Highlights * Disable GPFS fsal async block lock support * Add options to cmake to use spectrum's libwbclient.so library. * Change RPC_Max_Connections max value to 1,000,000 * fix to use credential info from rpc if group resolution fails. * Avoids parallel allocation with multi-threaded access * PSEUDO_FSAL: Fix access to non-initialized structs in handle * nfs4_op_exchange_id: pnfs server flags should not be empty * mdcache bloating due to unreleased refcount during readdir Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 566310011 Frank S. Filz V5.3.3 432785ec4 Deepak Arumugam Sankara Subramanian mdcache bloating due to unreleased refcount during readdir a48cfbd5f Assaf Yaari nfs4_op_exchange_id: pnfs server flags should not be empty 7306defe9 Shahar Hochma PSEUDO_FSAL: Fix access to non-initialized structs in handle c7b873ddf Rojin George Avoids parallel allocation with multi-threaded access ce7875d69 Yogendra Charya fix to use credential info from rpc if group resolution fails. 23900c389 Prabhu Murumesan Change RPC_Max_Connections max value to 1,000,000 da4245a97 Malahal Naineni Add options to cmake to use spectrum's libwbclient.so library. ac2ec85d5 Malahal Naineni Disable GPFS fsal async block lock support

1 year, 5 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Change RPC_Max_Connections max value to UINT32_MAX

by Name of user not set (GerritHub)

skmprabhu252(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556581?usp=email ) Change subject: Change RPC_Max_Connections max value to UINT32_MAX ...................................................................... Change RPC_Max_Connections max value to UINT32_MAX The current max value is 10K, and this can be safely increased to a 1000k. Anything larger also needs a suitable change to increase the number of file descriptors that can be opened by a process (the default fs.nr_open is 1024*1024 = 1048576 on RHEL distro). Change-Id: If15b5bb3976c75cf62babd2bb003917befbcef14 Signed-off-by: Prabhu Murugesan <prabhu.murugesan1(a)ibm.com> --- M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/support/nfs_read_conf.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/556581/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556581?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If15b5bb3976c75cf62babd2bb003917befbcef14 Gerrit-Change-Number: 556581 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Add options to cmake to use spectrum's libwbclient.so library.

by Name of user not set (GerritHub)

Attention is currently required from: Malahal. Hello Malahal, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556580?usp=email to review the following change. Change subject: Add options to cmake to use spectrum's libwbclient.so library. ...................................................................... Add options to cmake to use spectrum's libwbclient.so library. These cmake additional options supplied by Swen (schillig(a)de.ibm.com) make the product build with RPATH that we need to use spectrum's libwbclient.so which is at /usr/lpp/mmfs/lib64. This is a temporary solution until we find a way to make cmake options propogate to rpmbuilds without directly modifying this spec file. Change-Id: Ia0e16e6143f15f8bdc58f814a3778c38e87a3846 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/556580/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556580?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia0e16e6143f15f8bdc58f814a3778c38e87a3846 Gerrit-Change-Number: 556580 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-Reviewer: Malahal <malahal(a)gmail.com> Gerrit-Attention: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Disable GPFS fsal async block lock support

by Name of user not set (GerritHub)

Attention is currently required from: Malahal. Hello Malahal, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556579?usp=email to review the following change. Change subject: Disable GPFS fsal async block lock support ...................................................................... Disable GPFS fsal async block lock support Async block lock support is broken at the moment in GPFS and leads to Linux kernel panics. Disable it in GPFS fsal until it is fixed. Change-Id: I8d7f10a26b7c4830921f97469e56da9300a56b97 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/FSAL_GPFS/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/556579/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556579?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8d7f10a26b7c4830921f97469e56da9300a56b97 Gerrit-Change-Number: 556579 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-Reviewer: Malahal <malahal(a)gmail.com> Gerrit-Attention: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: MDCACHE: remove all active entries from LRU L1 and L2

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556554?usp=email ) Change subject: MDCACHE: remove all active entries from LRU L1 and L2 ...................................................................... MDCACHE: remove all active entries from LRU L1 and L2 It turns out that entries with elevated refcount clog up L1 and L2 so that entries can not be reaped and the cache grows unbounded. So outside the LRU reaping process itself, remove any entry with an elevated refcount from the LRU. This replaces the long term reference concept. Additionally, be explicit when the sentinel reference is being released. This allows for some code cleanup in other areas. Also, LRU_REQ_INITIAL was supposed to be replaced with LRU_PROMOTE in all cases. Change-Id: If63e31ff2d7490f023b142698e12c444c7432ea8 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c M src/FSAL/default_methods.c M src/Protocols/9P/9p_lcreate.c M src/Protocols/9P/9p_lopen.c M src/Protocols/9P/9p_proto_tools.c M src/Protocols/9P/9p_remove.c M src/Protocols/NFS/nfs4_pseudo.c M src/SAL/nfs4_state.c M src/SAL/nlm_state.c M src/include/fsal_api.h M src/include/gsh_lttng/mdcache.h M src/support/exports.c 21 files changed, 288 insertions(+), 360 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/556554/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556554?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If63e31ff2d7490f023b142698e12c444c7432ea8 Gerrit-Change-Number: 556554 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: cid_server_scope being a global variable, we were allocating it, with...

by Rojin George (GerritHub)

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556505?usp=email ) Change subject: cid_server_scope being a global variable, we were allocating it, with check cid_server_owner[0] == '\0'. But this check is not protected, so this check will be passed by other thread running in parallel, which could result also result in race between allocation by other thread and later memcpy, while building the reply. Hence making allocation atomic, with mutex ...................................................................... cid_server_scope being a global variable, we were allocating it, with check cid_server_owner[0] == '\0'. But this check is not protected, so this check will be passed by other thread running in parallel, which could result also result in race between allocation by other thread and later memcpy, while building the reply. Hence making allocation atomic, with mutex Change-Id: I3e625194f0f20dfe6cecc50141638d1ab40f901c Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/Protocols/NFS/nfs4_op_exchange_id.c 1 file changed, 44 insertions(+), 36 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/556505/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556505?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3e625194f0f20dfe6cecc50141638d1ab40f901c Gerrit-Change-Number: 556505 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: mdcache bloating due to unreleased refcount during readdir

by Name of user not set (GerritHub)

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556455?usp=email ) Change subject: mdcache bloating due to unreleased refcount during readdir ...................................................................... mdcache bloating due to unreleased refcount during readdir We should release the refcount of a entry if there is a collision related error inside mdc_readdir_chunk_object. If we don't do this the refcount of the entry stays along until the corresponding chunk LRU entry is reaped. We saw instances where this entry becomes the last entry of a lane preventing any entry in the lane from being reaped. Furthermore, when this collision happens we don't put the dirent inside state.cur_chunk - the dirent is stuck left with whatever its old parent chunk was. This makes it impossible for any of the caller functions to know about this dirent and free up its entry refcount since we returned a DIR_TERMINATE_ERROR. For this reason its probably best to release the refcount in this function itself Change-Id: Ia728bbf5018174273cd1a5128a67d1aca73614c9 Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/556455/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia728bbf5018174273cd1a5128a67d1aca73614c9 Gerrit-Change-Number: 556455 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: fix to use credential info from rpc if group resolution fails.

by Name of user not set (GerritHub)

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556391?usp=email ) Change subject: fix to use credential info from rpc if group resolution fails. ...................................................................... fix to use credential info from rpc if group resolution fails. if Manage_Gids=True and group resolution fails from auth server, then use gid data from rpc request. This will fix issue#946 Change-Id: I63aaec949d0bfea948779e2836dbc2baf48874e6 Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com> --- M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_creds.c M src/support/nfs_read_conf.c 5 files changed, 31 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/556391/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556391?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I63aaec949d0bfea948779e2836dbc2baf48874e6 Gerrit-Change-Number: 556391 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: PSEUDO_FSAL: Fix access to non-initialized structs in handle

by Name of user not set (GerritHub)

shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556291?usp=email ) Change subject: PSEUDO_FSAL: Fix access to non-initialized structs in handle ...................................................................... PSEUDO_FSAL: Fix access to non-initialized structs in handle In verify_handle_is_valid we accessed the state_hdl, but it wasn't initialized. It is only initialized in MDCache, and so we cannot access if from within the FSAL. This could cause a segmentation fault. I removed verify_handle_is_valid, but it was intended to prevent a race where a lookup returns a file handle before the export update process is done updating its junction_export. In order to avoid this race I changed lookup and readdir to always return ERR_FSAL_DELAY when export update is in progress. This caused another issue, where the export update process itself calls lookup when it creates the node. In order to allow it to get the correct response during the export update I use op_ctx->fsal_private to signal to the FSAL that it should return the current response. Change-Id: If1f3065525f68ba67499d4981b068ef7287cdd69 Signed-off-by: Shahar Hochma <shaharhoch(a)gmail.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/Protocols/NFS/nfs4_pseudo.c 2 files changed, 15 insertions(+), 39 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/556291/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If1f3065525f68ba67499d4981b068ef7287cdd69 Gerrit-Change-Number: 556291 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)gmail.com Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: FSAL_PSEUDO/handle: Init handle state

by Name of user not set (GerritHub)

shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556290?usp=email ) Change subject: FSAL_PSEUDO/handle: Init handle state ...................................................................... FSAL_PSEUDO/handle: Init handle state Previously the handle state wasn't used in the PSEUDO_FSAL and it wasn't initialized. Lately we added a patch to that looks that the jct_lock in handle state, and so it must be initialized on handle initialization. Change-Id: Iceb750fad585738c642b58957d17c325db70b204 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/FSAL_PSEUDO/handle.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/556290/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iceb750fad585738c642b58957d17c325db70b204 Gerrit-Change-Number: 556290 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)gmail.com Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel July 2023