February 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: uid2grp: Miscellaneous refactoring
by Dipit Grover (GerritHub) 06 Feb '24

06 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176495?usp=email ) Change subject: uid2grp: Miscellaneous refactoring ...................................................................... uid2grp: Miscellaneous refactoring * Add comments for some functions defined in uid2grp_cache.c * Update existing comments in uid2grp.c and uid2grp_cache.c * Add asserts for unexpected situations while doing inserts in uid2grp_cache * Replace uid2grp_expired macro in uid2grp.c with uid2grp_is_group_data_expired function Change-Id: I6fbdf3a2bf32cdc23c7580bb89056ade64c5b132 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/uid2grp.c M src/support/uid2grp_cache.c 2 files changed, 28 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1176495/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176495?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6fbdf3a2bf32cdc23c7580bb89056ade64c5b132 Gerrit-Change-Number: 1176495 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: uid2grp_cache: Expose expiry related functions
by Dipit Grover (GerritHub) 06 Feb '24

06 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176494?usp=email ) Change subject: uid2grp_cache: Expose expiry related functions ...................................................................... uid2grp_cache: Expose expiry related functions * Expose functions to remove expired cache entries * Expose function to check if group-data is expired Change-Id: I0adb1dbe6953acbc1382eaa820c26ae8a39493ed Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/include/uid2grp.h M src/support/uid2grp_cache.c 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/1176494/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0adb1dbe6953acbc1382eaa820c26ae8a39493ed Gerrit-Change-Number: 1176494 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: idmapper_cache: Do not re-insert expired entry's attributes
by Dipit Grover (GerritHub) 06 Feb '24

06 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176490?usp=email ) Change subject: idmapper_cache: Do not re-insert expired entry's attributes ...................................................................... idmapper_cache: Do not re-insert expired entry's attributes When inserting a user entry into the idmapper cache, some attributes of the new entry are derived from the existing cached entry, if both have the same uid. This should not be done if the existing entry is already expired. Change-Id: I1baed2f9e46ff3b69b4a89d30dd0ccfc6a4e21b4 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper_cache.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/1176490/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1baed2f9e46ff3b69b4a89d30dd0ccfc6a4e21b4 Gerrit-Change-Number: 1176490 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[L] Change in ...nfs-ganesha[next]: Change link, unlink and rename operations to return attomic pre/post ...
by Name of user not set (GerritHub) 05 Feb '24

05 Feb '24

shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176456?usp=email ) Change subject: Change link, unlink and rename operations to return attomic pre/post attributes ...................................................................... Change link, unlink and rename operations to return attomic pre/post attributes This is done in order to allow returning atomic pre and post attrs if the underlying FSAL supports it. Change-Id: Iffcaeb83a866cab15ae54527835b713a044d0bc8 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/FSAL/FSAL_LIZARDFS/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V4/handle.c M src/FSAL/FSAL_PSEUDO/handle.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_NULL/handle.c M src/FSAL/default_methods.c M src/FSAL/fsal_helper.c M src/Protocols/9P/9p_link.c M src/Protocols/9P/9p_remove.c M src/Protocols/9P/9p_rename.c M src/Protocols/9P/9p_renameat.c M src/Protocols/9P/9p_unlinkat.c M src/Protocols/NFS/nfs3_link.c M src/Protocols/NFS/nfs3_remove.c M src/Protocols/NFS/nfs3_rename.c M src/Protocols/NFS/nfs3_rmdir.c M src/Protocols/NFS/nfs4_op_link.c M src/Protocols/NFS/nfs4_op_remove.c M src/Protocols/NFS/nfs4_op_rename.c M src/Protocols/NFS/nfs4_pseudo.c M src/gtest/fsal_api/test_close2_latency.cc M src/gtest/fsal_api/test_close_latency.cc M src/gtest/fsal_api/test_commit2_latency.cc M src/gtest/fsal_api/test_handle_to_key_latency.cc M src/gtest/fsal_api/test_handle_to_wire_latency.cc M src/gtest/fsal_api/test_link_latency.cc M src/gtest/fsal_api/test_lock_op2_latency.cc M src/gtest/fsal_api/test_mkdir_latency.cc M src/gtest/fsal_api/test_mknode_latency.cc M src/gtest/fsal_api/test_open2_latency.cc M src/gtest/fsal_api/test_read2_latency.cc M src/gtest/fsal_api/test_rename_latency.cc M src/gtest/fsal_api/test_reopen2_latency.cc M src/gtest/fsal_api/test_setattr2_latency.cc M src/gtest/fsal_api/test_symlink_latency.cc M src/gtest/fsal_api/test_unlink_latency.cc M src/gtest/fsal_api/test_write2_latency.cc M src/gtest/gtest.hh M src/gtest/nfs4/test_nfs4_link_latency.cc M src/include/fsal.h M src/include/fsal_api.h 49 files changed, 509 insertions(+), 162 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/1176456/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176456?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iffcaeb83a866cab15ae54527835b713a044d0bc8 Gerrit-Change-Number: 1176456 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)gmail.com

1 0

Announce Push of V6-dev.3
by Frank Filz 02 Feb '24

02 Feb '24

Branch next Tag:V6-dev.3 NOTE: This merge includes an ntirpc pullup, make sure to update your submodule. Merge Highlights * monitoring: fails to build with gcc-14 * FSAL_PSEUDO set change, mtime, ctime on create directory * Fix crash at release_lock_owner()-> _get_gsh_export_ref() * Two POSIX ACL fixes * Decrement fd_work while reclaiming if FD is busy * Update courteous server with Open_State_Per_Client * Grant Read delegations properly * Two stats collection enhancements * Two debug enhancements Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 7efd02681 Frank S. Filz V6-dev.3 6a59d3756 Rojin George Grant Read delegations properly 7206c3625 Rojin George Update courteous server with Open_State_Per_Client bc04a6560 Rojin George Instrumentation changes to debug future lru_try_one crash 86937006d Rojin George Clear delegation stats if no active states d9f63fe17 Rojin George Fix few typos around the fd_lru logics 764015ddf Rojin George Decrement fd_work while reclaiming if FD is busy 72409a1ff Rojin George Show state counters in ShowClient DBus, to get client level details dedf66fec bjfhdhhaha ACL: fix issue of setting posix acl for directory return EINVAL 6fc3700b4 bjfhdhhaha ACL: fix memory leak 9d0da8e04 Prabhu Murugesan Fix crash at release_lock_owner()-> _get_gsh_export_ref() aa44b73c9 Jason Woodward FSAL_PSEUDO set change, mtime, ctime on create directory a3f59784b Kaleb S. KEITHLEY monitoring: fails to build with gcc-14 32afffc6a Sachin Punadikar FSAL_CEPH : Add debug statements

1 0

[M] Change in ...nfs-ganesha[next]: GPFS: Fix unexport of 1st export on filesystem
by Frank Filz (GerritHub) 01 Feb '24

01 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176331?usp=email ) Change subject: GPFS: Fix unexport of 1st export on filesystem ...................................................................... GPFS: Fix unexport of 1st export on filesystem Rely on the localfs implementation of the map between exports and filesystems along with the new function to get a ref to the first active export on the filesystem, Change-Id: I6c04fbfd0f851a9806d5c177c588c9be0062eb84 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_GPFS/gpfs_methods.h 3 files changed, 49 insertions(+), 122 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/1176331/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176331?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6c04fbfd0f851a9806d5c177c588c9be0062eb84 Gerrit-Change-Number: 1176331 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[M] Change in ...nfs-ganesha[next]: FSAL: add function to get an export ref from a filesystem.
by Frank Filz (GerritHub) 01 Feb '24

01 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176330?usp=email ) Change subject: FSAL: add function to get an export ref from a filesystem. ...................................................................... FSAL: add function to get an export ref from a filesystem. Also move definition of struct fsal_filesystem_export_map into fsal_localfs.h Change-Id: Ie4f4ad88f8e3a22947edf9aa4c58c79925eba717 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/localfs.c M src/MainNFSD/libganesha_nfsd.ver M src/include/FSAL/fsal_localfs.h M src/include/fsal_api.h 4 files changed, 44 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/1176330/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie4f4ad88f8e3a22947edf9aa4c58c79925eba717 Gerrit-Change-Number: 1176330 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[L] Change in ...nfs-ganesha[next]: Change creation operations to return pre/post attributes for parent
by Name of user not set (GerritHub) 01 Feb '24

01 Feb '24

shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176310?usp=email ) Change subject: Change creation operations to return pre/post attributes for parent ...................................................................... Change creation operations to return pre/post attributes for parent This is done in order to allow returning atomic pre and post attrs if the underlying FSAL supports it Change-Id: I48f38d1a7c67a228e3204f537d98e3674d0c40bd Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/FSAL_GPFS/file.c M src/FSAL/FSAL_GPFS/gpfs_methods.h M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V4/handle.c M src/FSAL/FSAL_PSEUDO/handle.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/vfs_methods.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_NULL/file.c M src/FSAL/Stackable_FSALs/FSAL_NULL/handle.c M src/FSAL/Stackable_FSALs/FSAL_NULL/nullfs_methods.h M src/FSAL/default_methods.c M src/FSAL/fsal_helper.c M src/Protocols/9P/9p_lcreate.c M src/Protocols/9P/9p_mkdir.c M src/Protocols/9P/9p_mknod.c M src/Protocols/9P/9p_symlink.c M src/Protocols/NFS/nfs3_commit.c M src/Protocols/NFS/nfs3_create.c M src/Protocols/NFS/nfs3_link.c M src/Protocols/NFS/nfs3_mkdir.c M src/Protocols/NFS/nfs3_mknod.c M src/Protocols/NFS/nfs3_remove.c M src/Protocols/NFS/nfs3_rename.c M src/Protocols/NFS/nfs3_rmdir.c M src/Protocols/NFS/nfs3_setattr.c M src/Protocols/NFS/nfs3_symlink.c M src/Protocols/NFS/nfs3_write.c M src/Protocols/NFS/nfs4_op_create.c M src/Protocols/NFS/nfs4_op_open.c M src/Protocols/NFS/nfs4_pseudo.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/fsal.h M src/include/fsal_api.h M src/include/nfs_proto_tools.h 40 files changed, 464 insertions(+), 134 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/1176310/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I48f38d1a7c67a228e3204f537d98e3674d0c40bd Gerrit-Change-Number: 1176310 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)gmail.com

1 0