February 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: nfs_creds: Fix rpcsec_gss handling for anonymous user
by Dipit Grover (GerritHub) 07 Feb '24

07 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176545?usp=email ) Change subject: nfs_creds: Fix rpcsec_gss handling for anonymous user ...................................................................... nfs_creds: Fix rpcsec_gss handling for anonymous user In idmappping for RPCSEC_GSS security, existing code lacks appropriate handling of idmapping resolution to anonymous user when the creds are already loaded (after initial lookup). It assumes that if creds are already loaded, the idmapping would have resulted in resolution to non-anonymous user only. Change-Id: I576fc6700890b095f8ec214059139abe46e95d6a Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/nfs_creds.c 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/1176545/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I576fc6700890b095f8ec214059139abe46e95d6a Gerrit-Change-Number: 1176545 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: nfs_creds: Resolve extended groups from rpcsec_gss principal using nf...
by Dipit Grover (GerritHub) 07 Feb '24

07 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176533?usp=email ) Change subject: nfs_creds: Resolve extended groups from rpcsec_gss principal using nfsidmap ...................................................................... nfs_creds: Resolve extended groups from rpcsec_gss principal using nfsidmap This CL adds support for resolving extended groups from incoming rpcsec_gss principal using libnfsidmap, rather than always rely on pw-functions of lib-C that rely on linux name resolution system (using sssd for example) for resolution. Change-Id: I77af850fd97bd237c4466dbc21603c78930a08ba Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/nfs_creds.c 1 file changed, 37 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/1176533/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176533?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I77af850fd97bd237c4466dbc21603c78930a08ba Gerrit-Change-Number: 1176533 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: uid2grp: Expose principal2grp function for resolving extended groups ...
by Dipit Grover (GerritHub) 07 Feb '24

07 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176532?usp=email ) Change subject: uid2grp: Expose principal2grp function for resolving extended groups using libnfsidmap ...................................................................... uid2grp: Expose principal2grp function for resolving extended groups using libnfsidmap This commit adds an internal function to allocate group_data from principal using libnfsidmap. It uses this function in the newly added principal2grp function to resolve extended groups using the principal. Change-Id: I82fd40a9a4769c7941301e49dda215b727ed7881 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/include/uid2grp.h M src/support/uid2grp.c 2 files changed, 160 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/1176532/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I82fd40a9a4769c7941301e49dda215b727ed7881 Gerrit-Change-Number: 1176532 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: FSAL_MEM: Support pre/post attrs
by Name of user not set (GerritHub) 07 Feb '24

07 Feb '24

shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176526?usp=email ) Change subject: FSAL_MEM: Support pre/post attrs ...................................................................... FSAL_MEM: Support pre/post attrs Change-Id: Id786f2ecf79c0b44d750e8c8a7fe5164a03e544a Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/FSAL_MEM/mem_handle.c 1 file changed, 131 insertions(+), 72 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1176526/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176526?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id786f2ecf79c0b44d750e8c8a7fe5164a03e544a Gerrit-Change-Number: 1176526 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)gmail.com

1 0

[S] Change in ...nfs-ganesha[next]: Fix log_an_export critical path overhead
by Jon Kohler (GerritHub) 06 Feb '24

06 Feb '24

Jon Kohler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176508?usp=email ) Change subject: Fix log_an_export critical path overhead ...................................................................... Fix log_an_export critical path overhead LOG_EXPORT macro was added by 80fa5e56e79 ("Add some EXPORT debug"), which adds calls to log_an_export in the critical path in release binaries. Instead of reverting this commit, leave the structure and calls in place, and instead add a compiler directive to only call log_an_export IFDEF DEBUG, to allow these calls in debug binaries. Change-Id: I5287c5d02473255935efdcc3b073934ce37f761e Signed-off-by: Jon Kohler <jon(a)nutanix.com> --- M src/include/nfs_exports.h 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/1176508/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176508?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5287c5d02473255935efdcc3b073934ce37f761e Gerrit-Change-Number: 1176508 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Kohler <jon(a)nutanix.com>

1 0

[S] Change in ...nfs-ganesha[next]: use may_write == false in nfs4_State_Get_Pointer
by Jon Kohler (GerritHub) 06 Feb '24

06 Feb '24

Jon Kohler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176505?usp=email ) Change subject: use may_write == false in nfs4_State_Get_Pointer ...................................................................... use may_write == false in nfs4_State_Get_Pointer nfs4_State_Get_Pointer suffers from writer lock contention on the hashtable_getlatch() calls, as it uses may_write == true to procure the latch and subsequently increment the state_t refcount. This lock contention appears to get worse with the glibc libpthread implementation in el8 and higher; however, this contention points out an opportunity for optimization. nfs4_State_Get_Pointer is not mutating set or delete into the hashtable data structures but rather using that as a means to do an atomic increment on the state_t reference. Given that the state_t reference has its own thread safety design, switch the hashtable_getlatch() to may_write == false and modify hashtable_getlatch() to allow may_write && latch together. This allows getlatch to return with the read lock held, guaranteeing that no writers can come along and invalidate the state that was retrieved. Furthermore, all mutations (i.e. decrements) to state_t refcount are protected by the higher order calls to getlatch with may_write == true, which gaurantees that the follow on read and decrement of the refcount can be done in a thread safe manner. Change-Id: I47d59e2e31420d425eee0d5cdcbf65f8a8caa87e Change-Id: Ie36c71bcdcfab237536f6a6c94fcfe18d0af9d3d Signed-off-by: Jon Kohler <jon(a)nutanix.com> --- M src/SAL/nfs4_state_id.c M src/hashtable/hashtable.c 2 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/1176505/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176505?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie36c71bcdcfab237536f6a6c94fcfe18d0af9d3d Gerrit-Change-Number: 1176505 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Kohler <jon(a)nutanix.com>

1 0

[M] Change in ...nfs-ganesha[next]: idmapper: Add pwnam support for mapping principal to uid,gid
by Dipit Grover (GerritHub) 06 Feb '24

06 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176502?usp=email ) Change subject: idmapper: Add pwnam support for mapping principal to uid,gid ...................................................................... idmapper: Add pwnam support for mapping principal to uid,gid Change-Id: I9148d7bdde7e6299a0049aaada18b4d19f26d86f Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c 1 file changed, 92 insertions(+), 68 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1176502/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176502?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9148d7bdde7e6299a0049aaada18b4d19f26d86f Gerrit-Change-Number: 1176502 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: idmapper: Refactor pwentname2id to accommodate large entries
by Dipit Grover (GerritHub) 06 Feb '24

06 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176501?usp=email ) Change subject: idmapper: Refactor pwentname2id to accommodate large entries ...................................................................... idmapper: Refactor pwentname2id to accommodate large entries Change-Id: I7ab5a4609f31543a00a6511ecfcbb4a78a17e22a Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c 1 file changed, 86 insertions(+), 51 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1176501/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7ab5a4609f31543a00a6511ecfcbb4a78a17e22a Gerrit-Change-Number: 1176501 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Handle delegation recalls for expired clients
by Rojin George (GerritHub) 06 Feb '24

06 Feb '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176498?usp=email ) Change subject: Handle delegation recalls for expired clients ...................................................................... Handle delegation recalls for expired clients During parallel reads & writes from multiple clients it was seen that delegation recalls were not progressing as indefinite times recalls were failing with recall in progress. This was happening as the client was expired while reserving lease and sd_state was never getting reset in this process. This CR handles this issue by setting the state_data.deleg.sd_state properly and also by wiping off the expired clients in such cases. Change-Id: Ia94573acdbd83a50fe34afacec0e8c1922ddeb97 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL_UP/fsal_up_top.c 1 file changed, 35 insertions(+), 19 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1176498/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176498?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia94573acdbd83a50fe34afacec0e8c1922ddeb97 Gerrit-Change-Number: 1176498 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: uid2grp: Fix usage of uid2grp cache
by Dipit Grover (GerritHub) 06 Feb '24

06 Feb '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176496?usp=email ) Change subject: uid2grp: Fix usage of uid2grp cache ...................................................................... uid2grp: Fix usage of uid2grp cache Change-Id: I6229a60c5ec01125211370b35a1ced4ae7a414fc Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/uid2grp.c 1 file changed, 40 insertions(+), 28 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/1176496/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176496?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6229a60c5ec01125211370b35a1ced4ae7a414fc Gerrit-Change-Number: 1176496 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0