April 2024 - Devel - NFS Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: nfs-krb5: Refactor gss auth setup
by Dipit Grover (GerritHub) 20 Apr '24

20 Apr '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193525?usp=email ) Change subject: nfs-krb5: Refactor gss auth setup ...................................................................... nfs-krb5: Refactor gss auth setup This CL refactors two things during server-init: 1. Extracts server-principal setup to a function 2. Moves ntirpc server gss-credentials setup to nfs_init Change-Id: Ief7745b71d29fa6d76b4949f049a89d7a87e5136 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c 2 files changed, 59 insertions(+), 63 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/25/1193525/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193525?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ief7745b71d29fa6d76b4949f049a89d7a87e5136 Gerrit-Change-Number: 1193525 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: Fix build warnings
by Dipit Grover (GerritHub) 20 Apr '24

20 Apr '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193524?usp=email ) Change subject: Fix build warnings ...................................................................... Fix build warnings Change-Id: Ief8d390e3340f41991a6eadd8b14ba204ab89d0f Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_init.c M src/RPCAL/gss_credcache.c 2 files changed, 12 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/1193524/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193524?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ief8d390e3340f41991a6eadd8b14ba204ab89d0f Gerrit-Change-Number: 1193524 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Release refcount on entry before restarting readdir
by Name of user not set (GerritHub) 20 Apr '24

20 Apr '24

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193523?usp=email ) Change subject: Release refcount on entry before restarting readdir ...................................................................... Release refcount on entry before restarting readdir When there is a readdir cache hit and a mdcache miss we create a new mdcache entry and take a refcount on it. By the time the mdcache entry is created if the readdir cache entry is invalidated by another thread then we don't free the ref taken on the created mdcache entry. We release the reference on the chunks and by consequence the dirents but that is not enough because dirents only have a reference to the entry in the readdir_cb code path. Change-Id: I07795289084ec6daadf34dfdbbf5aa6769600f89 Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/1193523/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I07795289084ec6daadf34dfdbbf5aa6769600f89 Gerrit-Change-Number: 1193523 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com

1 0

[S] Change in ...nfs-ganesha[next]: feat(lock): skip unlock from some FSAL on stale nfs4_clientid
by Zhitao Li (GerritHub) 20 Apr '24

20 Apr '24

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193517?usp=email ) Change subject: feat(lock): skip unlock from some FSAL on stale nfs4_clientid ...................................................................... feat(lock): skip unlock from some FSAL on stale nfs4_clientid Some FSAL persists enough information about lock. Itself can control whether to reclaim lock, not completely trusting NFS client. If VIP is detached, the FSAL expects lock record keep in the backend storage, which is used to check following reclaim. See https://github.com/nfs-ganesha/nfs-ganesha/issues/1108 Change-Id: Idb223b115fe846968644c86ddc7f9797fca32957 Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/FSAL/fsal_config.c M src/SAL/state_lock.c M src/include/fsal_types.h M src/libntirpc 4 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/1193517/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193517?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idb223b115fe846968644c86ddc7f9797fca32957 Gerrit-Change-Number: 1193517 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

Announce Push of V6-dev.10
by Frank Filz 19 Apr '24

19 Apr '24

Branch next Tag:V6-dev.10 NOTE: This merge includes an ntirpc pullup, please update your submodule. Merge Highlights * log_functions: Don't call Cleanup from Fatal handling function * update some logs to LogInfo in PUTFH and CREATE_SESSION * Revamp the handling of ACLs to match RFC 8881 * nfs4_clientid: log cred_flavor when printing the client record * IDMAPPER: allow enabling and disabling idmapper via SIGHUP config reload * Several callback fixes * CEPH: Free EXPORT { FSAL {} } config strings * export_mgr: Dont' leak refstr in get_gsh_export_by_pseudo_locked * FSAL: Fix up gsh_refstr references for op_context. * nfs4_Check_Stateid must not return NFS4ERR_STALE_STATEID for 4.1 * fix to remove unused function * xprt; lower logging to DEBUG * doc: fix cmount_path doc * Add new config parameter that controls the unique server_id * Require librgw 1.2.1 * Protect fd_usage_summarize_dbus with USE_DBUS Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: b47d9e904 Frank S. Filz V6-dev.10 7a3aea59e Daniel Gryniewicz Pull up ntirpc changes 0af6b43e2 Daniel Gryniewicz Protect fd_usage_summarize_dbus with USE_DBUS d13c1ee17 Daniel Gryniewicz Require librgw 1.2.1 aef7d361d Ofir Vaisnhtein Add new config parameter that controls the unique server_id 006243d23 Dhairya Parmar doc: fix cmount_path doc 332c75ead Sachin Punadikar FSAL_CEPH: Avoid duplicate refcounting of cmount bfcdd98b6 Chris Wedgwood xprt; lower logging to DEBUG 130b31338 Chris Wedgwood fix to remove unused function 0ae55ef74 Frank S. Filz FSAL: Fix up gsh_refstr references for op_context. 3f1bfaca7 Frank S. Filz nfs4_Check_Stateid must not return NFS4ERR_STALE_STATEID for 4.1 420841795 Frank S. Filz export_mgr: Dont' leak refstr in get_gsh_export_by_pseudo_locked 749c87ab5 Frank S. Filz CEPH: Free EXPORT { FSAL {} } config strings 99953754b Dipit Grover nfs-callback: Expose a function to set gss status for callback channel 781ce5bd3 Dipit Grover nfs-callback: Clear gss cache during callback-system shutdown 109bdcc45 Dipit Grover nfs-callback: fix callback system's shutdown function 932f12b9e Dipit Grover idmapping: Expose idmapping status as config ec06dbd21 Dipit Grover Idmapper: Expose a function to set idmapping status 202190aa1 Dipit Grover Idmapper: Protect owner-domain accesses using a rw-lock ef0246ba9 Dipit Grover nfs4_clientid: log cred_flavor when printing the client record 3f188bf5d Assaf Yaari commonlib: Skip redundant aces in mode_to_acl f4900ace2 Assaf Yaari commonlib: In fsal_mode_to_acl identify if can reuse aces eb30ebe38 Assaf Yaari commonlib: Place OWNER & GROUP mode generated aces at the beginning 98d1d9c74 Assaf Yaari commonlib: In fsal_mode_gen_acl the group perm should serve as mask d94ff21f1 Assaf Yaari access_check: In fsal_check_access_acl reset the FSAL_ACE4_REQ_FLAG from missing_access a7eb05e7a Assaf Yaari commonlib: In fsal_mode_to_acl don't dup inherit aces 8a78405a3 Assaf Yaari commonlib: Identify correctly special id's 808e128a7 Assaf Yaari commonlib: Remove GROUP_ID flag from special "who" eec7a96e4 Assaf Yaari commonlib: Add default flags for generated aces from mode-bits 55b69ead5 Assaf Yaari nfs_proto_tools: In encode_acl convert mode to acl if no acl present e2eab2a66 Assaf Yaari nfs4_acls: Free the acl object even if not found in the hashtable d9f0467fa Assaf Yaari commonlib: In fsal_mode_gen_acl create properly the generates acl object 9398d245f Assaf Yaari commonlib: Create properly ACL new entry when converting mode to ACL a1cea0484 Assaf Yaari commonlib: Re-write the implementation of fsal_acl_to_mode e951d2d57 Assaf Yaari fsal_mode_to_acl: Advance the dace pointer only when copying the source ace eac0a654c Assaf Yaari fsal.h: Don't unset the ATTR_ACL from valid_mask in case it was set by src d281357b7 Assaf Yaari nfs4_op_putfh: Update logs to info level on case of errors 46d302445 Assaf Yaari nfs4_op_create_session: Upgrade some debug logs to info aa653015b Assaf Yaari log_functions: Don't call Cleanup from Fatal handling function

1 0

Checkpatch - do folks have the commit hook installed
by Frank Filz 19 Apr '24

19 Apr '24

Hello all, I am noticing a lot of checkpatch warnings and errors. Are people running checkpatch? I know we are looking at changing to clang, but I expect to have the same 80 column limits and a few other things. Please use the checkpatch commit hook until we have switched over to clang. Thanks Frank

1 0

[M] Change in ...nfs-ganesha[next]: nfs-callback: Clear gss cache during callback-system shutdown
by Dipit Grover (GerritHub) 19 Apr '24

19 Apr '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193401?usp=email ) Change subject: nfs-callback: Clear gss cache during callback-system shutdown ...................................................................... nfs-callback: Clear gss cache during callback-system shutdown This commit adds a function to clear gss-cache for callback channel, and calls it during callback-system shutdown. Change-Id: I3c11e7e3f7163fe8fd957f6007d7dce08d808b61 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_rpc_callback.c M src/RPCAL/gss_credcache.c M src/include/gss_credcache.h 3 files changed, 110 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1193401/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193401?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3c11e7e3f7163fe8fd957f6007d7dce08d808b61 Gerrit-Change-Number: 1193401 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: nfs-callback: Expose a function to set gss status for callback channel
by Dipit Grover (GerritHub) 19 Apr '24

19 Apr '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193402?usp=email ) Change subject: nfs-callback: Expose a function to set gss status for callback channel ...................................................................... nfs-callback: Expose a function to set gss status for callback channel Change-Id: I0e749610fdcf0c91cd0639a8888b2c61d57e464e Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_rpc_callback.c M src/include/nfs_rpc_callback.h 2 files changed, 71 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1193402/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0e749610fdcf0c91cd0639a8888b2c61d57e464e Gerrit-Change-Number: 1193402 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfs-callback: fix callback system's shutdown function
by Dipit Grover (GerritHub) 19 Apr '24

19 Apr '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193400?usp=email ) Change subject: nfs-callback: fix callback system's shutdown function ...................................................................... nfs-callback: fix callback system's shutdown function Change-Id: I4b8af9393e1df3f05f12d63fc99047ae1900e2dd Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/1193400/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193400?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4b8af9393e1df3f05f12d63fc99047ae1900e2dd Gerrit-Change-Number: 1193400 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: idmapping: Expose idmapping status as config
by Dipit Grover (GerritHub) 19 Apr '24

19 Apr '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193399?usp=email ) Change subject: idmapping: Expose idmapping status as config ...................................................................... idmapping: Expose idmapping status as config This CL introduces the idmapping_status as a flag within DIRECTORY_SERVICES config section. The flag is used to set the global idmapping status, during initialisation and config reload. This allows dynamic enabling/disabling of idmapping in Ganesha. Change-Id: I2ea376d6cc925c79c23b14609534d05db596b58e Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_init.c M src/config_samples/config.txt M src/config_samples/gpfs.ganesha.main.conf M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 6 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/1193399/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1193399?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2ea376d6cc925c79c23b14609534d05db596b58e Gerrit-Change-Number: 1193399 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0