April 2024 - Devel - Nfs Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: nfs4_acls: Free the acl object even if not found in the hashtable

by Assaf Yaari (GerritHub)

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190105?usp=email ) Change subject: nfs4_acls: Free the acl object even if not found in the hashtable ...................................................................... nfs4_acls: Free the acl object even if not found in the hashtable Can happen when allocated directly w/o using nfs4_acl_new_entry. Signed-off-by: Assaf Yaari <assafy(a)google.com> Change-Id: I890dafb58c4e238fa1e78c7540dbe8f2362ad848 --- M src/support/nfs4_acls.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/1190105/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I890dafb58c4e238fa1e78c7540dbe8f2362ad848 Gerrit-Change-Number: 1190105 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 month, 2 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: commonlib: Create properly ACL new entry when converting mode to ACL

by Assaf Yaari (GerritHub)

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190103?usp=email ) Change subject: commonlib: Create properly ACL new entry when converting mode to ACL ...................................................................... commonlib: Create properly ACL new entry when converting mode to ACL Previously the allocation of the ACL bypassed the call to nfs4_acl_new_entry which may lead into memory leak when calling nfs4_acl_release_entry. Signed-off-by: Assaf Yaari <assafy(a)google.com> Change-Id: I76c46e414f45e2f091e01c6ea782bd1c91415a04 --- M src/FSAL/commonlib.c 1 file changed, 14 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/1190103/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I76c46e414f45e2f091e01c6ea782bd1c91415a04 Gerrit-Change-Number: 1190103 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 month, 2 weeks

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: commonlib: Re-write the implementation of fsal_acl_to_mode

by Assaf Yaari (GerritHub)

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190102?usp=email ) Change subject: commonlib: Re-write the implementation of fsal_acl_to_mode ...................................................................... commonlib: Re-write the implementation of fsal_acl_to_mode Re-write according to RFC 8881 section 6.3.2 Prev implementation was wrong and was not consistent with fsal_mode_to_acl. Signed-off-by: Assaf Yaari <assafy(a)google.com> Change-Id: Id9c9c56c4fca6f6813ee2b1fb636238ed048f90d --- M src/FSAL/commonlib.c 1 file changed, 45 insertions(+), 31 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1190102/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id9c9c56c4fca6f6813ee2b1fb636238ed048f90d Gerrit-Change-Number: 1190102 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 month, 2 weeks

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: fsal_mode_to_acl: Advance the dace pointer only when copying the sour...

by Assaf Yaari (GerritHub)

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190101?usp=email ) Change subject: fsal_mode_to_acl: Advance the dace pointer only when copying the source ace ...................................................................... fsal_mode_to_acl: Advance the dace pointer only when copying the source ace Previously the pointer advanced also when jumping over generated ACE which led into memory corruption. Signed-off-by: Assaf Yaari <assafy(a)google.com> Change-Id: If787c0e632227605f7f4e4a71f7698a40a36a053 --- M src/FSAL/commonlib.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1190101/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If787c0e632227605f7f4e4a71f7698a40a36a053 Gerrit-Change-Number: 1190101 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 month, 2 weeks

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: fsal.h: Don't unset the ATTR_ACL from valid_mask in case it was set b...

by Assaf Yaari (GerritHub)

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190100?usp=email ) Change subject: fsal.h: Don't unset the ATTR_ACL from valid_mask in case it was set by src ...................................................................... fsal.h: Don't unset the ATTR_ACL from valid_mask in case it was set by src In fsal_copy_attrs, it might be that the source attrs as was returned by the FSAL, can indicate that the ACL info is valid but the acl field points to NULL when there are no ACL entries stored in the BE. We don't want in this case (which I believe is the common case) to allocate new fsal_acl_data_t and call nfs4_acl_new_entry just for marking zero entries. The unset to the flag caused Ganesha to return malformed response to GETATTR that contained the ACL mask. Note that encode_acl do support the case where args->attrs->acl is NULL. Signed-off-by: Assaf Yaari <assafy(a)google.com> Change-Id: I2c901d2f65c5e632c60dd2c5fcd25a98fe519c69 --- M src/include/fsal.h 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/1190100/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2c901d2f65c5e632c60dd2c5fcd25a98fe519c69 Gerrit-Change-Number: 1190100 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 month, 2 weeks

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: nfs4_op_putfh: Update logs to warn level on case of errors

by Assaf Yaari (GerritHub)

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190099?usp=email ) Change subject: nfs4_op_putfh: Update logs to warn level on case of errors ...................................................................... nfs4_op_putfh: Update logs to warn level on case of errors Signed-off-by: Assaf Yaari <assafy(a)google.com> Change-Id: I9c2298ee649eb76eb4f265f8a3a2e7fa72b43d53 --- M src/Protocols/NFS/nfs4_op_putfh.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/1190099/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190099?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9c2298ee649eb76eb4f265f8a3a2e7fa72b43d53 Gerrit-Change-Number: 1190099 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 month, 2 weeks

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: nfs4_op_create_session: Upgrade some debug logs to info

by Assaf Yaari (GerritHub)

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190098?usp=email ) Change subject: nfs4_op_create_session: Upgrade some debug logs to info ...................................................................... nfs4_op_create_session: Upgrade some debug logs to info Log in info level when a client creates a new session. This in order to help identify cases were clients are moved from one node to another. Signed-off-by: Assaf Yaari <assafy(a)google.com> Change-Id: I127a0aadfc4af1f1f0732a9214fe7a5b2d852a8f --- M src/Protocols/NFS/nfs4_op_create_session.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1190098/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I127a0aadfc4af1f1f0732a9214fe7a5b2d852a8f Gerrit-Change-Number: 1190098 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 month, 2 weeks

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel April 2024