January 2025 - Devel - NFS Ganesha List Archives

[XL] Change in ...nfs-ganesha[next]: QOS Implementation for IO bandwidth control and Quota in NFS.
by Name of user not set (GerritHub) 10 Jan '25

10 Jan '25

deeraj.patil(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206998?usp=email ) Change subject: QOS Implementation for IO bandwidth control and Quota in NFS. ...................................................................... QOS Implementation for IO bandwidth control and Quota in NFS. Two types of approaches are there for bandwidth control: SYNC and ASYNC. Sync Control : Per-Share, Per-Client ASYNC Control : Per-Share, Per-Client, PerShare-PerClient Combined. Quota Implemenataion i.e (Network Data Consumtion limit over a period of larger time). Per-Share level, Per-Client level, or can PerShare-PerClient level. Limit values for Bandwidth and Quota can be controlled indvidually for Write and Read or can becombined together. Implemented by naresh.chillarege(a)ibm.com and deeraj.patil(a)ibm.com Change-Id: I7b6b7fa4801033f3397a30ff57fe662687c6cd3c Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com> --- M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_main.c A src/MainNFSD/nfs_qos.c M src/Protocols/NFS/nfs4_op_destroy_session.c M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_write.c M src/include/client_mgr.h M src/include/export_mgr.h M src/include/log_common.h A src/include/nfs_qos.h A src/include/nfs_qosmgr.h M src/log/log_functions.c M src/support/client_mgr.c A src/support/nfs_qosmgr.c 14 files changed, 2,949 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1206998/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7b6b7fa4801033f3397a30ff57fe662687c6cd3c Gerrit-Change-Number: 1206998 Gerrit-PatchSet: 1 Gerrit-Owner: deeraj.patil(a)ibm.com

1 0

[M] Change in ...nfs-ganesha[next]: Config changes required for QOS and base infra.
by Name of user not set (GerritHub) 10 Jan '25

10 Jan '25

deeraj.patil(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206997?usp=email ) Change subject: Config changes required for QOS and base infra. ...................................................................... Config changes required for QOS and base infra. Change-Id: I2c5e13ca03d44ccbda9595c6fb6010ab5b4b0470 Signed-off-by: Naresh Chillarege <naresh.chillarege(a)ibm.com> Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com> --- M src/MainNFSD/CMakeLists.txt M src/include/gsh_config.h M src/support/exports.c M src/support/nfs_read_conf.c 4 files changed, 176 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1206997/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206997?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2c5e13ca03d44ccbda9595c6fb6010ab5b4b0470 Gerrit-Change-Number: 1206997 Gerrit-PatchSet: 1 Gerrit-Owner: deeraj.patil(a)ibm.com

1 0

[M] Change in ...nfs-ganesha[next]: Signed-off-by: Shivam Singh <shivam.singh9@ibm.com>
by Shivam Singh (GerritHub) 10 Jan '25

10 Jan '25

Shivam Singh has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206982?usp=email ) Change subject: Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> ...................................................................... Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> Takeover functionality fix for rados_ng Crash of ganesha server when takeover using TAKE_IP is triggered because of null pointer error fixed here. Added new terminal flag (-V) to provide virtual ip from terminal when starting ganesha and creating rados object corresponding to the vip. Change-Id: I172680123b39e295f559b93fedec63787f3f179e Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> --- M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_main.c M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_rados_ng.c M src/include/fsal.h 6 files changed, 83 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/1206982/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I172680123b39e295f559b93fedec63787f3f179e Gerrit-Change-Number: 1206982 Gerrit-PatchSet: 1 Gerrit-Owner: Shivam Singh <shivam.singh9(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Add "take_IP" functionality for rados_ng recovery
by Sachin Punadikar (GerritHub) 09 Jan '25

09 Jan '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206930?usp=email ) Change subject: Add "take_IP" functionality for rados_ng recovery ...................................................................... Add "take_IP" functionality for rados_ng recovery The TAKE_IP functionality is not present for rados_ng recovery database. With TAKE_IP functionality, Ganesha will enter into the grace and help recover the NFSv4 clients connected to the IP. Change-Id: I416853fd05f21976ad11f30861cf59da617d9543 Signed-off-by: Sachin Punadikar <Sachin.Punadikar(a)ibm.com> --- M src/SAL/recovery/recovery_rados_ng.c 1 file changed, 34 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/1206930/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I416853fd05f21976ad11f30861cf59da617d9543 Gerrit-Change-Number: 1206930 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: set pnfs_ds pointer to NULL to avoid multiple repeated pnfs_ds_put th...
by yinlei (GerritHub) 09 Jan '25

09 Jan '25

yinlei has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206916?usp=email ) Change subject: set pnfs_ds pointer to NULL to avoid multiple repeated pnfs_ds_put that may cause a SIGSEGV error. ...................................................................... set pnfs_ds pointer to NULL to avoid multiple repeated pnfs_ds_put that may cause a SIGSEGV error. Change-Id: I88b590f208db91f189519defd651fd52fdb91c06 Signed-off-by: yinlei <yinlei2(a)lenovo.com> --- M src/FSAL/commonlib.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/1206916/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206916?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I88b590f208db91f189519defd651fd52fdb91c06 Gerrit-Change-Number: 1206916 Gerrit-PatchSet: 1 Gerrit-Owner: yinlei <yinlei2(a)lenovo.com>

1 0

V6.5 released...
by Frank Filz 08 Jan '25

08 Jan '25

Oops, wrong subject. From: Frank Filz [mailto:ffilzlnx@mindspring.com] Sent: Wednesday, January 8, 2025 4:31 PM To: devel(a)lists.nfs-ganesha.org; support(a)lists.nfs-ganesha.org Subject: [NFS-Ganesha-Devel] Branch next AND V6-stable Tag:V6.5 Note: V6-stable branch is also created with this push. Merge Highlights This merge does provide some small "features" with new config options, however, the defaults result in no change in behavior. Again, these patches are accepted to work with Google to closer match their internal repos. There is a new option to enable/disable sticky grace that defaults to disable, returning Ganesha to earlier grace period behavior. Without the support from the recovery backend, sticky grace could cause problems warranting disabling it by default. Some new Prometheus metrics are added. * SAL/sal_metrics.c: Added SAL static metrics. * nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry * FSAL/FSAL_CEPH/handle.c: Moved tracepoint to reduce indentation * Resolve compilation warnings * common_utils: Added additional documentation to doc strings * do not crash when ref count is greater than 1 * Implement log rotation/compress for Ganesha * Fix the issue where the nfs4_op_write function always returns 0. * Sticky Grace Configurable option: * nfs_metrics.c: Fix code style issues * nfs_main.c: Use dup2 to simplify function calls * add root_kerberos_principal param * add read_access_check_policy param Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> > Contents: 952fb9337 Frank S. Filz V6.5 649d62698 Roy Babayov add read_access_check_policy param 41b1e7e97 Roy Babayov add root_kerberos_principal param 79cc98e80 bjfhdhhaha nfs_main.c: Use dup2 to simplify function calls e8a3da149 izxl007 nfs_metrics.c: Fix code style issues a410572cc VidyaThumukunta Sticky Grace Configurable option: ae99e2eb2 yinlei Fix the issue where the nfs4_op_write function always returns 0. b6e5fb110 Prabhu Murugesan Implement log rotation/compress for Ganesha 5c2b80569 Ofir Vainshtein do not crash when ref count is greater than 1 0cff86b0b Lior Suliman common_utils: Added additional documentation to doc strings d48c2d258 Lior Suliman Resolve compilation warnings 18ddf224e Lior Suliman FSAL/FSAL_CEPH/handle.c: Moved tracepoint to reduce indentation 723dcac5b Shahar Hochma nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry 86e6b29c3 Yoni Couriel SAL/sal_metrics.c: Added SAL static metrics.

1 0

Branch next AND V6-stable
by Frank Filz 08 Jan '25

08 Jan '25

Tag:V6.5 Note: V6-stable branch is also created with this push. Merge Highlights This merge does provide some small "features" with new config options, however, the defaults result in no change in behavior. Again, these patches are accepted to work with Google to closer match their internal repos. There is a new option to enable/disable sticky grace that defaults to disable, returning Ganesha to earlier grace period behavior. Without the support from the recovery backend, sticky grace could cause problems warranting disabling it by default. Some new Prometheus metrics are added. * SAL/sal_metrics.c: Added SAL static metrics. * nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry * FSAL/FSAL_CEPH/handle.c: Moved tracepoint to reduce indentation * Resolve compilation warnings * common_utils: Added additional documentation to doc strings * do not crash when ref count is greater than 1 * Implement log rotation/compress for Ganesha * Fix the issue where the nfs4_op_write function always returns 0. * Sticky Grace Configurable option: * nfs_metrics.c: Fix code style issues * nfs_main.c: Use dup2 to simplify function calls * add root_kerberos_principal param * add read_access_check_policy param Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 952fb9337 Frank S. Filz V6.5 649d62698 Roy Babayov add read_access_check_policy param 41b1e7e97 Roy Babayov add root_kerberos_principal param 79cc98e80 bjfhdhhaha nfs_main.c: Use dup2 to simplify function calls e8a3da149 izxl007 nfs_metrics.c: Fix code style issues a410572cc VidyaThumukunta Sticky Grace Configurable option: ae99e2eb2 yinlei Fix the issue where the nfs4_op_write function always returns 0. b6e5fb110 Prabhu Murugesan Implement log rotation/compress for Ganesha 5c2b80569 Ofir Vainshtein do not crash when ref count is greater than 1 0cff86b0b Lior Suliman common_utils: Added additional documentation to doc strings d48c2d258 Lior Suliman Resolve compilation warnings 18ddf224e Lior Suliman FSAL/FSAL_CEPH/handle.c: Moved tracepoint to reduce indentation 723dcac5b Shahar Hochma nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry 86e6b29c3 Yoni Couriel SAL/sal_metrics.c: Added SAL static metrics.

1 0

[M] Change in ...nfs-ganesha[next]: add read_access_check_policy param
by Name of user not set (GerritHub) 08 Jan '25

08 Jan '25

roybabayov(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206911?usp=email ) Change subject: add read_access_check_policy param ...................................................................... add read_access_check_policy param Control when to run permission check for read. The default value is "pre" to maintain the existing behavior. This allows to optimize performance for failure flow by always checking access before sending the read, or to optimize performance for success path by storing access check result in the FSAL cache during the read and perform the access check after the read (requires the FSAL implementation to support it, so should only be used with supported FSALs). It also allow to optimize for security by running permission check both before and after. Change-Id: I67d78d10bed31ba37089a45f9d250ce587a17016 Signed-off-by: Roy Babayov <roybabayov(a)google.com> --- M src/Protocols/NFS/nfs4_op_read.c M src/doc/man/ganesha-export-config.rst M src/include/export_mgr.h M src/include/nfs_exports.h M src/support/exports.c 5 files changed, 85 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/1206911/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206911?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I67d78d10bed31ba37089a45f9d250ce587a17016 Gerrit-Change-Number: 1206911 Gerrit-PatchSet: 1 Gerrit-Owner: roybabayov(a)gmail.com

1 0

[M] Change in ...nfs-ganesha[next]: add root_kerberos_principal param
by Name of user not set (GerritHub) 08 Jan '25

08 Jan '25

roybabayov(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206910?usp=email ) Change subject: add root_kerberos_principal param ...................................................................... add root_kerberos_principal param Add root_kerberos_principal under directory_services_param to control which hosts users/service name parts of the principal should be assigned root privilege. The default value is all (currently nfs,root,host) to keep the existing behavior by default. This config will allow to opt out of setting root privilege to specific principals when server consider it a security issue. Change-Id: Ie174efd9004d62754122244a9d82ddc254b9b68e Signed-off-by: Roy Babayov <roybabayov(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 81 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/1206910/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie174efd9004d62754122244a9d82ddc254b9b68e Gerrit-Change-Number: 1206910 Gerrit-PatchSet: 1 Gerrit-Owner: roybabayov(a)gmail.com

1 0

[XS] Change in ...nfs-ganesha[next]: nfs_metrics.c: Fix code style issues
by Zheng Zeng (GerritHub) 01 Jan '25

01 Jan '25

Zheng Zeng has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206553?usp=email ) Change subject: nfs_metrics.c: Fix code style issues ...................................................................... nfs_metrics.c: Fix code style issues Change-Id: Ia97eb8b56d80dd780cdbb2972e927f181ee08111 Signed-off-by: izxl007 <zengzheng007(a)163.com> --- M src/MainNFSD/nfs_metrics.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/1206553/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206553?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia97eb8b56d80dd780cdbb2972e927f181ee08111 Gerrit-Change-Number: 1206553 Gerrit-PatchSet: 1 Gerrit-Owner: Zheng Zeng <zengzheng007(a)163.com>

1 0