January 2025 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: fix(nfs3): add nfs_RetryableError() in nfs3_getattr and nfs3_commit
by Zhitao Li (GerritHub) 23 Jan '25

23 Jan '25

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207660?usp=email ) Change subject: fix(nfs3): add nfs_RetryableError() in nfs3_getattr and nfs3_commit ...................................................................... fix(nfs3): add nfs_RetryableError() in nfs3_getattr and nfs3_commit Change-Id: I3fbe3cf10dd5b6b203356f5118a79131d930e56d Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/Protocols/NFS/nfs3_commit.c M src/Protocols/NFS/nfs3_getattr.c 2 files changed, 23 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/1207660/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207660?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3fbe3cf10dd5b6b203356f5118a79131d930e56d Gerrit-Change-Number: 1207660 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

Announce Push of V7-dev.1
by Frank Filz 21 Jan '25

21 Jan '25

Branch next Tag:V7-dev.1 Merge Highlights * set pnfs_ds pointer to NULL to avoid multiple repeated pnfs_ds_put that may cause a SIGSEGV error. * nfs4_op_open.c: retry_open_file open upgrade bad perms to fsal_reopen2 * Add HA ProxyProtocol config option * idmapper/idmapper.c: Removed a redundant call * Add register and deregister connection callbacks to the connection manager * Adding xattr support to FSAL_VFS * Recovery backend updates to support rados failover Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 66596c940 Frank S. Filz V7-dev.1 5402e6795 Xueqian Hu Support for Preserve_Unlinked 8526caa8e Sachin Punadikar Add failover functionality for rados_ng recovery 439cfc18f Sachin Punadikar SAL: Error handling for recovery backend init 1814cfd81 Shivam Singh [TEMPORARY] Code change for enabling takeover for rados_cluster module 7c726fbfb Shivam Singh Associated vip with rados recovery object in recovery_rados_ng 9df0a384d Fritz Elfert Adding xattr support to FSAL_VFS db4b9f9b2 Idan Eldar Add register and deregister connection callbacks to the connection manager 69da0b4ce Lior Suliman idmapper/idmapper.c: Removed a redundant call 293c1ae5e Idan Eldar Add HA ProxyProtocol config option 931ff3cc3 Jason Woodward nfs4_op_open.c: retry_open_file open upgrade bad perms to fsal_reopen2 59f735385 yinlei set pnfs_ds pointer to NULL to avoid multiple repeated pnfs_ds_put that may cause a SIGSEGV error.

2 1

[S] Change in ...nfs-ganesha[next]: SAL:Support nodeid config param for rados_ng backend
by Sachin Punadikar (GerritHub) 21 Jan '25

21 Jan '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207554?usp=email ) Change subject: SAL:Support nodeid config param for rados_ng backend ...................................................................... SAL:Support nodeid config param for rados_ng backend For failover capabilities, nodeid is used. Added support for "nodeid" as config option for "rados_ng" recovery backend. Change-Id: Ic4dfee193523e574b088e38ed643d427de1dd4dc Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/MainNFSD/nfs_init.c M src/SAL/recovery/recovery_rados.h M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c 4 files changed, 25 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1207554/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207554?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic4dfee193523e574b088e38ed643d427de1dd4dc Gerrit-Change-Number: 1207554 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfs4_op_open.c: retry_open_file open upgrade bad perms to fsal_reopen2
by Jason Woodward (GerritHub) 16 Jan '25

16 Jan '25

Jason Woodward has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207356?usp=email ) Change subject: nfs4_op_open.c: retry_open_file open upgrade bad perms to fsal_reopen2 ...................................................................... nfs4_op_open.c: retry_open_file open upgrade bad perms to fsal_reopen2 Git clones are failing due to a reopen issue distilled down to: ```sh exec 7<>reopentest; chmod 0444 reopentest; echo data >&7; exec 8<reopentest ; exec 8>&- ; exec 7>&- ; rm reopentest ``` Since we now pass check_open_permission flag as true to fsal_reopen2 the openflags |'d with old openflags is no longer correct: Prior: ``` nfs-ganesha-19882[svc_9] open4_ex :STATE :F_DBG :Calling reopen2 nfs-ganesha-19882[svc_9] mdcache_getattrs :RW LOCK :F_DBG :Got read lock on 0xffff5c0042d0 (&entry->attr_lock) at ./FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:995 nfs-ganesha-19882[svc_9] mdcache_getattrs :RW LOCK :F_DBG :Unlocked 0xffff5c0042d0 (&entry->attr_lock) at ./FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1043 nfs-ganesha-19882[svc_9] mdcache_getattrs :MDCACHE :F_DBG :attrs obj attributes Request Mask=00000680 Valid Mask=0011dfce Supported Mask=0091dfce REGULAR_FILE numlinks=0x1 size=0x0 mode=0444 owner=0xfffffffe group=0xfffffffe atime=09/01/2025 22:39:33 mtime=09/01/2025 22:39:33 nfs-ganesha-19882[svc_9] fsal_check_access_no_acl :NFS4 ACL :F_DBG :file Mode=0444, file uid=4294967294, file gid= 4294967294, user uid=4294967294, user gid= 4294967294, access_type=0X6000000 nfs-ganesha-19882[svc_9] fsal_check_access_no_acl :NFS4 ACL :F_DBG :Using owner mode 0400 nfs-ganesha-19882[svc_9] fsal_check_access_no_acl :NFS4 ACL :F_DBG :Mask=0X4000000, Access Type=0X6000000 Allowed=0X4000000 Denied=0X2000000 DENIED nfs-ganesha-19882[svc_9] check_open_permission :FSAL :DEBUG :test_access got Permission denied nfs-ganesha-19882[svc_9] fsal_reopen2 :FSAL :DEBUG :Not re-opening file fsal_access failed with WRITE_ACCESS - Permission denied ``` After: ``` nfs-ganesha-21242[svc_6] open4_ex :STATE :F_DBG :Calling reopen2 nfs-ganesha-21242[svc_6] mdcache_getattrs :RW LOCK :F_DBG :Got read lock on 0xffff6c00b100 (&entry->attr_lock) at ./FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:995 nfs-ganesha-21242[svc_6] mdcache_getattrs :RW LOCK :F_DBG :Unlocked 0xffff6c00b100 (&entry->attr_lock) at ./FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1043 nfs-ganesha-21242[svc_6] mdcache_getattrs :MDCACHE :F_DBG :attrs obj attributes Request Mask=00000680 Valid Mask=0011dfce Supported Mask=0091dfce REGULAR_FILE numlinks=0x1 size=0x5 mode=0444 owner=0xfffffffe group=0xfffffffe atime=10/01/2025 18:56:23 mtime=10/01/2025 18:56:23 nfs-ganesha-21242[svc_6] fsal_check_access_no_acl :NFS4 ACL :F_DBG :file Mode=0444, file uid=4294967294, file gid= 4294967294, user uid=4294967294, user gid= 4294967294, access_type=0X4000000 nfs-ganesha-21242[svc_6] fsal_check_access_no_acl :NFS4 ACL :F_DBG :Using owner mode 0400 nfs-ganesha-21242[svc_6] fsal_check_access_no_acl :NFS4 ACL :F_DBG :Mask=0X4000000, Access Type=0X4000000 Allowed=0X4000000 Denied=0X0 ALLOWED ``` Change-Id: I9b58f56a2983eebe8482b16e47fd786b96b93b13 Signed-off-by: Jason Woodward <jawoodwa(a)microsoft.com> --- M src/Protocols/NFS/nfs4_op_open.c 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/1207356/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207356?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9b58f56a2983eebe8482b16e47fd786b96b93b13 Gerrit-Change-Number: 1207356 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Woodward <jawoodwa(a)microsoft.com>

1 0

[XS] Change in ...nfs-ganesha[next]: idmapper/idmapper.c: Removed a redundant call
by Lior Suliman (GerritHub) 16 Jan '25

16 Jan '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207305?usp=email to review the following change. Change subject: idmapper/idmapper.c: Removed a redundant call ...................................................................... idmapper/idmapper.c: Removed a redundant call To idmapper_set_owner_domain from idmapper_init. idmapper_init is called from init_server_pkgs. init_server_pkgs calls set_idmapping_status right after it calls to idmapper_init and set_idmapping_status is calling idmapper_set_owner_domain. So that's a redundant call. Change-Id: I1e16e9c0cb7cbcf71bfbcde361a36fa41a868eb2 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/idmapper.c 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/1207305/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207305?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1e16e9c0cb7cbcf71bfbcde361a36fa41a868eb2 Gerrit-Change-Number: 1207305 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[M] Change in ...nfs-ganesha[next]: [TEMPORARY] Code change for enabling takeover for rados_cluster module
by Shivam Singh (GerritHub) 16 Jan '25

16 Jan '25

Shivam Singh has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207298?usp=email ) Change subject: [TEMPORARY] Code change for enabling takeover for rados_cluster module ...................................................................... [TEMPORARY] Code change for enabling takeover for rados_cluster module NOT TO BE MERGED: The changes include the scenario of gsp not being null for recovery in rados cluster. In that case if a node in a cluster can takeover a server with given ip or nodeid which may not be part of cluster. Change-Id: I8f35c30c69a2e295641508e4ec6f69eab428606b Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> --- M src/SAL/recovery/recovery_rados_cluster.c 1 file changed, 61 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1207298/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207298?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8f35c30c69a2e295641508e4ec6f69eab428606b Gerrit-Change-Number: 1207298 Gerrit-PatchSet: 1 Gerrit-Owner: Shivam Singh <shivam.singh9(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Ganesha Preserve_Unlinked support useful tools
by Xueqian Hu (GerritHub) 15 Jan '25

15 Jan '25

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207277?usp=email ) Change subject: Ganesha Preserve_Unlinked support useful tools ...................................................................... Ganesha Preserve_Unlinked support useful tools Useful tools might help FSALs to support preserve_unlinked: 1. Helper functions to check if a file to unlink has states. 2. If a file get deleted while still in open, set is_unlink_with_states in op_ctx to notify underly FSAL. 3. Mark the last close of a file. Change-Id: Ib104a78ca8dd763ed0ff85a40883861e41bf7ced Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/FSAL/fsal_helper.c M src/SAL/nfs4_state.c M src/include/fsal.h M src/include/fsal_api.h 4 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/1207277/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib104a78ca8dd763ed0ff85a40883861e41bf7ced Gerrit-Change-Number: 1207277 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[S] Change in ...nfs-ganesha[next]: Support for Preserve_Unlinked
by Xueqian Hu (GerritHub) 15 Jan '25

15 Jan '25

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207276?usp=email ) Change subject: Support for Preserve_Unlinked ...................................................................... Support for Preserve_Unlinked 1. V4 conf param to enable/disable Preserve_Unlinked. 2. New type in fsal_fsinfo_options_t to check a FSAL's support. 3. OPEN with OPEN4_RESULT_PRESERVE_UNLINKED when supported. Change-Id: Id763d50be454e646431bc0e38450132e685ff2ca Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/FSAL/fsal_config.c M src/Protocols/NFS/nfs4_op_open.c M src/doc/man/ganesha-core-config.rst M src/include/fsal_types.h M src/include/gsh_config.h M src/support/nfs_read_conf.c 6 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1207276/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207276?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id763d50be454e646431bc0e38450132e685ff2ca Gerrit-Change-Number: 1207276 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[L] Change in ...nfs-ganesha[next]: Add register and deregister connection callbacks to the connection ma...
by Idan Eldar (GerritHub) 15 Jan '25

15 Jan '25

Idan Eldar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207220?usp=email ) Change subject: Add register and deregister connection callbacks to the connection manager ...................................................................... Add register and deregister connection callbacks to the connection manager By using these callbacks Ganesha can notify the FSAL when connections start and end. That way a FSAL can optimize "DRAIN" requests for misbehaving clients. Adjusted "drain_and_disconnect" callback to reduce the number of RPC requests sent to the FSAL. Change-Id: Ic65b87eff4d2873803cd96b6cccf240aa5ace2f0 Signed-off-by: Idan Eldar <idaneldar(a)google.com> --- M src/RPCAL/connection_manager.c M src/include/connection_manager.h 2 files changed, 251 insertions(+), 82 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/20/1207220/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207220?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic65b87eff4d2873803cd96b6cccf240aa5ace2f0 Gerrit-Change-Number: 1207220 Gerrit-PatchSet: 1 Gerrit-Owner: Idan Eldar <idaneldar(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: SAL: Error handling for recovery backend init
by Sachin Punadikar (GerritHub) 13 Jan '25

13 Jan '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207084?usp=email ) Change subject: SAL: Error handling for recovery backend init ...................................................................... SAL: Error handling for recovery backend init NFS Ganesha supports different types of recovery backend. Need to handle error paths with proper return code and appropriate messages. Change-Id: I0abbe1f7838464fd1fe48575cf68dd4b360551f6 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c M src/SAL/recovery/recovery_fs_ng.c M src/SAL/recovery/recovery_rados_cluster.c M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c 6 files changed, 51 insertions(+), 29 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/1207084/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1207084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0abbe1f7838464fd1fe48575cf68dd4b360551f6 Gerrit-Change-Number: 1207084 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0