4:39 a.m.
raprasad(a)redhat.com has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1213847?usp=email )
Change subject: Coverity Issue - 542648
......................................................................
Coverity Issue - 542648
Fix to avoid the INTEGER_OVERFLOW issue.
The variable new_count is a signed integer, which can potentially
cause an INTEGER_OVERFLOW problem when used with gsh_realloc() or
while updating an unsigned integer variable (acldata.naces) with
its value. The function posix_acl_2_fsal_acl() may return -1,
which gets assigned to both new_count and new_i_count.
This scenario can lead to an INTEGER_OVERFLOW issue.
Change-Id: I7a4e5bec06776b9c443c6851caaedf8b1a8e61a4
Signed-off-by: Rajesh Prasad <raprasad(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/internal.c
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/1213847/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1213847?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I7a4e5bec06776b9c443c6851caaedf8b1a8e61a4
Gerrit-Change-Number: 1213847
Gerrit-PatchSet: 1
Gerrit-Owner: raprasad(a)redhat.com