Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542002 ) Change subject: config: Reverse sense of result from block check() method ...................................................................... config: Reverse sense of result from block check() method Logically, a check() function should return true on success. However, this one returns true on failure. check_export_duplicate() is currently the only instance of check(), so swap the meaning of the result before a confusing anti-pattern is established. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com&gt; Change-Id: If82672e7e1498a08843ee51a7ae21d81f960b996 --- M src/config_parsing/config_parsing.c M src/support/exports.c 2 files changed, 23 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/542002/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542002 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If82672e7e1498a08843ee51a7ae21d81f960b996 Gerrit-Change-Number: 542002 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net&gt; Gerrit-MessageType: newchange