Kaleb KEITHLEY has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455256
Change subject: pnfs: fix coverity use-after-free in pnfs_ds_remove()
......................................................................
pnfs: fix coverity use-after-free in pnfs_ds_remove()
error:
https://download.nfs-ganesha.org/coverity/kaleb1/1/145ds.c.html#error
before:
https://download.nfs-ganesha.org/coverity/2019-05-18-86de5d67/
after:
https://download.nfs-ganesha.org/coverity/kaleb2/
All calls to pnfs_ds_remove() pass final=true and `pnfs_ds_put(pds)`
here will free pds. It also calls fsal_pnfs_ds_fini() already, so
the drop from FSAL comment and logic seems to be erroneous.
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
Change-Id: I6e4046419ecc6737e296a267faf734ab8e8d5a8b
---
M src/include/pnfs_utils.h
M src/support/ds.c
M src/support/export_mgr.c
M src/support/exports.c
4 files changed, 6 insertions(+), 13 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/455256/1
--
To view, visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455256
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I6e4046419ecc6737e296a267faf734ab8e8d5a8b
Gerrit-Change-Number: 455256
Gerrit-PatchSet: 1
Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>
Gerrit-MessageType: newchange