shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222249?usp=email ) Change subject: Fix notify_granted_completion for NFSv4.1 ...................................................................... Fix notify_granted_completion for NFSv4.1 This fixes an issue introduced in: https://github.com/nfs-ganesha/nfs-ganesha/commit/1cfef0bde73e0dca0a347df... The patch changed it so up channel slot release is only called for NFSv4.1, but it used the clientid under the channel. In NFSv4.1 the clientid is not initialized in the channel. The channel keeps a union between the clientid (for NFSv4.0) and the session (for nfsv4.1). So, in NFSv4.1, the check looked at garbage, which means that in some cases the slot was never released. We change the check to look at the channel type, which is always initialized. Change-Id: I9565b148cfdd6a8d1e663e7d12f0d2705294899b Signed-off-by: Shahar Hochma <shaharhoch(a)google.com&gt; --- M src/Protocols/NFS/nfs4_op_lock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1222249/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9565b148cfdd6a8d1e663e7d12f0d2705294899b Gerrit-Change-Number: 1222249 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com