Martin Schwenke has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1171108?usp=email )
Change subject: FSAL: Fix some issues with resolving POSIX filesystems
......................................................................
FSAL: Fix some issues with resolving POSIX filesystems
Commit 6e18be9236b952fd1dbba80b4ef6819e3f2f9a2d accidentally
introduced a 1 second delay per export.
If stat() returns 0 then the initial loop iteration continues, causing
at least one call to nanosleep(). Instead, the loop should break on
success.
Why 1 second? Arguments to CONF_ITEM_UI32() should look like:
CONF_ITEM_UI32(_name_, _min_, _max_, _def_, _struct_, _mem_)
That is the 3rd argument should be the maximum and the 4th should be
the default. These currently appear to be in the wrong order, since
the default is not within the range. This is actually lucky because
with a timeout of 100ms we probably wouldn't have noticed the first
problem. ;-)
Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com>
Change-Id: If5e0ca60485a2e5f13d03fa5e2a3050ef6697eab
---
M src/FSAL/localfs.c
M src/support/nfs_read_conf.c
2 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/1171108/1
--
To view, visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1171108?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: If5e0ca60485a2e5f13d03fa5e2a3050ef6697eab
Gerrit-Change-Number: 1171108
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>
Gerrit-MessageType: newchange