Kaleb KEITHLEY has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/465799 )
Change subject: python: run setup.py for gpfs-epoch(.py) to fix its shebang
......................................................................
python: run setup.py for gpfs-epoch(.py) to fix its shebang
`setup.py build ...` modifies the shebang appropriately for the
platform, i.e. using the python (e.g. /usr/bin/python3) that setup.py
was invoked with.
This might seem like a heavyweight solution for one file, but it's
ostensibly better than some other solution like sed editing the shebang
in an rpmbuild scriptlet. This way you get (almost) the right thing in
a regular cmake/make/make-install build. Almost, because the `setup.py
install ...` step installs gpfs-epoch in /usr/bin instead of where we
infer it's wanted, in /usr/libexec, based on the install scriptlets in
the rpm .spec file.
I contemplated changing the --prefix for the `setup.py install ...` step
but then that scribbles other things in /usr/libexec or /usr/local/libexec
I also contemplated putting gpfs-epoch(.py) in its own subdir, e.g.,
.../src/scripts/gpfs-epoch/... or .../src/FSAL/FSAL_GPFS/gpfs-epoch/...
and could be convinced to do that.
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
Change-Id: I5ff746393b7bac53c9f12c9d33f0b0aeb24cd5ce
---
M src/nfs-ganesha.spec-in.cmake
M src/scripts/CMakeLists.txt
M src/scripts/ganeshactl/CMakeLists.txt
R src/scripts/gpfs-epoch.py
A src/scripts/setup.py.in
5 files changed, 80 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/465799/1
--
To view, visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/465799
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I5ff746393b7bac53c9f12c9d33f0b0aeb24cd5ce
Gerrit-Change-Number: 465799
Gerrit-PatchSet: 1
Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>
Gerrit-MessageType: newchange