Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190154?usp=email ) Change subject: commonlib: In fsal_mode_gen_acl the group perm should serve as mask ...................................................................... commonlib: In fsal_mode_gen_acl the group perm should serve as mask According to RFC 8881, section 6.4.1.1: The ACL attributes SHOULD also be modified such that: 1. If MODE4_RGRP is not set, entities explicitly listed in the ACL other than OWNER@ and EVERYONE@ SHOULD NOT be granted ACE4_READ_DATA. 2. If MODE4_WGRP is not set, entities explicitly listed in the ACL other than OWNER@ and EVERYONE@ SHOULD NOT be granted ACE4_WRITE_DATA or ACE4_APPEND_DATA. 3. If MODE4_XGRP is not set, entities explicitly listed in the ACL other than OWNER@ and EVERYONE@ SHOULD NOT be granted ACE4_EXECUTE. Signed-off-by: Assaf Yaari <assafy(a)google.com&gt; Change-Id: I2e999440612cded5ed2e361c9e44973bee987c0f --- M src/FSAL/commonlib.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1190154/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1190154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2e999440612cded5ed2e361c9e44973bee987c0f Gerrit-Change-Number: 1190154 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com&gt;