January 2020 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: RADOS_URLS: restore rados_urls watch on new configuration
by Denis Kondratenko (GerritHub) 24 Jan '20

24 Jan '20

Denis Kondratenko has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482693 ) Change subject: RADOS_URLS: restore rados_urls watch on new configuration ...................................................................... RADOS_URLS: restore rados_urls watch on new configuration After commit 0fea990 there is new USE_RADOS_URLS macro that is not defined and thus watch is never set on new changes in rados config. There is also need to call lib instead of direct function call. Change-Id: I1d289f8005dbe2e0b32fcf9ccbac29b32ed18edc Signed-off-by: Denis Kondratenko <denis.kondratenko(a)suse.com> --- M src/MainNFSD/nfs_admin_thread.c M src/MainNFSD/nfs_init.c 2 files changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/482693/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482693 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1d289f8005dbe2e0b32fcf9ccbac29b32ed18edc Gerrit-Change-Number: 482693 Gerrit-PatchSet: 1 Gerrit-Owner: Denis Kondratenko <denis.kondratenko(a)suse.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_CEPH - Always use the large handle size
by Daniel Gryniewicz (GerritHub) 22 Jan '20

22 Jan '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482439 ) Change subject: FSAL_CEPH - Always use the large handle size ...................................................................... FSAL_CEPH - Always use the large handle size Since we check the chk_fscid field to see if it's needed, it has to be in the wire handle to check. Always include it in the handle; it will just be zero if it's unused. Change-Id: If83e0479413b7a640c6a66ec85ae40296b3f1c72 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/handle.c 2 files changed, 3 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/482439/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482439 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If83e0479413b7a640c6a66ec85ae40296b3f1c72 Gerrit-Change-Number: 482439 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Validate fs_len in NFSv3 file handle.
by Malahal (GerritHub) 22 Jan '20

22 Jan '20

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482431 ) Change subject: Validate fs_len in NFSv3 file handle. ...................................................................... Validate fs_len in NFSv3 file handle. NFSv3 file handle length should be at least the NFSv3 Ganesha header plus the file system opaque handle length. Change-Id: Ie1bc7bfc44b4ca8f6a17c7f5c3f464b741d0012d Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/support/nfs_filehandle_mgmt.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/482431/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482431 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie1bc7bfc44b4ca8f6a17c7f5c3f464b741d0012d Gerrit-Change-Number: 482431 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix seg fault when NFSv4 compound op fails for regular files.
by Ashish Sangwan (GerritHub) 21 Jan '20

21 Jan '20

Ashish Sangwan has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482240 ) Change subject: Fix seg fault when NFSv4 compound op fails for regular files. ...................................................................... Fix seg fault when NFSv4 compound op fails for regular files. We are hitting this seg-fault on our system: 3 0x00007f2837583f2d in mdcache_handle_to_key (obj_hdl=0x7f281f01a638, fh_desc=0x7f281def8b70) at /usr/src/debug/nfs-ganesha-2.8.3/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1377 4 0x00007f28374dea77 in state_obj_value_hash_func (hparam=0x7f2831838000, key=0x7f281defb500) at /usr/src/debug/nfs-ganesha-2.8.3/SAL/nfs4_state_id.c:369 5 0x00007f28374a2f51 in compute (ht=0x7f2831838000, key=0x7f281defb500, index=0x7f281defac54, rbt_hash=0x7f281defac40) at /usr/src/debug/nfs-ganesha-2.8.3/hashtable/hashtable.c:253 6 0x00007f28374a39b0 in hashtable_getlatch (ht=0x7f2831838000, key=0x7f281defb500, val=0x7f281defb4e0, may_write=true, latch=0x7f281defb4c0) at /usr/src/debug/nfs-ganesha-2.8.3/hashtable/hashtable.c:490 7 0x00007f28374df971 in nfs4_State_Del (state=0x7f281f04b480) at /usr/src/debug/nfs-ganesha-2.8.3/SAL/nfs4_state_id.c:759 8 0x00007f28374d9363 in _state_del_locked (state=0x7f281f04b480, func=0x7f28375d7ee0 <__func__.20139> "state_nfs4_state_wipe", line=669) at /usr/src/debug/nfs-ganesha-2.8.3/SAL/nfs4_state.c:351 9 0x00007f28374db4ac in state_nfs4_state_wipe (ostate=0x7f281f01a890) at /usr/src/debug/nfs-ganesha-2.8.3/SAL/nfs4_state.c:669 10 0x00007f28374cf045 in state_wipe_file (obj=0x7f281f01a638) at /usr/src/debug/nfs-ganesha-2.8.3/SAL/state_misc.c:1323 11 0x00007f28375a247c in _mdcache_lru_unref (entry=0x7f281f01a600, flags=0, func=0x7f28375fb8ef <__func__.23337> "mdcache_put", line=199) at /usr/src/debug/nfs-ganesha-2.8.3/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:2017 12 0x00007f283757f363 in mdcache_put (entry=0x7f281f01a600) at /usr/src/debug/nfs-ganesha-2.8.3/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h:199 13 0x00007f28375842e0 in mdcache_put_ref (obj_hdl=0x7f281f01a638) at /usr/src/debug/nfs-ganesha-2.8.3/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1540 14 0x00007f283752e6cc in set_current_entry (data=0x7f2818c4e300, obj=0x0) at /usr/src/debug/nfs-ganesha-2.8.3/include/nfs_proto_data.h:392 15 0x00007f2837530838 in compound_data_Free (data=0x7f2818c4e300) at /usr/src/debug/nfs-ganesha-2.8.3/Protocols/NFS/nfs4_Compound.c:1451 16 0x00007f2837530584 in nfs4_Compound (arg=0x7f2818c23028, req=0x7f2818c22800, res=0x7f2818c4e1c0) at /usr/src/debug/nfs-ganesha-2.8.3/Protocols/NFS/nfs4_Compound.c:1362 17 0x00007f28374576c2 in nfs_rpc_process_request (reqdata=0x7f2818c22800) at /usr/src/debug/nfs-ganesha-2.8.3/MainNFSD/nfs_worker_thread.c:1986 (gdb) f 3 1377 subcall( (gdb) p op_ctx->ctx_export $2 = (struct gsh_export *) 0x0 (gdb) f 11 2017 state_wipe_file(&entry->obj_handle); (gdb) p entry->lru $1 = {q = {next = 0x7f2837854aa0 <LRU+3424>, prev = 0x7f2837854aa0 <LRU+3424>}, qid = LRU_ENTRY_CLEANUP, refcnt = 2, flags = 3, lane = 15, cf = 0} The current compound op being executed is setattr which fails with ERR_FSAL_STALE because the file is deleted. When we get ERR_FSAL_STALE in setattr we call mdcache_kill_entry which moves the mdcache entry to cleanup lane and when we try to delete the state as part of cleanup, we hit this crash. All the ops which are calling mdcache_kill_entry on receiving error for regular files could hit this crash. We should not reset ctx_export until the compond data is freed. Signed-off-by: ashish.sangwan <ashishsangwan2(a)gmail.com> Change-Id: I3859e6e4599233c67d7640711e05cc5ab8647a3e --- M src/Protocols/NFS/nfs4_Compound.c 1 file changed, 11 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/482240/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/482240 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3859e6e4599233c67d7640711e05cc5ab8647a3e Gerrit-Change-Number: 482240 Gerrit-PatchSet: 1 Gerrit-Owner: Ashish Sangwan <ashishsangwan2(a)gmail.com> Gerrit-MessageType: newchange

1 0

Default KRB Principal name with new rpc.gssd
by Pushpesh Sharma 18 Jan '20

18 Jan '20

Hi All, Any pointers are appreciated.. -pushpesh From: Pushpesh Sharma <pushpeshs(a)vmware.com> Sent: Thursday, January 16, 2020 7:45 PM To: devel(a)lists.nfs-ganesha.org Subject: [NFS-Ganesha-Devel] Default KRB Principal name with new rpc.gssd Hi All, We are trying to use ganehsa with KRB. On NFS client centos7.5 we are joining Active Directory based using sssd(AD based KRB Realm). For root user we are getting krb ticket using kinit and valid AD user. Client principal while joining domain using sssd a default principal of shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM> is always generated. gss.rpcd by default send this principal as principal user name to ganesha server. Client do have other principal like nfs/client_fdqn(a)REALM.COM<mailto:nfs/client_fdqn@REALM.COM>. But as per rpc.gssd documentation<mailto:rpc.gssd%20documentation> as well first choice would be shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM>. Due to this server always recognize root user as someone else i.e. shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM>. We do see in src/idmapper/idmapper.c<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co…> handling for mapping three principal patterns nfs/* , root/*, host/* to uid=0, gid=0. So this left shorthostname$(a)REALM.COM<mailto:horthostname$@REALM.COM> principal not being recognized as root. We are of the opinion that doing a small fix in above idmapper code to add this pattern as well can fix this issue. But we wanted to know any security concern around it? Or if the client behavior can be change in any way, so we don't need this fix? If we try removing this shorthostname$(a)REALM.COM<mailto:shorthostname$@REALM.COM> principal after domain join, sssd cannot be re-loaded and complains about not finding this principal. Thanks -pushpesh

1 0

Limits to logging
by clay＠cs.georgetown.edu 17 Jan '20

17 Jan '20

Hi, I am working on an academic research project using nfs-ganesha. I am trying to do some debugging and believe that logging messages are going missing. For example, I am trying to trace when writes occur in FSAL/FSAL_VFS/file.c:vfs_write2.c. I put a four logging messages in using LogDebug, and only one that shows entry into the function gets logged - the others which surround the write and show function exiting do not appear in the log. I have put some code in that writes my own trace messages to a file so I can see that these other log messages should also be appearing as the flow of control passes through them, but they are not written. Is there some throttling mechanism that I am running into? Or something else that I might need to be aware of? Thanks

4 3

Announce Push of V4-dev.2
by Frank Filz 17 Jan '20

17 Jan '20

Branch next Tag:V4-dev.2 Merge Highlights * Initialize the client node for comparison * main - Fix leaks in main() * IDMapper - clean up cache on shutdown * Fix nfs3_readdirplus error return * nfs_prereq_init initialize enqueued_reqs twice, the latter should be * Fix use of dupreqs with DUPREQ_DELETED state * Remove unused DUPREQ_DELETED and timestamp * DNS related stats are added to ganesha_stats auth command Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 57a94c7 Frank S. Filz V4-dev.2 0eae232 Trishali Nayar DNS related stats are added to ganesha_stats auth command db7d10f Malahal Naineni Remove unused DUPREQ_DELETED and timestamp ccdcaea Malahal Naineni Fix use of dupreqs with DUPREQ_DELETED state 40eb8e8 Bingyin Zhang nfs_prereq_init initialize enqueued_reqs twice, the latter should be dequeued_reqs; 5f85ac3 Wei Qiaomiao Fix nfs3_readdirplus error return 2835ef2 Daniel Gryniewicz IDMapper - clean up cache on shutdown f7fd566 Daniel Gryniewicz main - Fix leaks in main() fe7bab4 Daniel Gryniewicz Initialize the client node for comparison

1 0

Change in ...nfs-ganesha[next]: nfs_prereq_init initialize enqueued_reqs twice, the latter should be ...
by Name of user not set (GerritHub) 16 Jan '20

16 Jan '20

zhbingyin(a)sina.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481914 ) Change subject: nfs_prereq_init initialize enqueued_reqs twice, the latter should be dequeued_reqs; ...................................................................... nfs_prereq_init initialize enqueued_reqs twice, the latter should be dequeued_reqs; Change-Id: Icd796d00b460c03887acc19e75cf606dd7b3e050 Signed-off-by: Bingyin Zhang <zhbingyin(a)sina.com> --- M src/MainNFSD/nfs_init.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/481914/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481914 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icd796d00b460c03887acc19e75cf606dd7b3e050 Gerrit-Change-Number: 481914 Gerrit-PatchSet: 1 Gerrit-Owner: zhbingyin(a)sina.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: IDMapper - clean up cache on shutdown
by Daniel Gryniewicz (GerritHub) 16 Jan '20

16 Jan '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481896 ) Change subject: IDMapper - clean up cache on shutdown ...................................................................... IDMapper - clean up cache on shutdown Change-Id: I9f96fe6c60f2ebcdf679c4b5053f980d92346607 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/idmapper/idmapper.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/481896/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481896 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9f96fe6c60f2ebcdf679c4b5053f980d92346607 Gerrit-Change-Number: 481896 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: main - Fix leaks in main()
by Daniel Gryniewicz (GerritHub) 16 Jan '20

16 Jan '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481895 ) Change subject: main - Fix leaks in main() ...................................................................... main - Fix leaks in main() Change-Id: I704a14c65f93b102f45cd077b639095f0fa8096e Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/481895/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/481895 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I704a14c65f93b102f45cd077b639095f0fa8096e Gerrit-Change-Number: 481895 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0