April 2026 - Devel - NFS Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: Fix getgrouplist return value handling for NSS and SSSD
by Lior Suliman (GerritHub) 30 Apr '26

30 Apr '26

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236495?usp=email to review the following change. Change subject: Fix getgrouplist return value handling for NSS and SSSD ...................................................................... Fix getgrouplist return value handling for NSS and SSSD The issue: getgrouplist() (NSS) and sss_nss_getgrouplist_timeout() (SSSD) have different return value semantics: - NSS: returns -1 on buffer too small, or >=0 (number of groups) on success - SSSD: returns 0 on success, ERANGE on buffer too small, or errno on error This caused problems because SSSD's positive errno values (ERANGE=34, ETIMEDOUT=110) overlap with NSS's success values (number of groups). Solution: Normalize return values in pwnam_wrappers__getgrouplist(): - NSS: Convert >=0 (success) to 0 - SSSD: Convert ERANGE (buffer too small) to -1 - Result: -1 (retry), 0 (success), >0 (error) Update my_getgrouplist_alloc() to handle normalized values: - ret == -1 and errno ERANGE: Buffer too small, retry with correct size - ret == -1: Failure - ret >= 0: Success, continue Change-Id: I1ef2944172054e5051305049fe33192724ea7e51 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/pwnam_wrappers.c M src/idmapper/sss_nss_idmap.c M src/support/uid2grp.c 3 files changed, 72 insertions(+), 28 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1236495/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236495?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1ef2944172054e5051305049fe33192724ea7e51 Gerrit-Change-Number: 1236495 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: log: Add a compile time assert for default_log_levels
by Lior Suliman (GerritHub) 30 Apr '26

30 Apr '26

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236482?usp=email to review the following change. Change subject: log: Add a compile time assert for default_log_levels ...................................................................... log: Add a compile time assert for default_log_levels Change-Id: I3d4c34b5f16805efe5abe9936d81a74c3f77a179 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/log/log_functions.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/1236482/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236482?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3d4c34b5f16805efe5abe9936d81a74c3f77a179 Gerrit-Change-Number: 1236482 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix python install problem, see https://github.com/nfs-ganesha/nfs-ga...
by Christoph Martin (GerritHub) 28 Apr '26

28 Apr '26

Christoph Martin has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236380?usp=email ) Change subject: Fix python install problem, see https://github.com/nfs-ganesha/nfs-ganesha/pull/1393 ...................................................................... Fix python install problem, see https://github.com/nfs-ganesha/nfs-ganesha/pull/1393 Change-Id: Ibeb52b4a32651213dde4b11adabdb4d0cb9b8c4d Signed-off-by: Christoph Martin <martin(a)uni-mainz.de> --- M src/scripts/ganesha-top/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/1236380/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236380?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibeb52b4a32651213dde4b11adabdb4d0cb9b8c4d Gerrit-Change-Number: 1236380 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Martin <martin(a)uni-mainz.de>

1 0

[M] Change in ...nfs-ganesha[next]: Merge branch 'next' of https://github.com/nfs-ganesha/nfs-ganesha int...
by Christoph Martin (GerritHub) 28 Apr '26

28 Apr '26

Christoph Martin has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236379?usp=email ) Change subject: Merge branch 'next' of https://github.com/nfs-ganesha/nfs-ganesha into next ...................................................................... Merge branch 'next' of https://github.com/nfs-ganesha/nfs-ganesha into next Change-Id: Id5988d2acacd87625089a0f32d19f140e72507ab Signed-off-by: Christoph Martin <martin(a)uni-mainz.de> --- 1 file changed, 80 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/1236379/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id5988d2acacd87625089a0f32d19f140e72507ab Gerrit-Change-Number: 1236379 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Martin <martin(a)uni-mainz.de>

1 0

[M] Change in ...nfs-ganesha[next]: Add FullDebug logging for delegation deny decisions
by Suhas Athani (GerritHub) 28 Apr '26

28 Apr '26

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236370?usp=email ) Change subject: Add FullDebug logging for delegation deny decisions ...................................................................... Add FullDebug logging for delegation deny decisions Add LogFullDebug instrumentation to should_we_grant_deleg() for paths where delegation is not granted. Add LogFullDebug instrumentation to deleg_supported() for unsupported delegation checks (global config, object type, FSAL capability, and export permission checks). Keep existing decision logic unchanged; logs were added only to improve observability/troubleshooting. Change-Id: I9f2ba2401be8a3d73faa66a7c86e7084a28e032e Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/SAL/state_deleg.c 1 file changed, 60 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/1236370/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236370?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9f2ba2401be8a3d73faa66a7c86e7084a28e032e Gerrit-Change-Number: 1236370 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Recovery: Handle zero clients condition in grace
by Sachin Punadikar (GerritHub) 27 Apr '26

27 Apr '26

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236326?usp=email ) Change subject: Recovery: Handle zero clients condition in grace ...................................................................... Recovery: Handle zero clients condition in grace In a clustered grace setup, there are chances that a Ganesha having 0 clients connected may come out of grace immediately and other Ganesha which has started grace will fail to detect that other Ganesha has enforced grace. Need to handle this situation and stop the Ganesha from quickly ending grace period. Change-Id: I9f255edad99d322e819621f7ecd8a304fcd46968 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/SAL/nfs4_recovery.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1236326/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236326?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9f255edad99d322e819621f7ecd8a304fcd46968 Gerrit-Change-Number: 1236326 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

Announce Push of V9.13
by Frank Filz 24 Apr '26

24 Apr '26

Branch next Tag:V9.13 Merge Highlights * Add a rolling log index to Ganesha logs. * SAL: Add "none" recovery backend * log: enforce full coverage of log components at compile time * FSAL: Use Filesystem_Id in NFS file handles * MDCACHE: Skip stale directory entry * VFS: Skip dangling directory entries during readdir * Code alignment, cosmetic changes. * RECOVERY: Handle errors while updating grace object * removed ARGS from EXECUTE_PROCESS command for _GIT_DESCRIBE * Enhance header files to support both C and C++ compilation Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 30c392cd9 Frank S. Filz V9.13 966184978 Sreedhar Agraharam Enhance header files to support both C and C++ compilation fbb426575 Yogendra Charya Tangalapally removed ARGS from EXECUTE_PROCESS command for _GIT_DESCRIBE 32335399f Sachin Punadikar RECOVERY: Handle errors while updating grace object 4682c1cec Deeraj.Patil Code alignment, cosmetic changes. 5a75aeccf Martin Schwenke VFS: Skip dangling directory entries during readdir f8529c03f Peter Schwenke MDCACHE: Skip stale directory entry ca933622f Peter Schwenke FSAL: Use Filesystem_Id in NFS file handles 63ccdbd5f Lior Suliman log: enforce full coverage of log components at compile time 02dcf884d Lior Suliman SAL: Add "none" recovery backend 3327ac533 Ofir Vainshtein Add a rolling log index to Ganesha logs.

1 0

[M] Change in ...nfs-ganesha[next]: Code alignment, cosmetic changes.
by Name of user not set (GerritHub) 23 Apr '26

23 Apr '26

deeraj.patil(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236180?usp=email ) Change subject: Code alignment, cosmetic changes. ...................................................................... Code alignment, cosmetic changes. Change-Id: I797d006e020cf250ed36a99012a950c817d41c00 Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com> --- M src/include/nfs_exports.h M src/support/exports.c 2 files changed, 55 insertions(+), 58 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/1236180/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I797d006e020cf250ed36a99012a950c817d41c00 Gerrit-Change-Number: 1236180 Gerrit-PatchSet: 1 Gerrit-Owner: deeraj.patil(a)ibm.com

1 0

[XS] Change in ...nfs-ganesha[next]: removed ARGS from EXECUTE_PROCESS
by Name of user not set (GerritHub) 23 Apr '26

23 Apr '26

Yogendra.Tangalapally(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236150?usp=email ) Change subject: removed ARGS from EXECUTE_PROCESS ...................................................................... removed ARGS from EXECUTE_PROCESS When moved from EXEC_PROGRAM to EXECUTE_PROCESS, ARGS was not removed which resulting in ARGS instead of actual ganesha version in _GIT_DESCRIBE test-31# ganesha_mgr show version | grep Describe Git Describe = ARGS Change-Id: I040b31772f7f08214c3c371f1bb14286826d994e Signed-off-by: Yogendra Charya Tangalapally <Yogendra.Tangalapally(a)ibm.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1236150/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I040b31772f7f08214c3c371f1bb14286826d994e Gerrit-Change-Number: 1236150 Gerrit-PatchSet: 1 Gerrit-Owner: Yogendra.Tangalapally(a)ibm.com

1 0

[S] Change in ...nfs-ganesha[next]: RECOVERY: Handle errors while updating grace object
by Sachin Punadikar (GerritHub) 22 Apr '26

22 Apr '26

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236115?usp=email ) Change subject: RECOVERY: Handle errors while updating grace object ...................................................................... RECOVERY: Handle errors while updating grace object In a clustered grace setup, grace state and epoch values of current and recovery are stored in rados object. Added error handling when such write is failing. Aditionally added debug message after grace object is modified with updated values of current and recovery epoch. Change-Id: I4c1c3c44923f0c5b15cbd3803f9ab85c682753c4 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/SAL/recovery/recovery_rados_cluster.c M src/support/rados_grace.c 2 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1236115/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236115?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4c1c3c44923f0c5b15cbd3803f9ab85c682753c4 Gerrit-Change-Number: 1236115 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0