July 2024 - Devel - Nfs Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Do not unlock obj_lock twice, that leads to undefined behavior.

by David Rieber (GerritHub)

David Rieber has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198233?usp=email ) Change subject: Do not unlock obj_lock twice, that leads to undefined behavior. ...................................................................... Do not unlock obj_lock twice, that leads to undefined behavior. If check_share_conflict ever returns ERR_FSAL_SHARE_DENIED obj_lock ends up getting unlocked twice: first inside check_share_conflict_and_update_locked, and then again inside fsal_start_global_io right after check_share_conflict_and_update_locked returns. Change-Id: Iac0413514232edaf9fb86aa12a1623186eb51e72 Signed-off-by: David Rieber <drieber(a)google.com> --- M src/FSAL/commonlib.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/1198233/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198233?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iac0413514232edaf9fb86aa12a1623186eb51e72 Gerrit-Change-Number: 1198233 Gerrit-PatchSet: 1 Gerrit-Owner: David Rieber <drieber(a)google.com>

2 months, 3 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Limit the number of files we delegate

by Name of user not set (GerritHub)

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198218?usp=email ) Change subject: Limit the number of files we delegate ...................................................................... Limit the number of files we delegate Today each delegation state places a refcnt on a mdcache entry.Ganesha can therefore only release this mdcache entry - when this delegation state is destroyed. A delegation state can only be destroyed when, (1) Client id expires (2) Some other client tries to do write style operations on the file (3) Client voluntarily returns the delegation So if you have a scenario where active clients are mostly reading a bunch of files from the server - today we have to wait on the client to voluntarily return the delegation before we can release the corresponding mdcache entry. Typically linux clients (this was tested using some flavor of centos7) return delegations on unused files within seconds to minutes. But what was seen was that even if the application on the client side is continuosly stating a file we donot return the delegation. When this is done at scale we end up with OOMs on the server because the mdcache entries corresponding to the delegated files cannot be released. One could argue that we should instead do a delegation recall as part of the mdcache reaper or some other reaper - which can be helpful but that still puts the server in the good grace of the clients. Therefore would like to introduce a limit on the number of files we delegate - which can be helpful in tuning the server memory usage in scenarios like above. Tested this change with pynfs based tests that get delegations on a bunch of files and never return it Change-Id: I092e47cec176dcbb191c28b98e8fa897304ba173 Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/SAL/state_deleg.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1198218/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I092e47cec176dcbb191c28b98e8fa897304ba173 Gerrit-Change-Number: 1198218 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com

2 months, 3 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Skip Delegation Recall Async task, if the client_id goes stale

by Rojin George (GerritHub)

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198188?usp=email ) Change subject: Skip Delegation Recall Async task, if the client_id goes stale ...................................................................... Skip Delegation Recall Async task, if the client_id goes stale Change-Id: Ib3849f8346226ea3bdde92bd994f7455fc1024d6 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL_UP/fsal_up_top.c M src/SAL/nfs4_owner.c 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/1198188/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib3849f8346226ea3bdde92bd994f7455fc1024d6 Gerrit-Change-Number: 1198188 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

2 months, 4 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: STATE: fix a refcount leak and a couple minor cleanups

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198166?usp=email ) Change subject: STATE: fix a refcount leak and a couple minor cleanups ...................................................................... STATE: fix a refcount leak and a couple minor cleanups Change-Id: I7611d6cef839846c6f8f0306c7e046cd2228cd2b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_op_lock.c M src/SAL/nfs4_state.c M src/SAL/nfs4_state_id.c 3 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/1198166/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7611d6cef839846c6f8f0306c7e046cd2228cd2b Gerrit-Change-Number: 1198166 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

3 months

1
0
0 / 0

Announce Push of V6-dev.17

by Frank Filz

Branch next Tag:V6-dev.17 NOTE: This merge includes and ntirpc pullup, please update your submodule Merge Highlights * zero copy * RDMA revamp Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 8520ce672 Frank S. Filz V6-dev.17 f0c63504e Rojin George Add validation to Server stats to get latest info 21a775714 Rojin George NFSoRDMA: Update RPC_Max_RDMA_Connections to 64 00df1a252 Rojin George NFSoRDMA: Set default rdma credits to 64 6e17c6b30 Rojin George NFSoRDMA: Skip svc_rqst_evchan_reg for RDMA Event Channel ba9e99a5d Rojin George NFSoRDMA: NFSv3 ReadDir/ReadDirPlus Ops to get buffers from RDMA registered memory 9ca769c53 Rojin George NFSoRDMA: RDMA Tunable for RPC_Max_RDMA_Connections 053a15eef Rojin George NFSoRDMA: RDMA Tunables for sq_depth, rq_depth and credits 16ff25ce1 Rojin George NFSoRDMA: Restrict NFS Over RDMA mounts to NFS_RDMA_Protocol_Versions configured af35ed788 Rojin George NFSoRDMA: Update xp_dispatch.rendezvous_cb for RDMA 90eeca9bd Rojin George NFSoRDMA: Make Port of NFS Over RDMA Tunable d245a863e Rojin George NFSoRDMA: NFSv4 ReadDir Op to get buffers from RDMA registered memory b5ff25550 Rojin George NFSoRDMA: NFSv4 Read Op to get buffers from RDMA registered memory 029a25499 Rojin George NFSoRDMA: Enable NFS Over RDMA support in Ganesha 49f275c57 Rojin George NFSoRDMA: API to get the buffer to fill the IO Payloads 30f365351 Frank S. Filz ntirpc pullup 07f4eede9 Frank S. Filz CEPH: Enable zero copy also allow run time config of async and zero copy f4fb682e8 Frank S. Filz CEPH: cmake bits for detecting zero copy support and revert 4cbf7d603 48e5220b2 Frank S. Filz Make read path use iovec all the way through 02197b4e0 Frank S. Filz FSAL: Add infrastructure so read2 implementation can allocate own buffers 46e012d13 Frank S. Filz Make write path use iovec all the way through 3e335a5b2 Frank S. Filz Make iov in fsal_io_arg a pointer a9b493c7f Frank S. Filz Add generalized xdr for iovec to putbufs and fillbufs e44fdaf08 Frank S. Filz CEPH: Make client_oc configurable from Ganesha config - default false aafb9f3e4 Frank S. Filz Use NFS_REQUEST ONLY for actual NFS requests cdb0eb325 Frank S. Filz GPFS: Handle iovec with multiple buffers in read and write

3 months

1
0
0 / 0

Gothib changes

by Frank Filz

At the suggestion of a contributor, I just closed down access to edit the wiki to those with permission to push. If you would like to contribute to the wiki, please let me know and I will grant your github ID the appropriate permissions. While setting that up, I notice that there is a "Discussions" feature that provides a place for discussions separate from issues. I have gone ahead and enabled that, please consider using it if you are initiating a more extensive discussion that is worthy of being archived within the github project. See a "welcome" discussion here: https://github.com/nfs-ganesha/nfs-ganesha/discussions/1154 I'm not sure how it all works yet. Thanks Frank Filz

3 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix so_refcount leak

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197990?usp=email ) Change subject: Fix so_refcount leak ...................................................................... Fix so_refcount leak Release the reference held for the state owner. Change-Id: I5934184e22cf18ebe6fa0c57bf720e2d5a17e6c2 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL_UP/fsal_up_top.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/1197990/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5934184e22cf18ebe6fa0c57bf720e2d5a17e6c2 Gerrit-Change-Number: 1197990 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

3 months

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Convert cih_lock to mutext. Its mostly used ad rwlock, so convert to ...

by Gaurav (GerritHub)

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197963?usp=email ) Change subject: Convert cih_lock to mutext. Its mostly used ad rwlock, so convert to mutex. ...................................................................... Convert cih_lock to mutext. Its mostly used ad rwlock, so convert to mutex. Change-Id: I07c0e902581cfafa35c0ee0ce46a95b6ecdca2cf Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)nutanix.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1197963/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197963?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I07c0e902581cfafa35c0ee0ce46a95b6ecdca2cf Gerrit-Change-Number: 1197963 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com>

3 months

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Convert mdc_exp_lock to mutex. mdc_clean_entry uses this lock as rwlo...

by Gaurav (GerritHub)

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197962?usp=email ) Change subject: Convert mdc_exp_lock to mutex. mdc_clean_entry uses this lock as rwlock, so better to convert it mutex. Other places where its used ad rdlock are rare like mdcache_unexport/umount. ...................................................................... Convert mdc_exp_lock to mutex. mdc_clean_entry uses this lock as rwlock, so better to convert it mutex. Other places where its used ad rdlock are rare like mdcache_unexport/umount. Change-Id: If0e72705c1a068394191ba0178457def03ee459b Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)nutanix.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c 4 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/62/1197962/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197962?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If0e72705c1a068394191ba0178457def03ee459b Gerrit-Change-Number: 1197962 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com>

3 months

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: PROXYV3: Set KEEPALIVE and RCVTIMEO for connection between proxy & host

by Xueqian Hu (GerritHub)

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197945?usp=email ) Change subject: PROXYV3: Set KEEPALIVE and RCVTIMEO for connection between proxy & host ...................................................................... PROXYV3: Set KEEPALIVE and RCVTIMEO for connection between proxy & host One interesting observation is that the read() function in proxyv3_call will get blocked if the proxy IP becomes unavailable. In some distributed design use cases, this can be more problematic because the proxy IP could be moved from one node to another (causing the socket to become unavailable, but the read() function will continue to block). It would be helpful to monitor the socket using SO_KEEPALIVE and also set a timeout using SO_RCVTIMEO. Change-Id: Ia3a8182062b0808099e3f97f69c09557d678b538 Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/FSAL/FSAL_PROXY_V3/rpc.c 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/1197945/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197945?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia3a8182062b0808099e3f97f69c09557d678b538 Gerrit-Change-Number: 1197945 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel July 2024