November 2025 - Devel - Nfs Ganesha List Archives

by Frank Filz

Branch next Tag:V9.2 Merge Highlights * Get rid of confusing cmp_sockaddr and rename sockaddr_cmpf to sockaddr_cmp * Add NFSv4 parameter to disable NFSv4 blocking locks support * Check mutex ops in set_idmapping_status (Coverity CID 542634) * Fix buffer overruns in ip_utils.c (Coverity CIDs 638312, 638296) * CEPH: Fix file handle leak Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: e35369068 Frank S. Filz V9.2 a26e2c33d Sachin Punadikar CEPH: Fix file handle leak 68697d296 Suhas Athani Fix buffer overruns in ip_utils.c (Coverity CIDs 638312, 638296) 6bd061661 Suhas Athani Check mutex ops in set_idmapping_status (Coverity CID 542634) cc580b574 xueqian.hu Add NFSv4 parameter to disable NFSv4 blocking locks support 69ac3770c Frank S. Filz Get rid of confusing cmp_sockaddr and rename sockaddr_cmpf to sockaddr_cmp

10 hours, 55 minutes

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: Make FSAL readlink use utf8string instead of gsh_buffdesc and elimina...

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226855?usp=email ) Change subject: Make FSAL readlink use utf8string instead of gsh_buffdesc and eliminate gsh_strldup ...................................................................... Make FSAL readlink use utf8string instead of gsh_buffdesc and eliminate gsh_strldup gsh_strldup was used in several places to make copies of a string in either a gsh_buffdesc or a utf8string which use different types for the length. Also the length in gsh_buffdesc is the length of the buffer so it is string length +1. The length was not being consistently set. Changing the FSAL readlink method to take a utf8string instead of a gsh_buffdesc allows for a clear definitions since we assure that internally all utf8strings are NUL terminated with the length just being a conveniemce. Introduced a new function that copies a character buffer (that need not be NUL terminated) into a utf8string, making a copy of the buffer, adding a NUL termination, and setting the utf8string_len properly. This allows elimination of all uses of the gsh_strldup macro that doesn't convert to an inline function well (due the the unknown type of the length variable) as part of a subsequent patch to make more header files usable with C++. Change-Id: Ifd5a250ba500f005d4345cac0fd1defaa14f8485 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/FSAL/FSAL_LIZARDFS/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_MEM/mem_int.h M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V4/handle.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_SAUNAFS/handle.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/handle_syscalls.c M src/FSAL/FSAL_VFS/vfs_methods.h M src/FSAL/FSAL_VFS/xfs/handle_syscalls.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_NULL/handle.c M src/FSAL/default_methods.c M src/FSAL/fsal_helper.c M src/Protocols/9P/9p_readlink.c M src/Protocols/NFS/nfs3_readlink.c M src/Protocols/NFS/nfs4_op_readlink.c M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_symlink_latency.cc M src/include/abstract_mem.h M src/include/fsal.h M src/include/fsal_api.h M src/include/nfsv41.h 28 files changed, 145 insertions(+), 150 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1226855/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifd5a250ba500f005d4345cac0fd1defaa14f8485 Gerrit-Change-Number: 1226855 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

13 hours, 26 minutes

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: clang-format fixups

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226854?usp=email ) Change subject: clang-format fixups ...................................................................... clang-format fixups Change-Id: I7e04a8d4d58cdf805d9c79edaf64193d20b93c2c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_symlink_latency.cc M src/include/fsal_api.h 4 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1226854/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7e04a8d4d58cdf805d9c79edaf64193d20b93c2c Gerrit-Change-Number: 1226854 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

13 hours, 26 minutes

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: TEST IGNORE

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226771?usp=email ) Change subject: TEST IGNORE ...................................................................... TEST IGNORE Change-Id: Icc923592d12d6454b0eb9f87f07929beb5c79cfd Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/1226771/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icc923592d12d6454b0eb9f87f07929beb5c79cfd Gerrit-Change-Number: 1226771 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 day, 19 hours

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: CEPH: Fix file handle leak

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226697?usp=email ) Change subject: CEPH: Fix file handle leak ...................................................................... CEPH: Fix file handle leak Fixing file handle leak which can occur during readdir operation. Change-Id: I9fb15630591bc4cf9685068040563b2a66bdebf7 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_CEPH/handle.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1226697/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226697?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9fb15630591bc4cf9685068040563b2a66bdebf7 Gerrit-Change-Number: 1226697 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

2 days, 23 hours

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Move full debug log after NULL state check in fsal_start_io()

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226665?usp=email ) Change subject: Move full debug log after NULL state check in fsal_start_io() ...................................................................... Move full debug log after NULL state check in fsal_start_io() The debug log statement printing the open state pointer and state type in fsal_start_io() was placed before checking if state is NULL. This could lead to potential dereference of a NULL pointer when full debug logging is enabled. This patch moves the LogFullDebug() call after the NULL check to ensure safe access to state fields. Change-Id: I68167e3d8209221559285e49690f5b28feaab081 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/1226665/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I68167e3d8209221559285e49690f5b28feaab081 Gerrit-Change-Number: 1226665 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

3 days, 4 hours

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix potential buffer overflow in cidr_from_str (Coverity CID 638296)

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226626?usp=email ) Change subject: Fix potential buffer overflow in cidr_from_str (Coverity CID 638296) ...................................................................... Fix potential buffer overflow in cidr_from_str (Coverity CID 638296) Fixes a buffer overflow in cidr_from_str by replacing strcpy with strlcpy and adding input length checks. Returns an error if the input address exceeds buffer size, ensuring safe string handling. Change-Id: Ied39b85f62231cd2667aefd2ab5f344314241682 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/support/ip_utils.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1226626/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ied39b85f62231cd2667aefd2ab5f344314241682 Gerrit-Change-Number: 1226626 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

4 days, 1 hour

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix buffer overrun in cidr_from_inaddr (Coverity CID 638312)

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226625?usp=email ) Change subject: Fix buffer overrun in cidr_from_inaddr (Coverity CID 638312) ...................................................................... Fix buffer overrun in cidr_from_inaddr (Coverity CID 638312) Fixes a buffer overrun in cidr_from_inaddr by copying just the in_addr structure. Change-Id: Ia14b0c93ed7ad175aaeb05f6e0e25299e87bb032 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/support/ip_utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/25/1226625/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia14b0c93ed7ad175aaeb05f6e0e25299e87bb032 Gerrit-Change-Number: 1226625 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

4 days, 1 hour

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Check mutex ops in set_idmapping_status (Coverity CID 542634)

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226623?usp=email ) Change subject: Check mutex ops in set_idmapping_status (Coverity CID 542634) ...................................................................... Check mutex ops in set_idmapping_status (Coverity CID 542634) Switch set_idmapping_status to PTHREAD_MUTEX_lock/unlock, ensuring mutex acquisition failures are caught and logged instead of proceeding unchecked. Change-Id: I4c8057553ce252446b81f9d15656dc98fe06d754 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/idmapper/idmapper.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/1226623/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226623?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4c8057553ce252446b81f9d15656dc98fe06d754 Gerrit-Change-Number: 1226623 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

4 days, 1 hour

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix some compilation warnings that can cause compilation failures

by Name of user not set (GerritHub)

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226621?usp=email ) Change subject: Fix some compilation warnings that can cause compilation failures ...................................................................... Fix some compilation warnings that can cause compilation failures Change-Id: I10a17e5ae2993e09679041a037ab754bc3df1fe8 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/Protocols/NFS/nfs4_op_free_stateid.c M src/monitoring/dynamic_metrics.cc 3 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/1226621/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226621?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I10a17e5ae2993e09679041a037ab754bc3df1fe8 Gerrit-Change-Number: 1226621 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

4 days, 2 hours

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel November 2025