November 2025 - Devel - Nfs Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: Update delegation conflict detection logic in state_deleg_conflict_im...

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225729?usp=email ) Change subject: Update delegation conflict detection logic in state_deleg_conflict_impl() ...................................................................... Update delegation conflict detection logic in state_deleg_conflict_impl() The implementation distinguishes between same-client and cross-client operations by comparing client IDs. - Same-client operations: Return false (no conflict, no recall needed). - Cross-client operations: Return true (conflict detected, trigger recall via `async_delegrecall()`). Skip calling fsal_reopen2() if the request is from the same client that is holding the delegation to avoid recall from cephfs. Change-Id: Iac6b28944c691d4c22227b88969f9371db5fcab3 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/Protocols/NFS/nfs4_op_open.c M src/SAL/state_deleg.c 2 files changed, 104 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/1225729/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225729?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iac6b28944c691d4c22227b88969f9371db5fcab3 Gerrit-Change-Number: 1225729 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

2 weeks, 2 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Logging: Use consistent logging components in recovery_fs.c

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225715?usp=email ) Change subject: Logging: Use consistent logging components in recovery_fs.c ...................................................................... Logging: Use consistent logging components in recovery_fs.c Consistently use COMPONENT_CLIENTID for logging. Change-Id: I6481628a1400435ed7efa72ae83e3deb08f8e794 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/SAL/recovery/recovery_fs.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1225715/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225715?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6481628a1400435ed7efa72ae83e3deb08f8e794 Gerrit-Change-Number: 1225715 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 3 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix null pointer dereference in SEQUENCE op

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225683?usp=email ) Change subject: Fix null pointer dereference in SEQUENCE op ...................................................................... Fix null pointer dereference in SEQUENCE op Add null check for session->clientid_record before calling nfs_rpc_get_chan() to prevent NULL pointer dereference. - nfs_rpc_get_chan(session->clientid_record, 0) is called without checking if session->clientid_record is NULL. - nfs_rpc_get_chan() immediately dereferences the clientid parameter (accesses clientid->cid_minorversion), causing a NULL pointer dereference if session->clientid_record is NULL. - Line 315 later checks for NULL, but this is too late. Change-Id: I48c7e052acfe7845ae25e96928b81d12b8a9af0b Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/Protocols/NFS/nfs4_op_sequence.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/1225683/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I48c7e052acfe7845ae25e96928b81d12b8a9af0b Gerrit-Change-Number: 1225683 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

2 weeks, 4 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Use PTHREAD_MUTEX macros for mutex operations

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225681?usp=email ) Change subject: Use PTHREAD_MUTEX macros for mutex operations ...................................................................... Use PTHREAD_MUTEX macros for mutex operations Replace pthread_mutex_lock()/pthread_mutex_unlock() with PTHREAD_MUTEX_lock()/PTHREAD_MUTEX_unlock() macros to check return values and match the codebase pattern. Affected functions: - is_stateid_revoked() - mark_sessions_have_revoked_delegations() - add_to_revoked_delegations() - remove_revoked_stateid() The macros automatically check return values and abort on errors, resolving Coverities - 638313, 638311, 638309, 638308, 638306, 638305, 638300, and 638297. Change-Id: I875b2c42ab06add9e6b929773cecfa180e250f47 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/SAL/state_deleg.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/1225681/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I875b2c42ab06add9e6b929773cecfa180e250f47 Gerrit-Change-Number: 1225681 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

2 weeks, 4 days

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: SAL: Allow IP based recovery from RecovDir

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225678?usp=email ) Change subject: SAL: Allow IP based recovery from RecovDir ...................................................................... SAL: Allow IP based recovery from RecovDir Currently, for clustered systems the CLIDs are created in RecoveryRoot/RecovDir/nodeX/xxxxx The CLIDs for recovery are read from RecoveryRoot/aa.bb.cc.dd where aa,bb,cc,dd is an IP address. This requires the node management software to copy and delete the CLIDs. The approach here allows the CLIDs to exists in RecoveryRoot/RecovDir/ip_IP_ADDRESS_STRING where IP_ADDRESS_STRING is an address the Ganesha instance is listening on. The format is either IPv6 or IPv4. The CLIDs are created in that directory and takeover events will read from that directory. Change-Id: Iac47a84e5c6559d37b9005e8b208bf5f4874dbbc Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c 2 files changed, 276 insertions(+), 35 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/1225678/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iac47a84e5c6559d37b9005e8b208bf5f4874dbbc Gerrit-Change-Number: 1225678 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 4 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Add cid_confirmed_saved to nfs_client_id_t

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225677?usp=email ) Change subject: Add cid_confirmed_saved to nfs_client_id_t ...................................................................... Add cid_confirmed_saved to nfs_client_id_t This is in preparation for the Virtual IP Based recovery. This required to be able to cleanup NFSv4.0 CLIDs on umount for the IP based in-situ reclaim. The indicator for being able to cleanup the CLID in fs_rm_clid() is that the client ID is in the confirmed state. We only want the CLID to be removed when the file system is no longer used by any of the nodes i.e. unmounted. Change-Id: I7ab4a74cacaf4fb2b5054352f69c7d5de3a1daee Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/SAL/nfs4_clientid.c M src/include/sal_data.h 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/1225677/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225677?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7ab4a74cacaf4fb2b5054352f69c7d5de3a1daee Gerrit-Change-Number: 1225677 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 4 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Modify cmp_sockaddr() to use nearly identical sockaddr_cmpf()

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225620?usp=email ) Change subject: Modify cmp_sockaddr() to use nearly identical sockaddr_cmpf() ...................................................................... Modify cmp_sockaddr() to use nearly identical sockaddr_cmpf() sockaddr_cmpf is a Comparator trichotomy so its result easily serves the true/false return of cmp_sockaddr. Change-Id: I2707256ad7edfac625b6033171c6af0d9c6b9355 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/support/ip_utils.c 1 file changed, 15 insertions(+), 56 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/20/1225620/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225620?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2707256ad7edfac625b6033171c6af0d9c6b9355 Gerrit-Change-Number: 1225620 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 5 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix IP address comparison for client manager

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225619?usp=email ) Change subject: Fix IP address comparison for client manager ...................................................................... Fix IP address comparison for client manager svc_getrpccaller() will retrieve IPv6 formatted IPv4 addresses such as ::ffff:192.168.10.94 and keep them in that format. This is passed through to init_op_context() by nfs_rpc_process_request() in nfs_worker_thread.c. arg_ipaddr() used in client_mgr.c could return the IPv4 version. Therefore, comparisons will fail. Here we normalise the addresses for the comparison. Change-Id: I083c01a4ebdf2d06beee35eda86c1f90b233bec5 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/support/ip_utils.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/19/1225619/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I083c01a4ebdf2d06beee35eda86c1f90b233bec5 Gerrit-Change-Number: 1225619 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 5 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Modify Enable_UDP config option to take NLM option

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225618?usp=email ) Change subject: Modify Enable_UDP config option to take NLM option ...................................................................... Modify Enable_UDP config option to take NLM option UDP needs to be enabled for NFS Ganesha to receive NLM messages from rpc-statd. When an NFS client reboots it sends SM_NOTIFY to rpc-statd on the NSF Ganesha server. Then rpc-statd needs to be able to send an SM_UNMON to NFS Ganesha's lock manager. If that communication is not possible, the client will keep sending the SM_NOTIFY until it gives up. The NFS server instances will become unstable. rpc-statd will only send this via UDP. Enabling all of the UDP port options with Enable_UDP = TRUE is not desirable. Only the MOUNT option really needs to be specified. NFS should not be enabled with UDP ports. So we add the ability to specify Enable_UDP = MOUNT, NLM Change-Id: Id435c32f915e6e6aef123c58edb2077ed05241f1 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 5 files changed, 19 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1225618/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1225618?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id435c32f915e6e6aef123c58edb2077ed05241f1 Gerrit-Change-Number: 1225618 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 5 days

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel November 2025