December 2025 - Devel - Nfs Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: D-Bus: Improve argument checking, drop default recovery/grace event

by Martin Schwenke (GerritHub)

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227749?usp=email ) Change subject: D-Bus: Improve argument checking, drop default recovery/grace event ...................................................................... D-Bus: Improve argument checking, drop default recovery/grace event Do argument checking at the highest possible level instead of dealing with it down in the depths, where some errors are currently ignored. Currently, if just an IP address is supplied then the default event is TAKE_IP. However, this causes ambiguity when used with IPv6 due to the use of colon (':') as a separator. For example, 2:ab:cd::42 can logically mean 2 completely different things: * Event 2 (RELEASE_IP) with IP address ab:cd::42 * Default event 5 (TAKE_IP) with IP address 2:ab:cd::42 Also, currently specifying 0 (without a trailing colon, attempting to mean JUST_GRACE) currently causes a TAKE_IP for IP address 0.0.0.0. This doesn't obey the principle of least surprise. The behaviour is changed to make the event mandatory. This way, the colon (':') separator should indicate the presence of a mandatory argument for the event. However, this would break backward compatibility for many users, so an empty argument (e.g. "0:") is treated the same as a missing argument (i.e. no colon-separator). The result of the IP address parse is currently unused. Using it would over-complicate this commit and it can be done in an additional commit with minimal churn. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: Ia03f9217385a45cb65121d966abb6e6e757abcd3 --- M src/MainNFSD/nfs_admin_thread.c 1 file changed, 62 insertions(+), 19 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1227749/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia03f9217385a45cb65121d966abb6e6e757abcd3 Gerrit-Change-Number: 1227749 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>

2 weeks, 1 day

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: SAL: Store and use parsed IP address

by Martin Schwenke (GerritHub)

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227750?usp=email ) Change subject: SAL: Store and use parsed IP address ...................................................................... SAL: Store and use parsed IP address This avoids unchecked (and now unnecessary) conversions in deeper logic. The conversion is now done once at the entry point. While nearby, also fix the comment describing the ipaddr field. Change-Id: I182b7cf02c71766712914c3381bc0e04cc6602f1 Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> --- M src/MainNFSD/nfs_admin_thread.c M src/SAL/nfs4_recovery.c M src/include/sal_data.h 3 files changed, 11 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1227750/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227750?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I182b7cf02c71766712914c3381bc0e04cc6602f1 Gerrit-Change-Number: 1227750 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>

2 weeks, 1 day

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: SAL: Only log relevant arguments for recovery events

by Martin Schwenke (GerritHub)

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227748?usp=email ) Change subject: SAL: Only log relevant arguments for recovery events ...................................................................... SAL: Only log relevant arguments for recovery events Instead of logging all possible arguments, only log the relevant argument for each event. Don't log any argument for events without arguments. A side-effect is that, after some subsequent cleanups, this will avoid logging a NULL gsp->ipaddr pointer. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I899f1357133160e037efe6d50c9c2bb62ffbc261 --- M src/SAL/nfs4_recovery.c 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/1227748/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227748?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I899f1357133160e037efe6d50c9c2bb62ffbc261 Gerrit-Change-Number: 1227748 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>

2 weeks, 1 day

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Monitoring: Restructuring metrics registering and updation

by Name of user not set (GerritHub)

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227696?usp=email ) Change subject: Monitoring: Restructuring metrics registering and updation ...................................................................... Monitoring: Restructuring metrics registering and updation This commit performs a major restructuring of how core NFS and RPC metrics are defined, registered, and updated. It eliminates the old, inefficient index-based metrics system in nfs_metrics.c and consolidates RPC metrics into the more modern, label-based dynamic metrics framework (dynamic_metrics.cc) Change-Id: Ida2379c922a2cebab7c6f1290f9a6610f502c593 Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com> --- M src/MainNFSD/nfs_metrics.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/include/nfs_metrics.h M src/monitoring/dynamic_metrics.cc M src/monitoring/include/dynamic_metrics.h M src/support/server_stats.c 6 files changed, 53 insertions(+), 108 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/1227696/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227696?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ida2379c922a2cebab7c6f1290f9a6610f502c593 Gerrit-Change-Number: 1227696 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

2 weeks, 1 day

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: NFSv4.1: Send initial CB_NULL after CREATE_SESSION to fix pynfs CSESS...

by Name of user not set (GerritHub)

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227695?usp=email ) Change subject: NFSv4.1: Send initial CB_NULL after CREATE_SESSION to fix pynfs CSESS20/21 ...................................................................... NFSv4.1: Send initial CB_NULL after CREATE_SESSION to fix pynfs CSESS20/21 Adds a minimal async CB_NULL callback once the backchannel is created. This satisfies pynfs expectations for callback program/version validation, resolving CSESS20 and CSESS21 failures. Change-Id: Id376986d5b2ad813c97e1d5b2e799efce1e4839b Signed-off-by: VidyaThumukunta <Vidya.Thumukunta(a)ibm.com> --- M src/Protocols/NFS/nfs4_op_create_session.c 1 file changed, 56 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1227695/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id376986d5b2ad813c97e1d5b2e799efce1e4839b Gerrit-Change-Number: 1227695 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

2 weeks, 1 day

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Fix SEGV in layoutrecall

by haihuayang (GerritHub)

haihuayang has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227481?usp=email ) Change subject: Fix SEGV in layoutrecall ...................................................................... Fix SEGV in layoutrecall recall->state_list is not protected by state lock, so it can be modified by other thread, and result SEGV Change-Id: Idd8ed0cb64990ccfe566caf3e3edb47f065836e5 Signed-off-by: Haihua Yang <yanghh(a)gmail.com> --- M src/FSAL_UP/fsal_up_top.c 1 file changed, 4 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/1227481/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227481?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idd8ed0cb64990ccfe566caf3e3edb47f065836e5 Gerrit-Change-Number: 1227481 Gerrit-PatchSet: 1 Gerrit-Owner: haihuayang <yanghh(a)gmail.com>

2 weeks, 5 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: add pnfs io stats

by haihuayang (GerritHub)

haihuayang has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227480?usp=email ) Change subject: add pnfs io stats ...................................................................... add pnfs io stats Change-Id: Id9d5d90a8b63ff4e02c637b1fdb2a7f54ed1c9c7 Signed-off-by: Haihua Yang <yanghh(a)gmail.com> --- M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_write.c 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/1227480/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227480?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id9d5d90a8b63ff4e02c637b1fdb2a7f54ed1c9c7 Gerrit-Change-Number: 1227480 Gerrit-PatchSet: 1 Gerrit-Owner: haihuayang <yanghh(a)gmail.com>

2 weeks, 5 days

1
0
0 / 0

[XL] Change in ...nfs-ganesha[next]: Infrastructure for gRPC

by Name of user not set (GerritHub)

Avani.Rateria(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227431?usp=email ) Change subject: Infrastructure for gRPC ...................................................................... Infrastructure for gRPC gRPC (gRPC Remote Procedure Call) is an open-source framework that enables communication between services through remote procedure calls (RPCs). It allows you to define services and their methods, generate client and server code and facilitate communication between distributed systems. The changes will facilitate both intra server communication (IPC) by replacing DBus and inter server communication. Currently, we support three APIs to replace DBus: 1) Retrieve connected client IDs. 2) Determine whether NFS is in grace period. 3) Retrieve session IDs. 4) Start NFS Grace Change-Id: I1fec117302b023d01ba469a48bb4287ec93d43ab Signed-off-by: Avani Rateria <Avani.Rateria(a)ibm.com> --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/MainNFSD/nfs_init.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/doc/man/ganesha-log-config.rst A src/grpc_server/CMakeLists.txt A src/grpc_server/GrpcServer.cc A src/grpc_server/GrpcServer.h A src/grpc_server/nfsService.h A src/grpc_server/nfsServiceClient.cc A src/grpc_server/nfsServiceServer.cc M src/include/config-h.in.cmake A src/include/gRPC/GrpcServerInit.h M src/include/gsh_config.h M src/include/log_common.h M src/include/nfs_core.h M src/include/sal_functions.h M src/log/log_functions.c A src/proto/CMakeLists.txt A src/proto/nfsService.proto M src/support/nfs_read_conf.c 22 files changed, 1,248 insertions(+), 142 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/1227431/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227431?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1fec117302b023d01ba469a48bb4287ec93d43ab Gerrit-Change-Number: 1227431 Gerrit-PatchSet: 1 Gerrit-Owner: Avani.Rateria(a)ibm.com

2 weeks, 6 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: SAL: Use correct recovery directory in fs_read_recov_clids_recover()

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227326?usp=email ) Change subject: SAL: Use correct recovery directory in fs_read_recov_clids_recover() ...................................................................... SAL: Use correct recovery directory in fs_read_recov_clids_recover() Use the passed in recov_dir rather than the global v4_recov_dir. Somehow that didn't make it into my VIP commit. Change-Id: Ied32237aef9ef5fcfa1a17948cfcd863c47ceb77 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/SAL/recovery/recovery_fs.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1227326/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227326?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ied32237aef9ef5fcfa1a17948cfcd863c47ceb77 Gerrit-Change-Number: 1227326 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

3 weeks, 1 day

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Don't update acl_time in mdcache_entry_t when ACL is preserved.

by Nikhil Adhau (GerritHub)

Nikhil Adhau has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227318?usp=email ) Change subject: Don't update acl_time in mdcache_entry_t when ACL is preserved. ...................................................................... Don't update acl_time in mdcache_entry_t when ACL is preserved. This change restores the previous acl_time when ACL is not refreshed from the FSAL but only preserved. Issue: - If ACL is already cached for an object and later if ACL is directly updated in backend (not via the NFS protocol), nfs4_getfacl returns stale ACL from MDCache. - nfs4_getfacl first sends a GETATTR without ATTR_ACL, which updates acl_time even though ACLs are not refreshed. - The later GETATTR with ATTR_ACL incorrectly uses the stale cached ACL because the updated acl_time suggests the ACL is still valid. Change-Id: I0c1d1136d049d28b53e4024c37d9ff132b73c6d3 Signed-off-by: Nikhil Adhau <nikhiladhau999(a)gmail.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1227318/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227318?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0c1d1136d049d28b53e4024c37d9ff132b73c6d3 Gerrit-Change-Number: 1227318 Gerrit-PatchSet: 1 Gerrit-Owner: Nikhil Adhau <nikhiladhau999(a)gmail.com>

3 weeks, 1 day

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel December 2025