[S] Change in ...nfs-ganesha[next]: Don't update acl_time in mdcache_entry_t when ACL is preserved.
by Nikhil Adhau (GerritHub)
Nikhil Adhau has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227318?usp=email )
Change subject: Don't update acl_time in mdcache_entry_t when ACL is preserved.
......................................................................
Don't update acl_time in mdcache_entry_t when ACL is preserved.
This change restores the previous acl_time when ACL is not refreshed
from the FSAL but only preserved.
Issue:
- If ACL is already cached for an object and later if ACL is directly
updated in backend (not via the NFS protocol), nfs4_getfacl returns stale
ACL from MDCache.
- nfs4_getfacl first sends a GETATTR without ATTR_ACL, which updates
acl_time even though ACLs are not refreshed.
- The later GETATTR with ATTR_ACL incorrectly uses the stale cached ACL
because the updated acl_time suggests the ACL is still valid.
Change-Id: I0c1d1136d049d28b53e4024c37d9ff132b73c6d3
Signed-off-by: Nikhil Adhau <nikhiladhau999(a)gmail.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1227318/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1227318?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I0c1d1136d049d28b53e4024c37d9ff132b73c6d3
Gerrit-Change-Number: 1227318
Gerrit-PatchSet: 1
Gerrit-Owner: Nikhil Adhau <nikhiladhau999(a)gmail.com>
1 month, 2 weeks