April 2025 - Devel - Nfs Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Coverity 509139 : In layoutcommit: A value assigned to a variable is ...

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214253?usp=email ) Change subject: Coverity 509139 : In layoutcommit: A value assigned to a variable is never used. Stored value is overwritten before it can be used. Fix added. ...................................................................... Coverity 509139 : In layoutcommit: A value assigned to a variable is never used. Stored value is overwritten before it can be used. Fix added. Change-Id: I0277508da9bccb09e5a4f1e54887a734378f1e4e Signed-off-by: s-athani <suhas.athani(a)ibm.com> --- M src/FSAL/FSAL_SAUNAFS/mds_handle.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/1214253/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0277508da9bccb09e5a4f1e54887a734378f1e4e Gerrit-Change-Number: 1214253 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

2 weeks, 1 day

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Added ganesha_export_metadata Prometheus metric Implemented a new Pro...

by Name of user not set (GerritHub)

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214218?usp=email ) Change subject: Added ganesha_export_metadata Prometheus metric Implemented a new Prometheus metric, ganesha_export_metadata, to expose metadata for each export, including labels such as access type, transport protocol, security type, FSAL backend, and export path. ...................................................................... Added ganesha_export_metadata Prometheus metric Implemented a new Prometheus metric, ganesha_export_metadata, to expose metadata for each export, including labels such as access type, transport protocol, security type, FSAL backend, and export path. Change-Id: I1f6928238034f63865d2881852aa7aa8d02ae6fe Signed-off-by: VidyaThumukunta <Vidya.Thumukunta(a)ibm.com> --- M src/support/export_mgr.c 1 file changed, 93 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1214218/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1f6928238034f63865d2881852aa7aa8d02ae6fe Gerrit-Change-Number: 1214218 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

2 weeks, 1 day

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix for coverity:542651 In encode_fs_locations: Added fix to prevent ...

by Animesh Javali (GerritHub)

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214181?usp=email ) Change subject: Fix for coverity:542651 In encode_fs_locations: Added fix to prevent leak of memory or pointers to system resources ...................................................................... Fix for coverity:542651 In encode_fs_locations: Added fix to prevent leak of memory or pointers to system resources Change-Id: If252b4cdd712421fe76d02368bb87fc650a74cbe Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/Protocols/NFS/nfs_proto_tools.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/1214181/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If252b4cdd712421fe76d02368bb87fc650a74cbe Gerrit-Change-Number: 1214181 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

2 weeks, 2 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: SAL: NFS V3 locks not released prior to DBUS reply sent

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214151?usp=email ) Change subject: SAL: NFS V3 locks not released prior to DBUS reply sent ...................................................................... SAL: NFS V3 locks not released prior to DBUS reply sent This fixes Issue #1270. In the case of NFS V3, the reply to the DBUS command (EVENT_RELEASE_IP) for releasing an IP address might be sent before the locks have been released. This is due to to locks being released asynchronously. Therefore, when the locks are attempted to be taken by another Ganesha instance they can fail due to STATE_LOCK_CONFLICT. They will fail in vfs_lock_op2 with :fcntl returned 11 Resource temporarily unavailable Here we change the behaviour of the unlocking to be synchronous. Change-Id: Ia169f816382b8c09e1be4410d315c60a339dfd62 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/SAL/nfs4_recovery.c 1 file changed, 9 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1214151/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214151?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia169f816382b8c09e1be4410d315c60a339dfd62 Gerrit-Change-Number: 1214151 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 2 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: NLM: Fix NFS rpc.statd-related hang

by Peter Schwenke (GerritHub)

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214144?usp=email ) Change subject: NLM: Fix NFS rpc.statd-related hang ...................................................................... NLM: Fix NFS rpc.statd-related hang Fixes Issue #680 This implements Frank Filz's suggestion in comment https://github.com/nfs-ganesha/nfs-ganesha/issues/680#issuecomment-266431... When the SM_MON and SM_UNMON RPC calls were made to statd and the threads were exhausted, nfs-ganesha was hanging on the ssc_mutex lock. ssc_monitored has been changed from a boolean to an enum {UNMONITORED, ATTEMPTING, MONITORED} nsm_monitor_noretry()/nsm_monitor_noretry() first check ssc_monitored to see if a monitor/unmonitor is being attempted. If so, we sleep for 1 sec and retry up to 3 times. Then we check if scc_monitored is already in the state we want i.e. UNMONITORED/MONITORED. If so, we bail. Otherwise, we set ssc_monitored to ATTEMPTING and try the RPC call. On RPC success, we flip ssc_monitored to UNMONITORED/MONITORED. On error, we set it back to what it would have been i.e. MONITORED/UNMONITORED Change-Id: I0f0814842d806132e6e4441fe0956236e5d914c5 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/Protocols/NLM/nsm.c M src/SAL/nlm_owner.c M src/include/sal_data.h 3 files changed, 56 insertions(+), 19 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1214144/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0f0814842d806132e6e4441fe0956236e5d914c5 Gerrit-Change-Number: 1214144 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

2 weeks, 3 days

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: Add support for a direct SSSD usage for idmapping

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214098?usp=email to review the following change. Change subject: Add support for a direct SSSD usage for idmapping ...................................................................... Add support for a direct SSSD usage for idmapping This CL adds support for direct SSSD idmapping functionality. By implementing wrappers for the relevant functions that are exposed via libsss_nss_idmap.so.0. The SSSD idmap implementation is selected if the relevant module is available and the enum PWNAM_IMPLEMENTATION__SSSD is passed to pwnam_wrappers__set_implementation. This implementation allows a Ganesha to perform direct idmapping from a SSSD server. The implementation is built by dynamically loading the relevant library, the implementation of the functions is also dynamic, which make this implementation work only on systems that have the sssd library installed. Change-Id: If6160c5980b9743800a172deb316ae408d294abd Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/CMakeLists.txt M src/idmapper/pwnam_wrappers.c A src/idmapper/sss_nss_idmap.c M src/include/pwnam_wrappers.h A src/include/sss_nss_idmap.h 5 files changed, 389 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1214098/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If6160c5980b9743800a172deb316ae408d294abd Gerrit-Change-Number: 1214098 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 5 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Make pwnam wrapper implementation configurable

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214097?usp=email to review the following change. Change subject: Make pwnam wrapper implementation configurable ...................................................................... Make pwnam wrapper implementation configurable This allows to switch between different implementations, e.g. NSS switch vs custom implementation. This is needed to decouple dependency on nsswitch and allow to replace it with a custom implementation that doesn't rely on nsswitch. Change-Id: If8f3877ada3c027047fc97ddea299f17a2c5afc6 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/pwnam_wrappers.c M src/include/pwnam_wrappers.h 2 files changed, 47 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1214097/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214097?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If8f3877ada3c027047fc97ddea299f17a2c5afc6 Gerrit-Change-Number: 1214097 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 5 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: NFS-Ganesha: Add support for a direct SSSD usage for idmapping

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214088?usp=email to review the following change. Change subject: NFS-Ganesha: Add support for a direct SSSD usage for idmapping ...................................................................... NFS-Ganesha: Add support for a direct SSSD usage for idmapping This CL adds support for direct SSSD idmapping functionality. By implementing wrappers for the relevant functions that are exposed via libsss_nss_idmap.so.0. The SSSD idmap implementation is selected if the relevant module is available and the enum PWNAM_IMPLEMENTATION__SSSD is passed to pwnam_wrappers__set_implementation. This implementation allows a Ganesha to perform direct idmapping from a SSSD server. The implementation is built by dynamically loading the relevant library, the implementation of the functions is also dynamic, which make this implementation work only on systems that have the sssd library installed. Change-Id: I29da8a4e2301322e139cc5b4f8bca4d5715478ae Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/pwnam_wrappers.c 1 file changed, 41 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/1214088/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I29da8a4e2301322e139cc5b4f8bca4d5715478ae Gerrit-Change-Number: 1214088 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 5 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: NFS-Ganesha: Add pwnam wrappers module

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214087?usp=email to review the following change. Change subject: NFS-Ganesha: Add pwnam wrappers module ...................................................................... NFS-Ganesha: Add pwnam wrappers module This commit adds wrappers for the `pwnam` functions. This will allow to add an alternative implementations to these functions. Change-Id: I3dbeed086e8b88fab1fffc09f833cdd9eea18300 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/CMakeLists.txt M src/idmapper/idmapper.c A src/idmapper/pwnam_wrappers.c A src/include/pwnam_wrappers.h M src/support/uid2grp.c 5 files changed, 140 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/1214087/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3dbeed086e8b88fab1fffc09f833cdd9eea18300 Gerrit-Change-Number: 1214087 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 5 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Added monitoring metric for when user exceeds max_groups_membership

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214085?usp=email to review the following change. Change subject: Added monitoring metric for when user exceeds max_groups_membership ...................................................................... Added monitoring metric for when user exceeds max_groups_membership This new metric will be incremented every time user has more groups than we allow, this will help to identify potential problems with large amount of groups. Change-Id: I12a286de50244745e0557c186731816adb382542 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/idmapper_monitoring.c M src/include/idmapper_monitoring.h M src/support/uid2grp.c 3 files changed, 35 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/1214085/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I12a286de50244745e0557c186731816adb382542 Gerrit-Change-Number: 1214085 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 5 days

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel April 2025