Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499251 ) Change subject: Simplify fsal_ds_handle ...................................................................... Simplify fsal_ds_handle This handle just has the lifetime of a single COMPOUND and other than the remote possibility it could be subject to SAVEFH/RESTOREFH can be very simply handled so it doesn't need a refcount or to be on a list of handles for the fsal_pnfs_ds. Move the dsh_ops into the fsal_pnfs_ds. There really is no need for handle specific ops. This makes the default struct fsal_ds_handle empty, however, FSALs will define their own private structure that extends it. Change-Id: I0c83f1f8e657cec533da26dd92f624a11e2ca35e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com&gt; --- M src/FSAL/FSAL_CEPH/ds.c M src/FSAL/FSAL_GLUSTER/ds.c M src/FSAL/FSAL_GPFS/fsal_ds.c M src/FSAL/FSAL_LIZARDFS/ds.c M src/FSAL/commonlib.c M src/FSAL/default_methods.c M src/FSAL/fsal_destroyer.c M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_commit.c M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_restorefh.c M src/Protocols/NFS/nfs4_op_savefh.c M src/Protocols/NFS/nfs4_op_write.c M src/include/FSAL/fsal_commonlib.h M src/include/fsal_api.h M src/include/nfs_proto_data.h 16 files changed, 65 insertions(+), 249 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/499251/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499251 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0c83f1f8e657cec533da26dd92f624a11e2ca35e Gerrit-Change-Number: 499251 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com&gt; Gerrit-MessageType: newchange