Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173661?usp=email ) Change subject: bind_conn_to_session: Validate check/add connection to session output ...................................................................... bind_conn_to_session: Validate check/add connection to session output Currently during bind_conn_to_session op, Ganesha checks if the request's connection is part of the input session. If the check fails, it performs the required addition of the connection to the session. However, if the addition fails, it does not fail the op. This is incorrect, since the client would assume that the bind happened successfully, while the server maintained client's session still has no knowledge of the connection. This would cause failures in ops where Ganesha relies on the session's connection to validate the request. Change-Id: I5c36b5179e6cfda330178919278e597f6aad6b76 Signed-off-by: Dipit Grover <dipit(a)google.com&gt; --- M src/Protocols/NFS/nfs4_op_bind_conn.c 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/1173661/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5c36b5179e6cfda330178919278e597f6aad6b76 Gerrit-Change-Number: 1173661 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com&gt;