Change in ffilz/nfs-ganesha[next]: 9p readdir: change custom offsets from 1/2 to -1/-2
by GerritHub
From Dominique Martinet <asmadeus(a)codewreck.org>:
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/420213
Change subject: 9p readdir: change custom offsets from 1/2 to -1/-2
......................................................................
9p readdir: change custom offsets from 1/2 to -1/-2
The linux VFS with a tmpfs filesystem will return offset=2 in a
directory with a single entry (+./..), leading with this code into an
infinite loop (the client keeps sending readdirs until there is nothing
to read, but the last offset is 2 so it resets to 0 because of our
hardcoded ./.. cases)
This has the same theorical problem, but hopefully we won't see very big
offsets?...
Change-Id: Ifbbd59959b0e05f4018435e913a6b8696ca4534e
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/Protocols/9P/9p_readdir.c
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/420213/1
--
To view, visit https://review.gerrithub.io/420213
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbbd59959b0e05f4018435e913a6b8696ca4534e
Gerrit-Change-Number: 420213
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: gtest - convert readdir_correctness to obj_ops pointer
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420187
Change subject: gtest - convert readdir_correctness to obj_ops pointer
......................................................................
gtest - convert readdir_correctness to obj_ops pointer
Change-Id: I0d4e4715da926076dc1b0e6c03dc74656c6d180a
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/gtest/fsal_api/test_readdir_correctness.cc
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/420187/1
--
To view, visit https://review.gerrithub.io/420187
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d4e4715da926076dc1b0e6c03dc74656c6d180a
Gerrit-Change-Number: 420187
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: NFS: nfs4_write should be checking BLOCKS for quota
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420173
Change subject: NFS: nfs4_write should be checking BLOCKS for quota
......................................................................
NFS: nfs4_write should be checking BLOCKS for quota
This is checking the INODES quota when it seems like it should be
testing for BLOCKS (as NFSv3 does). The point is somewhat moot since
nothing implements check_quota operation, and so this is not really
tested either way.
Change-Id: I3b6a02bd6dc246c050e0f3bfa46161d0032d2167
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_write.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/420173/1
--
To view, visit https://review.gerrithub.io/420173
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b6a02bd6dc246c050e0f3bfa46161d0032d2167
Gerrit-Change-Number: 420173
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 9 months
Announce Push of V2.7-dev.21
by Frank Filz
Branch next
Tag:V2.7-dev.21
Release Highlights
* FSAL: Convert fsal_obj_ops in fsal_obj_handle to pointer
* Allow octal numbers with multiple leading 0s in config parsing.
* Revert dirent accounting
* Big patch set in support of implementing FSAL readdirplus to
replace dir chunks whose handle cache entries have been recycled
* Big patch set to make Ganesha compile on FreeBSD
* NFSv4.1: implement TEST_STATEID operation
* Fix bad setattr valid_mask checking in nfs3_setattr
* Lots of little fixes
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
13bcfa9 Frank S. Filz V2.7-dev.21
4507efa Daniel Gryniewicz Consolidate Docs and doc directories
5328f3a Kinglong Mee Fix bad setattr valid_mask checking in nfs3_setattr
95f4c17 Dominique Martinet build: cleanup unused defines in config.h
2105595 Kaleb S. KEITHLEY build: location of xattr.h
2c76c1b Patrice LUCAS multilock posix : fix unknown symbol INT64_MAX
cfd270c Patrice LUCAS multilock ceph : fix uninitialized compiler warning
9a083ab Patrice LUCAS config_parsing : fix uninitialized compiler warning
9ed6f91 Patrice LUCAS 9P : remove old infiniband/arch.h and rdma_cma.h refs
8c27de1 Fatih Acar NFSv4.1: implement TEST_STATEID operation
f587d8d Fatih Acar nfsd: fix compilation when gss is disabled
d5879ca Fatih Acar cmake: fix pkgconfig module on FreeBSD
2c8ef87 Fatih Acar FreeBSD: use custom syscalls to set credentials
9b76d09 Fatih Acar FSAL_VFS, FreeBSD: fix handling of symbolic links
6d8c3ae Fatih Acar FSAL_VFS: fix dummy handles on vanilla FreeBSD
8712325 Fatih Acar dbus: remove unrequired Linux headers
37f0131 Fatih Acar FSAL_VFS: fix read_dirents on FreeBSD
9719d6a Fatih Acar FSAL_VFS, FreeBSD: use kernel default MAXFIDSIZE
d4adff4 Fatih Acar FSAL_VFS: do not use fid_reserved on vanilla FreeBSD
e929ce2 Fatih Acar FSAL_VFS: fix compilation error due to lock_op2 on
FreeBSD
0475402 Fatih Acar cmake: link libntirpc first
3954eb2 Fatih Acar config: fix ip addr parsing on FreeBSD
ce450d4 Fatih Acar SAL, recovery: add missing include
70f1877 Fatih Acar cmake: fix epoll check on FreeBSD
25d235f Daniel Gryniewicz FSAL_MEM - Don't pass stack garbage as an FD
2336c8a Daniel Gryniewicz LOG - Add LogEventAlt()
46656b4 Daniel Gryniewicz MDCACHE - Updates to tracepoints
3aa8575 Daniel Gryniewicz MDCACHE - Allow readdir_plus to reload entire
chunks
6892983 Daniel Gryniewicz MDCACHE - Keep dirent chunks in ordered list
8e01a61 Daniel Gryniewicz Add readdir_plus FSAL option.
3d1a3ce Daniel Gryniewicz MDCACHE - Don't clean handle before dirents are
deleted
9b54226 Daniel Gryniewicz FSAL_MEM - Convert dirent tracking to refcount
2e3f9c3 Daniel Gryniewicz FSAL_MEM - Fix broken readahead limit
045ca1f Daniel Gryniewicz GTest - Add a readdir() correctness test
6bc58a6 Daniel Gryniewicz GTest - Allow directory for create_many
39609c0 Daniel Gryniewicz CMake - gtests need some Boost
456cce1 Daniel Gryniewicz CMake - Fix FindLTTng.cmake
abc7cab Daniel Gryniewicz Revert dirent accounting
eeb8907 Frank S. Filz Allow octal numbers with multiple leading 0s in config
parsing.
7ef382e Frank S. Filz FSAL_NULL: Remove obsolete next_ops
e479785 Frank S. Filz FSAL: Convert fsal_obj_ops in fsal_obj_handle to
pointer
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: GPFS: wire up GPFS to new allocate operation
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420095
Change subject: GPFS: wire up GPFS to new allocate operation
......................................................................
GPFS: wire up GPFS to new allocate operation
...instead of dispatching through write2. Note that this is untested as
I don't have a way to test GPFS, so this is a completely naive
conversion.
It's probably also possible with this change to simplify gpfs_write2 as
well, but I'll leave that to others.
Change-Id: I616a973661d5328299055a19082cd4663bad1a44
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_GPFS/file.c
M src/FSAL/FSAL_GPFS/gpfs_methods.h
M src/FSAL/FSAL_GPFS/handle.c
3 files changed, 63 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/420095/1
--
To view, visit https://review.gerrithub.io/420095
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I616a973661d5328299055a19082cd4663bad1a44
Gerrit-Change-Number: 420095
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: FSAL_CEPH: add allocate operation
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420094
Change subject: FSAL_CEPH: add allocate operation
......................................................................
FSAL_CEPH: add allocate operation
Change-Id: I17b1769fc340d1a560dd9ea77334eea8d62793ce
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/handle.c
M src/cmake/modules/FindCEPHFS.cmake
M src/include/config-h.in.cmake
3 files changed, 76 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/420094/1
--
To view, visit https://review.gerrithub.io/420094
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17b1769fc340d1a560dd9ea77334eea8d62793ce
Gerrit-Change-Number: 420094
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: NFS: rework nfs4_op_allocate to dispatch through allocate op
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420093
Change subject: NFS: rework nfs4_op_allocate to dispatch through allocate op
......................................................................
NFS: rework nfs4_op_allocate to dispatch through allocate op
Change-Id: I33b987c802c9e0eff8b884649dce8948bb417edd
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_write.c
1 file changed, 185 insertions(+), 44 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/420093/1
--
To view, visit https://review.gerrithub.io/420093
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33b987c802c9e0eff8b884649dce8948bb417edd
Gerrit-Change-Number: 420093
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: MDCACHE: wire up the ALLOCATE call passthrough
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420092
Change subject: MDCACHE: wire up the ALLOCATE call passthrough
......................................................................
MDCACHE: wire up the ALLOCATE call passthrough
Change-Id: Ibc2bdd72ea730fc279f1d4bade36f0c55a8d4805
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/420092/1
--
To view, visit https://review.gerrithub.io/420092
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc2bdd72ea730fc279f1d4bade36f0c55a8d4805
Gerrit-Change-Number: 420092
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: FSAL: add a new allocate fsal operation
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420091
Change subject: FSAL: add a new allocate fsal operation
......................................................................
FSAL: add a new allocate fsal operation
Change-Id: Id4f2284344051c7fbec517f249d372ad9ff88407
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/default_methods.c
M src/include/fsal_api.h
2 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/420091/1
--
To view, visit https://review.gerrithub.io/420091
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4f2284344051c7fbec517f249d372ad9ff88407
Gerrit-Change-Number: 420091
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 9 months
