Change in ffilz/nfs-ganesha[next]: In function state lock, when blow three situation happen together: 1）...
by GerritHub
From <zhoury14(a)mails.tsinghua.edu.cn>:
zhoury14(a)mails.tsinghua.edu.cn has uploaded this change for review. ( https://review.gerrithub.io/419770
Change subject: In function state_lock, when blow three situation happen together: 1）the parameter blocking = NLM_STATE_LOCKING 2）and can find a conflict lock entry in obj->state_hdl->file.lock_list, in that case copy_conflict will be called 3）and FSAL support async blocking locks The return value of do_lock_op and state_lock will be STATE_LOCK_BLOCKED. And in function nlm4_Lock:177, the nlm_process_conflict may not be called, which there will lost a call of dec_state_owner_re
......................................................................
In function state_lock, when blow three situation happen together:
1）the parameter blocking = NLM_STATE_LOCKING
2）and can find a conflict lock entry in obj->state_hdl->file.lock_list, in that case copy_conflict will be called
3）and FSAL support async blocking locks
The return value of do_lock_op and state_lock will be STATE_LOCK_BLOCKED. And in function nlm4_Lock:177, the nlm_process_conflict may not be called, which there will lost a call of dec_state_owner_re
Change-Id: I12b4f6bb944c1af913c1ac7246bc02647129d812
Signed-off-by: zhoury14 <zhoury14(a)mails.tsinghua.edu.cn>
---
M src/Protocols/NLM/nlm_Lock.c
M src/SAL/state_lock.c
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/419770/1
--
To view, visit https://review.gerrithub.io/419770
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12b4f6bb944c1af913c1ac7246bc02647129d812
Gerrit-Change-Number: 419770
Gerrit-PatchSet: 1
Gerrit-Owner: zhoury14(a)mails.tsinghua.edu.cn
6 years, 5 months
Change in ffilz/nfs-ganesha[next]: build: cleanup unused defines in config.h
by GerritHub
From Dominique Martinet <asmadeus(a)codewreck.org>:
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/419602
Change subject: build: cleanup unused defines in config.h
......................................................................
build: cleanup unused defines in config.h
Many defines in config.h were left-over from the old configure script,
where the file was autogenerated, but not actually used.
Having less defines reduce the maintenance burden (e.g. not having to
rename it!) so unused macros should be removed.
These were found and manually checked with this command:
awk '/cmakedefine/ {print $2}' < src/include/config-h.in.cmake | \
while read -r v; do
echo "--------------------------"
echo "$v"
git grep -w "$v"
done | less
Change-Id: If96ff7bd41f395d90bd647194f4de0f7bb5e2d74
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/CMakeLists.txt
M src/include/config-h.in.cmake
2 files changed, 2 insertions(+), 14 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/419602/1
--
To view, visit https://review.gerrithub.io/419602
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: If96ff7bd41f395d90bd647194f4de0f7bb5e2d74
Gerrit-Change-Number: 419602
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
6 years, 5 months
Change in ffilz/nfs-ganesha[next]: multilock posix : fix unknown symbol INT64_MAX
by GerritHub
From Patrice LUCAS <patrice.lucas(a)cea.fr>:
Patrice LUCAS has uploaded this change for review. ( https://review.gerrithub.io/419541
Change subject: multilock posix : fix unknown symbol INT64_MAX
......................................................................
multilock posix : fix unknown symbol INT64_MAX
Change-Id: I52096da90566bdd2aa16b590ae364848df25c4f7
Signed-off-by: Patrice LUCAS <patrice.lucas(a)cea.fr>
---
M src/tools/multilock/ml_posix_client.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/419541/1
--
To view, visit https://review.gerrithub.io/419541
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52096da90566bdd2aa16b590ae364848df25c4f7
Gerrit-Change-Number: 419541
Gerrit-PatchSet: 1
Gerrit-Owner: Patrice LUCAS <patrice.lucas(a)cea.fr>
6 years, 5 months
Change in ffilz/nfs-ganesha[next]: multilock ceph : fix uninitialized compiler warning
by GerritHub
From Patrice LUCAS <patrice.lucas(a)cea.fr>:
Patrice LUCAS has uploaded this change for review. ( https://review.gerrithub.io/419528
Change subject: multilock ceph : fix uninitialized compiler warning
......................................................................
multilock ceph : fix uninitialized compiler warning
Change-Id: Ic3603cbef5b977d7e1f2d14dde43779d18fc8ccd
Signed-off-by: Patrice LUCAS <patrice.lucas(a)cea.fr>
---
M src/tools/multilock/ml_cephfs_client.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/419528/1
--
To view, visit https://review.gerrithub.io/419528
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3603cbef5b977d7e1f2d14dde43779d18fc8ccd
Gerrit-Change-Number: 419528
Gerrit-PatchSet: 1
Gerrit-Owner: Patrice LUCAS <patrice.lucas(a)cea.fr>
6 years, 5 months
Change in ffilz/nfs-ganesha[next]: config_parsing : fix uninitialized compiler warning
by GerritHub
From Patrice LUCAS <patrice.lucas(a)cea.fr>:
Patrice LUCAS has uploaded this change for review. ( https://review.gerrithub.io/419500
Change subject: config_parsing : fix uninitialized compiler warning
......................................................................
config_parsing : fix uninitialized compiler warning
Change-Id: I46194bd4bb281087a73acafecded8d27e7491bbc
Signed-off-by: Patrice LUCAS <patrice.lucas(a)cea.fr>
---
M src/config_parsing/conf_url_rados.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/419500/1
--
To view, visit https://review.gerrithub.io/419500
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46194bd4bb281087a73acafecded8d27e7491bbc
Gerrit-Change-Number: 419500
Gerrit-PatchSet: 1
Gerrit-Owner: Patrice LUCAS <patrice.lucas(a)cea.fr>
6 years, 5 months
nfs-ganesha crashes in FSAL_MDCACHE
by Fatih Acar
Hello,
We hit some crashes while using nfs-ganesha.
From my understanding, it looks like there are some races where an entry
is somehow free'd twice.
It mostly happen when MDCACHE is in extremis mode.
Is it a known issue that would be fixed in next? I couldn't find
anything about that.
Thanks.
You can find backtraces below:
nfs-ganesha 2.6.2
#0 rwlock_wrlock_common (rwlock=0xb0, abstime=0x0) at
/usr/local/poudriere/jails/filer_stable_11/usr/src/lib/libthr/thread/thr_rwlock.c:58
58
/usr/local/poudriere/jails/filer_stable_11/usr/src/lib/libthr/thread/thr_rwlock.c:
No such file or directory.
in
/usr/local/poudriere/jails/filer_stable_11/usr/src/lib/libthr/thread/thr_rwlock.c
(gdb) bt
#0 rwlock_wrlock_common (rwlock=0xb0, abstime=0x0) at
/usr/local/poudriere/jails/filer_stable_11/usr/src/lib/libthr/thread/thr_rwlock.c:58
#1 0x000000000041b75e in fsal_obj_handle_fini (obj=0xb02534408) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/FSAL/commonlib.c:192
#2 0x00000000004d1b13 in mdcache_lru_clean (entry=0xb02534400) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:589
#3 0x00000000004d2467 in _mdcache_lru_unref (entry=0xb02534400,
flags=<value optimized out>, func=<value optimized out>, line=<value
optimized out>) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1915
#4 0x00000000004d31e4 in lru_reap_impl (qid=LRU_ENTRY_L1) at
mdcache_hash.h:238
#5 0x00000000004d166c in mdcache_lru_get () at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:717
#6 0x00000000004dc66e in mdcache_new_entry (export=0x802b19b80,
sub_handle=0x9a4af9100, attrs_in=0x7fffdbdc43f8, attrs_out=0x0,
new_directory=false, entry=0x7fffdbdc4550, state=0x0)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:143
#7 0x00000000004dde9f in mdcache_locate_host (fh_desc=0x7fffdbdc45b0,
export=<value optimized out>, entry=0x7fffdbdc4550, attrs_out=0x0) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1000
#8 0x00000000004d9219 in mdcache_create_handle (exp_hdl=0x802b19b80,
fh_desc=<value optimized out>, handle=0x7fffdbdc4590, attrs_out=0x0) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1757
#9 0x000000000045ba9c in nfs4_op_putfh (op=<value optimized out>,
data=0x7fffdbdc4a50, resp=0x8b3075de0) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/Protocols/NFS/nfs4_op_putfh.c:211
#10 0x000000000044b5e4 in nfs4_Compound (arg=<value optimized out>,
req=<value optimized out>, res=<value optimized out>) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/Protocols/NFS/nfs4_Compound.c:752
#11 0x000000000043db17 in nfs_rpc_process_request (reqdata=<value
optimized out>) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/MainNFSD/nfs_worker_thread.c:1329
#12 0x000000000043c98b in nfs_rpc_valid_NFS (req=0x822426000) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/MainNFSD/nfs_worker_thread.c:1554
#13 0x0000000800974a66 in svc_vc_decode (req=0x822426000) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/libntirpc/src/svc_vc.c:815
#14 0x000000000043c418 in nfs_rpc_decode_request (xprt=0x80b919180,
xdrs=0xa1e7b86c0) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/MainNFSD/nfs_rpc_dispatcher_thread.c:1317
#15 0x0000000800973f54 in svc_vc_recv (xprt=<value optimized out>) at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/libntirpc/src/svc_vc.c:788
#16 0x0000000800972051 in svc_rqst_xprt_task (wpe=<value optimized out>)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/libntirpc/src/svc_rqst.c:750
#17 0x000000080097a2c2 in work_pool_thread (arg=<value optimized out>)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.2.0/src/libntirpc/src/work_pool.c:176
#18 0x000000080159bc06 in thread_start (curthread=0x81ee4ad00) at
/usr/local/poudriere/jails/filer_stable_11/usr/src/lib/libthr/thread/thr_create.c:289
#19 0x0000000000000000 in ?? ()
nfs-ganesha 2.6.1
0 rwlock_wrlock_common (rwlock=0xb0, abstime=0x0)
at
/usr/local/poudriere/jails/filer_stable_11/usr/src/lib/libthr/thread/thr_rwlock.c:58
1 0x000000000041b75e in fsal_obj_handle_fini (obj=0xa6fb74808)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.1.2/src/FSAL/commonlib.c:192
2 0x00000000004d0f5f in mdcache_lru_clean (entry=0xa6fb74800)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.1.2/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:589
3 0x00000000004d1907 in _mdcache_lru_unref (entry=0xa6fb74800,
flags=<value optimized out>, func=<value optimized out>,
line=<value optimized out>)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.1.2/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1907
4 0x00000000004dbfbc in mdcache_new_entry (export=<value optimized
out>, sub_handle=0xa65d7a500, attrs_in=0x7fffdcbd1388,
attrs_out=0x0, new_directory=false, entry=0x7fffdcbd14e0,
state=0x0) at mdcache_lru.h:190
5 0x00000000004dd23f in mdcache_locate_host
(fh_desc=0x7fffdcbd1540, export=<value optimized out>, entry=0x7fffdcbd14e0,
attrs_out=0x0)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.1.2/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:999
6 0x00000000004d8599 in mdcache_create_handle (exp_hdl=0x802902080,
fh_desc=<value optimized out>, handle=0x7fffdcbd1520,
attrs_out=0x0)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.1.2/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1757
7 0x000000000045b40c in nfs4_op_putfh (op=<value optimized out>,
data=0x7fffdcbd19e0, resp=0xa8abb94e0)
at
/wrkdirs/usr/ports/gandi/ganesha/work/ganesha-2.6.1.2/src/Protocols/NFS/nfs4_op_putfh.c:211
--
Fatih ACAR
Gandi
fatih.acar(a)gandi.net
6 years, 5 months
Change in ffilz/nfs-ganesha[next]: build: location of xattr.h
by GerritHub
From <kaleb(a)redhat.com>:
kaleb(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/419427
Change subject: build: location of xattr.h
......................................................................
build: location of xattr.h
starting with libattr-devel-2.4.48-1 in Fedora 28 <attr/xattr.h> has
been removed from the package.
On Fedora, RHEL/CentOS, and SUSE, the glibc-headers package has provided
a near identical file, <sys/xattr.h> in all the releases that we care
about.
On Debian, libc6-dev provides <sys/xattr.h> all the way back to 8/Jessie
and presumably all Ubuntu derivatives since then.
Note that on Debian the sys headers are installed in
/usr/include/$DEB_HOST_GNU_TYPE/sys/...
Above and beyond that there is an .../include/os/xattr.h that should
be used.
Fixes CMakelists.txt (for FSAL_GLUSTER) to look for xattr.h in .../sys/
and related config-h.in.cmake change, fixes FSAL_GLUSTER to use
"os/xattr.h", and fixes several erroneous uses of <os/xattr.h> that
should be "os/xattr.h"
Change-Id: Ic0f334ed768484c12a868d9abd5126c69b7f7023
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
---
M src/CMakeLists.txt
M src/FSAL/FSAL_GLUSTER/gluster_internal.c
M src/FSAL/FSAL_VFS/xattrs.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_xattrs.c
M src/FSAL/Stackable_FSALs/FSAL_NULL/xattrs.c
M src/Protocols/9P/9p_xattrcreate.c
M src/Protocols/9P/9p_xattrwalk.c
M src/include/config-h.in.cmake
8 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/419427/1
--
To view, visit https://review.gerrithub.io/419427
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0f334ed768484c12a868d9abd5126c69b7f7023
Gerrit-Change-Number: 419427
Gerrit-PatchSet: 1
Gerrit-Owner: kaleb(a)redhat.com
6 years, 5 months
Change in ffilz/nfs-ganesha[next]: Consolidate Docs and doc directories
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/419407
Change subject: Consolidate Docs and doc directories
......................................................................
Consolidate Docs and doc directories
Change-Id: I9f0116999c20b0e93b925076be5a0cee26bf7638
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/Doxyfile.in
R src/doc/Resources.txt
R src/doc/USEFUL-RFCs.txt
R src/doc/coding_style/doxygen.txt
4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/419407/1
--
To view, visit https://review.gerrithub.io/419407
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f0116999c20b0e93b925076be5a0cee26bf7638
Gerrit-Change-Number: 419407
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 5 months
Ganesha ci-tests over FEDORA 28
by patrice.lucas＠cea.fr
I'm trying to update Ganesha CEA Continuous-Integration tests by setting
a new configuration over FEDORA 28.
I'm facing a first cmake error because the "attr/xattr.h" file seems not
to exist anymore in Fedora 28. This file is claimed by the gluster FSAL.
Does anyone already compile the Gluster FSAL over Fedora 28 ?
Should we remove the use of "attr/xattr.h" by the gluster fsal ? Which
is the bast replacement for "attr/xattr.h" ?
Regards,
Patrice
6 years, 5 months
Change in ffilz/nfs-ganesha[next]: cmake: fix pkgconfig module on FreeBSD
by GerritHub
From <fatih(a)gandi.net>:
fatih(a)gandi.net has uploaded this change for review. ( https://review.gerrithub.io/419396
Change subject: cmake: fix pkgconfig module on FreeBSD
......................................................................
cmake: fix pkgconfig module on FreeBSD
we use pkgconf on FreeBSD
Change-Id: I0cd7a77db2c8c80571084863d1e0135d1c563441
Signed-off-by: Fatih Acar <fatih.acar(a)gandi.net>
---
M src/cmake/modules/FindPkgConfig.cmake
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/419396/1
--
To view, visit https://review.gerrithub.io/419396
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cd7a77db2c8c80571084863d1e0135d1c563441
Gerrit-Change-Number: 419396
Gerrit-PatchSet: 1
Gerrit-Owner: fatih(a)gandi.net
6 years, 5 months
