Change in ffilz/nfs-ganesha[next]: Allow octal numbers with multiple leading 0s in config parsing.
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/420085
Change subject: Allow octal numbers with multiple leading 0s in config parsing.
......................................................................
Allow octal numbers with multiple leading 0s in config parsing.
Mode values are usually specified in octal using 4 digits, so a mode
might be specified as 0002. Command line tools such as chmod allow
this and there is no reason we can't in our config.
Change-Id: I97adef0251fd5281e4a43b07fa7bbcbba05d525c
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/config_parsing/conf_lex.l
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/420085/1
--
To view, visit https://review.gerrithub.io/420085
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97adef0251fd5281e4a43b07fa7bbcbba05d525c
Gerrit-Change-Number: 420085
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: FSAL_MEM - Don't pass stack garbage as an FD
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420081
Change subject: FSAL_MEM - Don't pass stack garbage as an FD
......................................................................
FSAL_MEM - Don't pass stack garbage as an FD
Change-Id: I0a7dce30f6bb9abe964006c36e02271a00103f43
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/420081/1
--
To view, visit https://review.gerrithub.io/420081
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a7dce30f6bb9abe964006c36e02271a00103f43
Gerrit-Change-Number: 420081
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: LOG - Add LogEventAlt()
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420080
Change subject: LOG - Add LogEventAlt()
......................................................................
LOG - Add LogEventAlt()
And an Event version of the Alt log. This is useful for debugging, so
that specific LogFullDebugAlt() calls can be changed to Event level for
tracing without logging too much.
Change-Id: Ia9af852d263324bf169a131f162b4e0a25439e07
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/include/log.h
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/420080/1
--
To view, visit https://review.gerrithub.io/420080
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9af852d263324bf169a131f162b4e0a25439e07
Gerrit-Change-Number: 420080
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Updates to tracepoints
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420079
Change subject: MDCACHE - Updates to tracepoints
......................................................................
MDCACHE - Updates to tracepoints
Change-Id: I8710ed65fa513105461476c81d387b2edf9f2703
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h
M src/include/gsh_lttng/fsal_mem.h
M src/include/gsh_lttng/mdcache.h
6 files changed, 34 insertions(+), 14 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/420079/1
--
To view, visit https://review.gerrithub.io/420079
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8710ed65fa513105461476c81d387b2edf9f2703
Gerrit-Change-Number: 420079
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Allow readdir_plus to reload entire chunks
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420078
Change subject: MDCACHE - Allow readdir_plus to reload entire chunks
......................................................................
MDCACHE - Allow readdir_plus to reload entire chunks
When the handle cache is full, there may be dirents (even a lot of them)
that are cached that have no corresponding entry in the handle cache.
When a readdir() hits a chunk of these, it must to a lookup() and a
getattrs() on each one, causing many round-trips to the cluster, raising
latency of readdir() considerably.
However, if a FSAL has readdir_plus, it can get multiple dirents and
their associated entries and attributes in one (or a few) round-trips to
the cluster. If this is the case, remove the empty chunk, and reload
it from the FSAL.
In addition, to make sure that entries in a chunk are not reaped while
that chunk is being used for readdir(), take a ref on each entry until
it's passed up to the caller.
Change-Id: Ibefd1ca782c7d616efde8cdf7335881df5a95c6e
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h
M src/include/gsh_lttng/mdcache.h
3 files changed, 98 insertions(+), 19 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/420078/1
--
To view, visit https://review.gerrithub.io/420078
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibefd1ca782c7d616efde8cdf7335881df5a95c6e
Gerrit-Change-Number: 420078
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Keep dirent chunks in ordered list
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420077
Change subject: MDCACHE - Keep dirent chunks in ordered list
......................................................................
MDCACHE - Keep dirent chunks in ordered list
Keeping chunks in an ordered list is simple (no more overhead) and
allows us to reload a chunk into it's correct position, and find prev
and next chunks easily.
Change-Id: I105d9162bc3a940a50181f9cb4527afb9604bed8
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h
M src/include/gsh_list.h
5 files changed, 54 insertions(+), 38 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/420077/1
--
To view, visit https://review.gerrithub.io/420077
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I105d9162bc3a940a50181f9cb4527afb9604bed8
Gerrit-Change-Number: 420077
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: Add readdir_plus FSAL option.
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420076
Change subject: Add readdir_plus FSAL option.
......................................................................
Add readdir_plus FSAL option.
If a FSAL supports readdir_plus, then we want to optimize dirent/object
cache interactions to minimize lookup() calls, and maximize
readdir_plus() calls during readdir. This allows us to minimize
round-trips to the cluster.
Change-Id: I1ea918419c880ddc0afb7e9d1474dc0776347f2f
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_main.c
M src/FSAL/fsal_config.c
M src/include/fsal_types.h
3 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/420076/1
--
To view, visit https://review.gerrithub.io/420076
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ea918419c880ddc0afb7e9d1474dc0776347f2f
Gerrit-Change-Number: 420076
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Don't clean handle before dirents are deleted
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420075
Change subject: MDCACHE - Don't clean handle before dirents are deleted
......................................................................
MDCACHE - Don't clean handle before dirents are deleted
Change-Id: Id396209e1f3526861118641485ff61c5fd7cf466
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/420075/1
--
To view, visit https://review.gerrithub.io/420075
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id396209e1f3526861118641485ff61c5fd7cf466
Gerrit-Change-Number: 420075
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: FSAL_MEM - Convert dirent tracking to refcount
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420074
Change subject: FSAL_MEM - Convert dirent tracking to refcount
......................................................................
FSAL_MEM - Convert dirent tracking to refcount
Dirents had an implicit refcount on their handle because the handle
could not be removed until the list of dirents pointing at it was empty.
Convert this to dirents taking an explicit ref on the handle they point
to, as this is simpler and less accident prone.
Change-Id: I36ce964f5e68bcec690dc3cdcbd90e1fcc838a24
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/420074/1
--
To view, visit https://review.gerrithub.io/420074
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36ce964f5e68bcec690dc3cdcbd90e1fcc838a24
Gerrit-Change-Number: 420074
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months
Change in ffilz/nfs-ganesha[next]: FSAL_MEM - Fix broken readahead limit
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420073
Change subject: FSAL_MEM - Fix broken readahead limit
......................................................................
FSAL_MEM - Fix broken readahead limit
In commit 001940e0, an attempt was made to limit readahead to 1 extra
chunk. However, it had 2 problems: first, it broke directories larger
than 2 chunks. The fix is to properly set EOF. Second, it actually did
a readahead of 2 * chunks + 1. Fix that off-by-one.
Change-Id: Ib03177cbd91040a6c9047ba879c399e7eb4dbdaa
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/420073/1
--
To view, visit https://review.gerrithub.io/420073
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib03177cbd91040a6c9047ba879c399e7eb4dbdaa
Gerrit-Change-Number: 420073
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 9 months