Change in ffilz/nfs-ganesha[next]: FSAL_VFS: fix return value in vfs_open2
by GerritHub
From <fatih(a)gandi.net>:
fatih(a)gandi.net has uploaded this change for review. ( https://review.gerrithub.io/422634
Change subject: FSAL_VFS: fix return value in vfs_open2
......................................................................
FSAL_VFS: fix return value in vfs_open2
If set/getattr fails when handling O_EXCL, vfs_open2 still
returns successfully; then it causes NULL ptr dereference
when called from FSAL_MDCACHE since it is expecting
a valid sub_handle pointer.
Change-Id: I3da9a53c70ab6645905411948e8cb41c33cb9e11
Signed-off-by: Fatih Acar <fatih.acar(a)gandi.net>
---
M src/FSAL/FSAL_VFS/file.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/422634/1
--
To view, visit https://review.gerrithub.io/422634
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3da9a53c70ab6645905411948e8cb41c33cb9e11
Gerrit-Change-Number: 422634
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <fatih(a)gandi.net>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: Skip mounted files when populating POSIX filesystems
by GerritHub
From Matthew Wong <mawong(a)redhat.com>:
Matthew Wong has uploaded this change for review. ( https://review.gerrithub.io/422589
Change subject: Skip mounted files when populating POSIX filesystems
......................................................................
Skip mounted files when populating POSIX filesystems
Change-Id: Ida7a478fbc7ca079bed67cf6b160778518e8eb04
Signed-off-by: Matthew Wong <mawong(a)redhat.com>
---
M src/FSAL/commonlib.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/89/422589/1
--
To view, visit https://review.gerrithub.io/422589
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida7a478fbc7ca079bed67cf6b160778518e8eb04
Gerrit-Change-Number: 422589
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Wong <mawong(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Use correct DQ macro
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/422581
Change subject: MDCACHE - Use correct DQ macro
......................................................................
MDCACHE - Use correct DQ macro
The chunk code was using LRU_DQ_SAFE() when it should have been using
CHUNK_LRU_DQ_SAFEs(). This could have messed up iterators.
Fixes issue #328
Change-Id: I5236e82b7c64084b3ea65412121cf4948e2ff5af
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/422581/1
--
To view, visit https://review.gerrithub.io/422581
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5236e82b7c64084b3ea65412121cf4948e2ff5af
Gerrit-Change-Number: 422581
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: FSAL: consolidate is_referral routines
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/422547
Change subject: FSAL: consolidate is_referral routines
......................................................................
FSAL: consolidate is_referral routines
The VFS and GPFS is_referral routines are identical. Consolidate them
into common code.
Change-Id: Ie65f52c01285387337ae18b42085e67f2ea1a696
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_GPFS/handle.c
M src/FSAL/FSAL_VFS/handle.c
M src/FSAL/commonlib.c
M src/include/FSAL/fsal_commonlib.h
4 files changed, 45 insertions(+), 61 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/422547/1
--
To view, visit https://review.gerrithub.io/422547
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie65f52c01285387337ae18b42085e67f2ea1a696
Gerrit-Change-Number: 422547
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: GPFS_FSAL:Make use of proper close routine
by GerritHub
From Sachin Punadikar <psachin(a)in.ibm.com>:
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/422532
Change subject: GPFS_FSAL:Make use of proper close routine
......................................................................
GPFS_FSAL:Make use of proper close routine
In GPFS FSAL specific code, at certain places, file gets opened via
GPFS code, but close is via generic close call. Such open needs to
be handled by GPFS close "fsal_internal_close".
Change-Id: I062259dfa3705affc8bf576c4c9eebb9b222f507
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/FSAL/FSAL_GPFS/fsal_lookup.c
M src/FSAL/FSAL_GPFS/handle.c
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/422532/1
--
To view, visit https://review.gerrithub.io/422532
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I062259dfa3705affc8bf576c4c9eebb9b222f507
Gerrit-Change-Number: 422532
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: GPFS_FSAL:Print inode in failure cases
by GerritHub
From Sachin Punadikar <psachin(a)in.ibm.com>:
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/422531
Change subject: GPFS_FSAL:Print inode in failure cases
......................................................................
GPFS_FSAL:Print inode in failure cases
In case of operation failure, printing inode number in Ganesha
log file, comes handy. This helps in faster RCA.
Change-Id: I58f22c669604fd67e506efc327b560d31b5c7c52
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/FSAL/FSAL_GPFS/file.c
M src/FSAL/FSAL_GPFS/handle.c
2 files changed, 64 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/422531/1
--
To view, visit https://review.gerrithub.io/422531
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58f22c669604fd67e506efc327b560d31b5c7c52
Gerrit-Change-Number: 422531
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: GPFS_FSAL:Ensure fd value is more than 2
by GerritHub
From Sachin Punadikar <psachin(a)in.ibm.com>:
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/422530
Change subject: GPFS_FSAL:Ensure fd value is more than 2
......................................................................
GPFS_FSAL:Ensure fd value is more than 2
In GPFS code, if the fd is less than 3, then EBADF is returned.
Corrected Ganesha code in GPFS_FSAL to ensure the fd value is not
less than 3.
Change-Id: I2978c2bfea593e030d0ef678cb34879be7e96e74
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/FSAL/FSAL_GPFS/file.c
M src/FSAL/FSAL_GPFS/fsal_internal.c
M src/FSAL/FSAL_GPFS/handle.c
3 files changed, 19 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/422530/1
--
To view, visit https://review.gerrithub.io/422530
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2978c2bfea593e030d0ef678cb34879be7e96e74
Gerrit-Change-Number: 422530
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: FSAL_CEPH: add ceph_ prefixes to some operations
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/422350
Change subject: FSAL_CEPH: add ceph_ prefixes to some operations
......................................................................
FSAL_CEPH: add ceph_ prefixes to some operations
Give them distinct names to make them easier to ID.
Change-Id: I5246015e4aa465769ea06876cba2a3c24fe7cc03
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/handle.c
1 file changed, 19 insertions(+), 16 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/422350/1
--
To view, visit https://review.gerrithub.io/422350
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5246015e4aa465769ea06876cba2a3c24fe7cc03
Gerrit-Change-Number: 422350
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: abstract_mem: add gsh_memdup
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/422322
Change subject: abstract_mem: add gsh_memdup
......................................................................
abstract_mem: add gsh_memdup
For copying a blob of memory of a given length.
Change-Id: I077d63df2985c7d81d3ee14c97a21e1b35dc089d
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/include/abstract_mem.h
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/422322/1
--
To view, visit https://review.gerrithub.io/422322
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I077d63df2985c7d81d3ee14c97a21e1b35dc089d
Gerrit-Change-Number: 422322
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: FSAL: make fsal_fs_locations_t.server an array of hosts
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/422302
Change subject: FSAL: make fsal_fs_locations_t.server an array of hosts
......................................................................
FSAL: make fsal_fs_locations_t.server an array of hosts
Add a flexarray at the end of fsal_fs_locations_t to hold an array of
utf8string structs. For now, we assume that the rootpath on all of them
is the same.
Change nfs4_fs_locations_new to take a server count and allocate a
structure that's the right length for the array. The callers then
populate the array with the appropriate info, which is then passed
directly to the encoder.
Change-Id: Iffdc6e90aacbce58eefe066d06641af07f370553
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_GPFS/handle.c
M src/FSAL/FSAL_VFS/handle.c
M src/FSAL/FSAL_VFS/subfsal_helpers.c
M src/Protocols/NFS/nfs_proto_tools.c
M src/include/fsal_types.h
M src/include/nfs4_fs_locations.h
M src/support/nfs4_fs_locations.c
7 files changed, 43 insertions(+), 36 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/422302/1
--
To view, visit https://review.gerrithub.io/422302
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffdc6e90aacbce58eefe066d06641af07f370553
Gerrit-Change-Number: 422302
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 8 months