Change in ffilz/nfs-ganesha[next]: FSAL_MDCACHE: avoid assertion due to wrong check
by GerritHub
From <fatih(a)gandi.net>:
fatih(a)gandi.net has uploaded this change for review. ( https://review.gerrithub.io/422269
Change subject: FSAL_MDCACHE: avoid assertion due to wrong check
......................................................................
FSAL_MDCACHE: avoid assertion due to wrong check
the check for op_ctx looks wrong
it should get the export from first_export_id if either:
- op_ctx is NULL or op_ctx->ctx_export is NULL
- ctx_export->export_id != first_export_id
otherwise we may hit one of the assertions below
we hit "assert(op_ctx->ctx_export);" while running ganesha
Change-Id: I378362ec777fa690ce63515ca1bc13bf1c9c128d
Signed-off-by: Fatih Acar <fatih.acar(a)gandi.net>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/422269/1
--
To view, visit https://review.gerrithub.io/422269
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I378362ec777fa690ce63515ca1bc13bf1c9c128d
Gerrit-Change-Number: 422269
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <fatih(a)gandi.net>
5 years, 8 months
coverity scan upgrade
by Kaleb S. KEITHLEY
It appears that the coverity scan has been broken for the past 2-3 weeks
due to getting out of sync with required dependencies.
Independent of that I've (re)hosted the coverity scan to a Fedora 28 box
(from Fedora 27) and have addressed the dependency issues and the scan
is working again and the latest is at
https://download.nfs-ganesha.org/coverity/2018-08-13-4912afc6/
Just FYI
--
Kaleb
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: NFS: properly handle NULL fs_locations pointer
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/422099
Change subject: NFS: properly handle NULL fs_locations pointer
......................................................................
NFS: properly handle NULL fs_locations pointer
RFC5661, section 11.9:
When the fs_locations attribute is interrogated and there are no
alternate file system locations, the server SHOULD return a zero-
length array of fs_location4 structures, together with a valid
fs_root.
If we have a NULL fs_locations pointer, we currently fill in a
structure with a bunch of "not supported" strings. Change the code
to handle it more in line with what the spec suggests.
There is one wrinkle here, which is that if we don't have an
fs_locations structure, then we also don't have an fs_root. In that
case, just assume that the entire export has gone away and set the
fs_root to the pseudopath of the export.
Change-Id: I11e4db806dcbf3c853b066b5a97f950c57ec66c1
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs_proto_tools.c
1 file changed, 16 insertions(+), 18 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/422099/1
--
To view, visit https://review.gerrithub.io/422099
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11e4db806dcbf3c853b066b5a97f950c57ec66c1
Gerrit-Change-Number: 422099
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: FSAL: reach into op_ctx->ctx_export to get fs_root for fs_locations
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/422010
Change subject: FSAL: reach into op_ctx->ctx_export to get fs_root for fs_locations
......................................................................
FSAL: reach into op_ctx->ctx_export to get fs_root for fs_locations
Currently, the FSAL populates a field in the fs_locations structure,
but that seems cumbersome and somewhat of a layering violation.
The op_ctx should have a record of the export, so we can just reach
into there and grab the pseudoroot.
While we're at it, fix the case where we don't have fs_locations
structure. RFC5661 says:
When the fs_locations attribute is interrogated and there are no
alternate file system locations, the server SHOULD return a zero-
length array of fs_location4 structures, together with a valid
fs_root.
Now that we get fs_root from the export, we can handle this case.
This allows us to remove a large chunk of pretty nasty code in
FSAL_VFS, which tried to replace components of the pathname with
the pseudoroot.
None of that is necessary. fs_locations is about the export, not a
particular path in it. We tell the client what the root of the export
is locally, and the root of the export on the other servers, and it
handles the rest of the path inside the export.
Change-Id: I667b1e37eefe09c4bbbe6784db2f98c19b209ec1
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_GPFS/handle.c
M src/FSAL/FSAL_VFS/subfsal_helpers.c
M src/Protocols/NFS/nfs_proto_tools.c
M src/include/fsal_types.h
M src/include/nfs4_fs_locations.h
M src/support/nfs4_fs_locations.c
6 files changed, 17 insertions(+), 91 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/422010/1
--
To view, visit https://review.gerrithub.io/422010
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I667b1e37eefe09c4bbbe6784db2f98c19b209ec1
Gerrit-Change-Number: 422010
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 8 months
Announce Push of V2.7-rc1
by Frank Filz
Branch next
Tag:V2.7-rc1
NOTE: This merge contains an ntirpc pullup, please make sure you update your
submodule.
Release Highlights
* Pullup to ntirpc 1.7.0_rc1
* Various fixes and simplifications of fs_locations attribute handling
* Various stats including enable/disable with reset on disable
* FSAL_MEM - Don't try to merge a handle with itself
* State - Add a state_hdl cleanup function
* NFS 4.0 - Fix auth setup error handling
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
4912afc Frank S. Filz V2.7-rc1
a94fcf1 Daniel Gryniewicz NFS 4.0 - Fix auth setup error handling
67211f6 Daniel Gryniewicz Pullup to ntirpc 1.7.0_rc1
2794a20 Daniel Gryniewicz State - Add a state_hdl cleanup function
6befc38 Daniel Gryniewicz FSAL_MEM - Don't try to merge a handle with itself
df003f1 Sachin Punadikar Reset stats counters on disabling
0f53f33 Sachin Punadikar Provision for status in ganesha_stats
278a41a Sachin Punadikar Event log for statistics activity
283afca Sachin Punadikar Display GPFS FSAL response time in milliseconds
719c81f Sachin Punadikar Fix various issues in GPFS_FSAL stats
9f87249 Jeff Layton FSAL: more encode_fs_locations cleanup
b9e4596 Jeff Layton FSAL: track server as utf8string in fsal_fs_locations_t
94c7b74 Jeff Layton fs_locations: split location field into server and
rootpath strings
137f9fa Jeff Layton FSAL: replace handle_is operation with common inline
541378c Jeff Layton NFS: rename fsal_fs_locations_t->path to ->fs_root
4fddde5 Jeff Layton GPFS: rename root_path to fs_root in getattrs
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: FSAL: more encode_fs_locations cleanup
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/421933
Change subject: FSAL: more encode_fs_locations cleanup
......................................................................
FSAL: more encode_fs_locations cleanup
Drop some unnecessary buffers from the stack, eliminate some unneeded
allocs and frees. Set up the structures once instead of overwriting
them multiple times.
Change-Id: I438e6536bac6a9bdf46ef33111022dea427c358e
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs_proto_tools.c
1 file changed, 17 insertions(+), 34 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/421933/1
--
To view, visit https://review.gerrithub.io/421933
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I438e6536bac6a9bdf46ef33111022dea427c358e
Gerrit-Change-Number: 421933
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: NFS 4.0 - Fix auth setup error handling
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/421932
Change subject: NFS 4.0 - Fix auth setup error handling
......................................................................
NFS 4.0 - Fix auth setup error handling
In ntirpc 1.7, auth error handling was changed to return error codes in
a dummy auth object. However, gss code could return without one set
on error, causing crashes.
Add correct error handling to this code.
Change-Id: Id33c714643634d53d0830f6d2ce36bfe48d2d078
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/MainNFSD/nfs_rpc_callback.c
M src/MainNFSD/nfs_rpc_callback_simulator.c
2 files changed, 41 insertions(+), 13 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/421932/1
--
To view, visit https://review.gerrithub.io/421932
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id33c714643634d53d0830f6d2ce36bfe48d2d078
Gerrit-Change-Number: 421932
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: Pullup to ntirpc 1.7.0_rc1
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/421931
Change subject: Pullup to ntirpc 1.7.0_rc1
......................................................................
Pullup to ntirpc 1.7.0_rc1
Change-Id: I64c28d1ed443832191b4b2560c5d4aa4fe4468d0
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/libntirpc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/421931/1
--
To view, visit https://review.gerrithub.io/421931
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64c28d1ed443832191b4b2560c5d4aa4fe4468d0
Gerrit-Change-Number: 421931
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 8 months
