Change in ffilz/nfs-ganesha[next]: FSAL_MDCACHE: always lookup newname from uncached
by GerritHub
From Kinglong Mee <kinglongmee(a)gmail.com>:
Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/421207
Change subject: FSAL_MDCACHE: always lookup newname from uncached
......................................................................
FSAL_MDCACHE: always lookup newname from uncached
When the parent mdcache entry has been invalidated, then newname mdcache
entry is exist but is not linked (without mdcache_dir_entry_t).
Mdcache rename lookup newname from the cache cannot find the mdcache entry.
After that, the mdcache entry will be move to lru L2 list at lru_run,
and exist until the lru_state.entries_used reachs lru_state.entries_hiwat.
As that, the newname mdcache entry should be removed after rename success,
but it is left.
Change-Id: I3eca8f1c5fecaf18fb134448c35c863118331ca5
Signed-off-by: Kinglong Mee <kinglongmee(a)gmail.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/421207/1
--
To view, visit https://review.gerrithub.io/421207
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eca8f1c5fecaf18fb134448c35c863118331ca5
Gerrit-Change-Number: 421207
Gerrit-PatchSet: 1
Gerrit-Owner: Kinglong Mee <kinglongmee(a)gmail.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER: set acl without SET_GLUSTER_CREDS
by GerritHub
From Kinglong Mee <kinglongmee(a)gmail.com>:
Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/421206
Change subject: FSAL_GLUSTER: set acl without SET_GLUSTER_CREDS
......................................................................
FSAL_GLUSTER: set acl without SET_GLUSTER_CREDS
A case as setattr with ACL but without MODE,
gluster code sets MODE to 0 before setting acl.
For non-root user, the following acl setting failed as EACCESS.
Change-Id: I2c8d890e82348d7e6b458b789af72d5039456fa1
Signed-off-by: Kinglong Mee <kinglongmee(a)gmail.com>
---
M src/FSAL/FSAL_GLUSTER/handle.c
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/421206/1
--
To view, visit https://review.gerrithub.io/421206
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c8d890e82348d7e6b458b789af72d5039456fa1
Gerrit-Change-Number: 421206
Gerrit-PatchSet: 1
Gerrit-Owner: Kinglong Mee <kinglongmee(a)gmail.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: 9P xattrcreate: clear fid->xattr on error
by GerritHub
From Dominique Martinet <asmadeus(a)codewreck.org>:
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/421067
Change subject: 9P xattrcreate: clear fid->xattr on error
......................................................................
9P xattrcreate: clear fid->xattr on error
clunk would attempt to free pfid->xattr again if it was still set,
leading to double-free and memory corruption
Change-Id: Ic31282a8f3f24d612170e3e6cf31452c5d28ce10
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/Protocols/9P/9p_xattrcreate.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/421067/1
--
To view, visit https://review.gerrithub.io/421067
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic31282a8f3f24d612170e3e6cf31452c5d28ce10
Gerrit-Change-Number: 421067
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: GPFS: Convert some memory allocation to using memory pools
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/421053
Change subject: GPFS: Convert some memory allocation to using memory pools
......................................................................
GPFS: Convert some memory allocation to using memory pools
Change-Id: I96a218c4df76a88f7bd45a66ff206548905e6822
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_GPFS/export.c
M src/FSAL/FSAL_GPFS/fsal_ds.c
M src/FSAL/FSAL_GPFS/fsal_internal.h
M src/FSAL/FSAL_GPFS/handle.c
M src/FSAL/FSAL_GPFS/main.c
5 files changed, 33 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/421053/1
--
To view, visit https://review.gerrithub.io/421053
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96a218c4df76a88f7bd45a66ff206548905e6822
Gerrit-Change-Number: 421053
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: GLUSTER: Convert some memory allocations to using memory pools
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/421052
Change subject: GLUSTER: Convert some memory allocations to using memory pools
......................................................................
GLUSTER: Convert some memory allocations to using memory pools
Change-Id: I00cb94a8e756b8a31fe08345dbd444b4ff8b8bc4
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_GLUSTER/ds.c
M src/FSAL/FSAL_GLUSTER/export.c
M src/FSAL/FSAL_GLUSTER/gluster_internal.c
M src/FSAL/FSAL_GLUSTER/gluster_internal.h
M src/FSAL/FSAL_GLUSTER/handle.c
M src/FSAL/FSAL_GLUSTER/main.c
6 files changed, 33 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/421052/1
--
To view, visit https://review.gerrithub.io/421052
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00cb94a8e756b8a31fe08345dbd444b4ff8b8bc4
Gerrit-Change-Number: 421052
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: CEPH: Convert allocations to use memory pools
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/421051
Change subject: CEPH: Convert allocations to use memory pools
......................................................................
CEPH: Convert allocations to use memory pools
Change-Id: I3ac0a5804d26319c31f729bcfe012e22dbd6ff2c
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_CEPH/ds.c
M src/FSAL/FSAL_CEPH/export.c
M src/FSAL/FSAL_CEPH/handle.c
M src/FSAL/FSAL_CEPH/internal.c
M src/FSAL/FSAL_CEPH/internal.h
M src/FSAL/FSAL_CEPH/main.c
6 files changed, 41 insertions(+), 10 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/421051/1
--
To view, visit https://review.gerrithub.io/421051
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ac0a5804d26319c31f729bcfe012e22dbd6ff2c
Gerrit-Change-Number: 421051
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: Clean up memory pool comments
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/421050
Change subject: Clean up memory pool comments
......................................................................
Clean up memory pool comments
Change-Id: I0d63bc83156549c7e5411f7af6ca16e61d919fce
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/include/abstract_mem.h
1 file changed, 3 insertions(+), 22 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/421050/1
--
To view, visit https://review.gerrithub.io/421050
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d63bc83156549c7e5411f7af6ca16e61d919fce
Gerrit-Change-Number: 421050
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: Add ability to allocate an array of pool objects
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/421049
Change subject: Add ability to allocate an array of pool objects
......................................................................
Add ability to allocate an array of pool objects
Change-Id: I748f76d70177d2007eb3839f5d4c3de1acc11059
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/include/abstract_mem.h
1 file changed, 51 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/421049/1
--
To view, visit https://review.gerrithub.io/421049
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I748f76d70177d2007eb3839f5d4c3de1acc11059
Gerrit-Change-Number: 421049
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 8 months
Change in ffilz/nfs-ganesha[next]: Add memory pools for variable sized objects
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/421048
Change subject: Add memory pools for variable sized objects
......................................................................
Add memory pools for variable sized objects
Change-Id: I25d9a986bfeb10bdc95d4011eb269813dc6fd4f7
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/include/abstract_mem.h
M src/support/server_stats.c
2 files changed, 160 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/421048/1
--
To view, visit https://review.gerrithub.io/421048
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25d9a986bfeb10bdc95d4011eb269813dc6fd4f7
Gerrit-Change-Number: 421048
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 8 months
Fwd: Connection to V4 port gets closed soon after it is established.
by Pradeep
Hi Bill,
I'm seeing a case where the client establishes a connection and sends V4
NULL request. But before ganesha processes it, the socket is closed by
TIRPC. Here is the TIRPC logs I captured. The FD 38, xprt: 0x7fbcd5b71400
is what gets destroyed soon after creation.
Any idea on why? I'm using ganesha version 2.6.5 and TIRPC 1.6.1. I can see
the same in a tcpdump. This seems to be happening with kerberos where
rpc.gssd from client talks to ganesha for authentication.
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :makefd_xprt() 0x7fbcd5b71400 fd 38 xp_refs 1 af 0 port
4294967295 @ makefd_xprt:347
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_vc_rendezvous() 0x7fbcd5b71400 fd 38 xp_refs 1 af 10
port 44988 @ svc_vc_rendezvous:469
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_ref_it() 0x7fbce2455800 fd 15 xp_refs 4 af 0 port
4294967295 @ svc_vc_rendezvous:500
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
nfs_rpc_dispatch_tcp_NFS :DISP :F_DBG :NFS TCP request on SVCXPRT
0x7fbcd5b71400 fd 38
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_rqst_evchan_reg:648 locking
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_rqst_hook_events: 0x7fbcd5b71400 fd 38 xp_refs 1
sr_rec 0x7fbce24eeb10 evchan 1 refcnt 4 epoll_fd 27 control fd pair (25:26)
hook
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :ev_sig: fd 25 sig 0
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_rqst_evchan_reg:671 unlocking
@svc_rqst_evchan_reg:648
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_release_it() 0x7fbce2455800 fd 15 xp_refs 3 af 0
port 4294967295 @ svc_rqst_xprt_task:754
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_17]
rpc :TIRPC :F_DBG :svc_rqst_epoll_event: fd 26 wakeup (sr_rec
0x7fbce24eeb10)
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_destroy_it() 0x7fbcd5b71400 fd 38 xp_refs 1 af 10
port 44988 @ svc_rqst_clean_func:781
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_17]
rpc :TIRPC :F_DBG :svc_rqst_epoll_event: fd 26 after consume sig (sr_rec
0x7fbce24eeb10)
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_rqst_xprt_unregister:723 locking
131/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_17]
rpc :TIRPC :F_DBG :svc_rqst_epoll_loop: epoll_fd 27 before epoll_wait
(29000)
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_rqst_unhook_events: 0x7fbcd5b71400 fd 38 xp_refs 0
sr_rec 0x7fbce24eeb10 evchan 1 refcnt 4 epoll_fd 27 control fd pair (25:26)
unhook
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_rqst_xprt_unregister:733 unlocking
@svc_rqst_xprt_unregister:723
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :svc_vc_destroy_it() 0x7fbcd5b71400 fd 38 xp_refs 0
should actually destroy things @ svc_rqst_clean_func:781
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_16]
rpc :TIRPC :F_DBG :work_pool_thread() svc_16 waiting
31/07/2018 12:17:16 : epoch 5b5fa0dc : testvm : nfs-ganesha-11564[svc_22]
rpc :TIRPC :F_DBG :work_pool_thread() svc_22 task 0x7fbcd5b71618
5 years, 8 months