September 2018 - Devel - NFS Ganesha List Archives

Change in ffilz/nfs-ganesha[next]: Don't mix NFS4ERR_ATTRNOTSUPP and NFS4ERR_NOTSUPP
by GerritHub 27 Sep '18

27 Sep '18

From Malahal <malahal(a)gmail.com>: Malahal has uploaded this change for review. ( https://review.gerrithub.io/427137 Change subject: Don't mix NFS4ERR_ATTRNOTSUPP and NFS4ERR_NOTSUPP ...................................................................... Don't mix NFS4ERR_ATTRNOTSUPP and NFS4ERR_NOTSUPP The following pynfs test passes after this fix! GATT8 st_getattr.testFSLocations : FAILURE GETATTR(fs_locations) should return NFS4_OK or NFS4ERR_ATTRNOTSUPP, instead got NFS4ERR_NOTSUPP Change-Id: I1bca086037516b24cea61b0f98ddaff289488790 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/support/nfs_convert.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/427137/1 -- To view, visit https://review.gerrithub.io/427137 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I1bca086037516b24cea61b0f98ddaff289488790 Gerrit-Change-Number: 427137 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com>

1 0

Change in ffilz/nfs-ganesha[next]: [GPFS] assert file descriptor value only on a success!
by GerritHub 27 Sep '18

27 Sep '18

From Malahal <malahal(a)gmail.com>: Malahal has uploaded this change for review. ( https://review.gerrithub.io/427136 Change subject: [GPFS] assert file descriptor value only on a success! ...................................................................... [GPFS] assert file descriptor value only on a success! Change-Id: I87df61fc948f1c7ae262b85539e4761e89b69bc7 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/FSAL_GPFS/file.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/427136/1 -- To view, visit https://review.gerrithub.io/427136 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I87df61fc948f1c7ae262b85539e4761e89b69bc7 Gerrit-Change-Number: 427136 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com>

1 0

Change in ffilz/nfs-ganesha[next]: [GPFS] Fix gpfs fs locations crash
by GerritHub 27 Sep '18

27 Sep '18

From Malahal <malahal(a)gmail.com>: Malahal has uploaded this change for review. ( https://review.gerrithub.io/427135 Change subject: [GPFS] Fix gpfs fs locations crash ...................................................................... [GPFS] Fix gpfs fs locations crash GPFSFSAL_fs_loc() expects its last argument to be initilaized with buffers. It is currently passed with zeros resulting in a crash. Made GPFSFSAL_fs_loc to take attributes as an argument and fs_locations gets initialized on a successful return. Change-Id: I3554b3520b8bdf8924b53a2e8d24caffbd16e601 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/FSAL_GPFS/fsal_attrs.c M src/FSAL/FSAL_GPFS/fsal_internal.h M src/FSAL/FSAL_GPFS/handle.c 3 files changed, 31 insertions(+), 55 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/427135/1 -- To view, visit https://review.gerrithub.io/427135 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I3554b3520b8bdf8924b53a2e8d24caffbd16e601 Gerrit-Change-Number: 427135 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com>

1 0

Change in ffilz/nfs-ganesha[next]: FSAL_UP: fix op_ctx handling in delegrecall functions
by GerritHub 27 Sep '18

27 Sep '18

From <fatih(a)gandi.net>: fatih(a)gandi.net has uploaded this change for review. ( https://review.gerrithub.io/427101 Change subject: FSAL_UP: fix op_ctx handling in delegrecall functions ...................................................................... FSAL_UP: fix op_ctx handling in delegrecall functions This commit completes 6a40d174596d. delegrecall_completion_func and delegrevoke_check also call dec_state_t_ref which requires a valid op_ctx, but op_ctx may be NULL if the file is stale. Apply the same fix as 6a40d174596d. Fixes: 81caa34f9aca (set op_ctx during deleg revokes and recalls) Change-Id: I6546f80848166d48188a7ab44a8b462fe9f8cd13 Signed-off-by: Fatih Acar <fatih.acar(a)gandi.net> --- M src/FSAL_UP/fsal_up_top.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/427101/1 -- To view, visit https://review.gerrithub.io/427101 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I6546f80848166d48188a7ab44a8b462fe9f8cd13 Gerrit-Change-Number: 427101 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <fatih(a)gandi.net>

1 0

could we enable libasan on the CEA builds?
by Jeff Layton 27 Sep '18

27 Sep '18

Hi Patrice, I believe you handle the CEA tests that get run automatically when we submit ganesha patches for review? We've seen some crashes recently with what look like malloc arena corruption. This one, for instance: https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/426925 Would it be possible to enable libasan for these builds? ASAN would help us get a good handle on what's happening there. There is a small performance penalty in using it, but it would help us collect useful info when ganesha crashes with memory issues. I think that's probably worth it for this sort of testing. If it sounds ok to you, it should be pretty simple. To do it, you just need to make sure that libasan is installed on the machine, and then pass -DSANITIZE_ADDRESS=ON to the cmake command. libasan will also need to be installed on the host where the daemon runs as well. Thanks! -- Jeff Layton <jlayton(a)redhat.com>

2 3

Change in ffilz/nfs-ganesha[next]: FSAL_VFS: Implement fallocate method for ALLOCATE and DEALLOCATE ops
by GerritHub 26 Sep '18

26 Sep '18

From Frank Filz <ffilzlnx(a)mindspring.com>: Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/427006 Change subject: FSAL_VFS: Implement fallocate method for ALLOCATE and DEALLOCATE ops ...................................................................... FSAL_VFS: Implement fallocate method for ALLOCATE and DEALLOCATE ops Change-Id: I4a2cb60e70789e4f9e8920f98995683e81e10c9b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/vfs_methods.h 3 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/427006/1 -- To view, visit https://review.gerrithub.io/427006 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I4a2cb60e70789e4f9e8920f98995683e81e10c9b Gerrit-Change-Number: 427006 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

Change in ffilz/nfs-ganesha[next]: FSAL_VFS: Add seek2 method
by GerritHub 26 Sep '18

26 Sep '18

From Frank Filz <ffilzlnx(a)mindspring.com>: Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/427005 Change subject: FSAL_VFS: Add seek2 method ...................................................................... FSAL_VFS: Add seek2 method Change-Id: I56840addb78031e42cf37a91b8114ce41822889c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/vfs_methods.h 3 files changed, 98 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/427005/1 -- To view, visit https://review.gerrithub.io/427005 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I56840addb78031e42cf37a91b8114ce41822889c Gerrit-Change-Number: 427005 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

Change in ffilz/nfs-ganesha[next]: Fix ERR_FSAL_UNION_NOTSUPP to match V4.2 RFC
by GerritHub 26 Sep '18

26 Sep '18

From Frank Filz <ffilzlnx(a)mindspring.com>: Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/427004 Change subject: Fix ERR_FSAL_UNION_NOTSUPP to match V4.2 RFC ...................................................................... Fix ERR_FSAL_UNION_NOTSUPP to match V4.2 RFC Change-Id: Ib7107bade6edfbd15a0c05cbd06e412bcb120530 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/fsal_types.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/427004/1 -- To view, visit https://review.gerrithub.io/427004 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7107bade6edfbd15a0c05cbd06e412bcb120530 Gerrit-Change-Number: 427004 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

Change in ffilz/nfs-ganesha[next]: Put NFSv4 Tag into compound_data_t so it can be used in log messages
by GerritHub 26 Sep '18

26 Sep '18

From Frank Filz <ffilzlnx(a)mindspring.com>: Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/427003 Change subject: Put NFSv4 Tag into compound_data_t so it can be used in log messages ...................................................................... Put NFSv4 Tag into compound_data_t so it can be used in log messages Change-Id: I0776fdc9ecab007e309adf4cf6b899ce80db9d8a Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_create_session.c M src/include/nfs_proto_data.h 3 files changed, 22 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/427003/1 -- To view, visit https://review.gerrithub.io/427003 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I0776fdc9ecab007e309adf4cf6b899ce80db9d8a Gerrit-Change-Number: 427003 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

This seems to hang on my system with the latest Ganesha2.7
by Malahal Naineni 26 Sep '18

26 Sep '18

Why would this hang? (gdb) thread 36 [Switching to thread 36 (Thread 0x7ff5e593e700 (LWP 15778))] #0 0x00007ff5eac0d74d in open_by_handle_at () at ../sysdeps/unix/syscall-template.S:81 81 T_PSEUDO (SYSCALL_SYMBOL, SYSCALL_NAME, SYSCALL_NARGS) (gdb) bt #0 0x00007ff5eac0d74d in open_by_handle_at () at ../sysdeps/unix/syscall-template.S:81 #1 0x00007ff5e635eed6 in vfs_open_by_handle (vfs_fs=0x2146600, fh=0x7ff5c0002800, openflags=65536, fsal_error=0x7ff5e5939e8c) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/FSAL_VFS/os/linux/handle_syscalls.c:315 #2 0x00007ff5e634f417 in vfs_fsal_open (hdl=0x7ff5c00026f0, openflags=65536, fsal_error=0x7ff5e5939e8c) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/FSAL_VFS/handle.c:63 #3 0x00007ff5e635d29e in vfs_get_fs_locations (hdl=0x7ff5c00026f0, attrs_out=0x7ff5e593c140) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/FSAL_VFS/subfsal_helpers.c:57 #4 0x00007ff5e635d890 in vfs_sub_getattrs (vfs_hdl=0x7ff5c00026f0, fd=45, request_mask=9223372036864597966, attrib=0x7ff5e593c140) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/FSAL_VFS/vfs/attrs.c:136 #5 0x00007ff5e6355d65 in fetch_attrs (myself=0x7ff5c00026f0, my_fd=45, attrs=0x7ff5e593c140) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/FSAL_VFS/file.c:344 #6 0x00007ff5e635a853 in vfs_getattr2 (obj_hdl=0x7ff5c00026f0, attrs=0x7ff5e593c140) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/FSAL_VFS/file.c:1730 #7 0x0000000000544141 in mdcache_refresh_attrs (entry=0x7ff5c0002850, need_acl=true, need_fslocations=true, invalidate=true) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:832 #8 0x000000000054480c in mdcache_getattrs (obj_hdl=0x7ff5c0002888, attrs_out=0x7ff5e593c440) at /usr/src/debug/nfs-ganesha-2.7.0.1/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:899 #9 0x0000000000490591 in file_To_Fattr (data=0x7ff5e593cdf0, request_mask=9822190, attr=0x7ff5e593c440, Fattr=0x7ff5b8043330, Bitmap=0x7ff5b8036398) at /usr/src/debug/nfs-ganesha-2.7.0.1/Protocols/NFS/nfs_proto_tools.c:3490 #10 0x0000000000467de6 in nfs4_op_getattr (op=0x7ff5b8036390, data=0x7ff5e593cdf0, resp=0x7ff5b8043320) at /usr/src/debug/nfs-ganesha-2.7.0.1/Protocols/NFS/nfs4_op_getattr.c:108

2 1