Change in ffilz/nfs-ganesha[next]: specfile: build with libasan support if it was specified during cmake
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/426132
Change subject: specfile: build with libasan support if it was specified during cmake
......................................................................
specfile: build with libasan support if it was specified during cmake
Change-Id: If08020af9ee6feec6c067efd3e566982c42fada8
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/CMakeLists.txt
M src/nfs-ganesha.spec-in.cmake
2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/426132/1
--
To view, visit https://review.gerrithub.io/426132
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: If08020af9ee6feec6c067efd3e566982c42fada8
Gerrit-Change-Number: 426132
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 3 months
Change in ffilz/nfs-ganesha[next]: CMake - allow RGW to be found on debian
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/426111
Change subject: CMake - allow RGW to be found on debian
......................................................................
CMake - allow RGW to be found on debian
Change-Id: I87a034208ea91291856cb9c7ad0363eb938591a1
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/cmake/modules/FindRGW.cmake
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/426111/1
--
To view, visit https://review.gerrithub.io/426111
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87a034208ea91291856cb9c7ad0363eb938591a1
Gerrit-Change-Number: 426111
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 3 months
Change in ffilz/nfs-ganesha[next]: rpm: add lttng-tools-devel as BuildRequires to .spec file
by GerritHub
From Ali Maredia <amaredia(a)redhat.com>:
Ali Maredia has uploaded this change for review. ( https://review.gerrithub.io/426109
Change subject: rpm: add lttng-tools-devel as BuildRequires to .spec file
......................................................................
rpm: add lttng-tools-devel as BuildRequires to .spec file
Change-Id: I7b999869a056713a89ab205a06a394f022c7c13f
Signed-off-by: Ali Maredia <amaredia(a)redhat.com>
---
M src/nfs-ganesha.spec-in.cmake
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/426109/1
--
To view, visit https://review.gerrithub.io/426109
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b999869a056713a89ab205a06a394f022c7c13f
Gerrit-Change-Number: 426109
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Maredia <amaredia(a)redhat.com>
6 years, 3 months
Fwd: Ganesha 2.5, crash /segfault while executing nlm4_Unlock
by Sachin Punadikar
---------- Forwarded message ----------
From: Sachin Punadikar <punadikar.sachin(a)gmail.com>
Date: Tue, Jun 26, 2018 at 3:57 PM
Subject: Ganesha 2.5, crash /segfault while executing nlm4_Unlock
To: nfs-ganesha-devel <nfs-ganesha-devel(a)lists.sourceforge.net>
Hi All,
Recently a crash was reported by customer for Ganesha 2.5.
(gdb) where
#0 0x00007f475872900b in pthread_rwlock_wrlock () from
/lib64/libpthread.so.0
#1 0x000000000041eac9 in fsal_obj_handle_fini (obj=0x7f4378028028) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL/commonlib.c:192
#2 0x000000000053180f in mdcache_lru_clean (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:589
#3 0x0000000000536587 in _mdcache_lru_unref (entry=0x7f4378027ff0,
flags=0, func=0x5a9380 <__func__.23209> "cih_remove_checked", line=406)
at /usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1921
#4 0x0000000000543e91 in cih_remove_checked (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h:406
#5 0x0000000000544b26 in mdc_clean_entry (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:235
#6 0x000000000053181e in mdcache_lru_clean (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:592
#7 0x0000000000536587 in _mdcache_lru_unref (entry=0x7f4378027ff0,
flags=0, func=0x5a70af <__func__.23112> "mdcache_put", line=190)
at /usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1921
#8 0x0000000000539666 in mdcache_put (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h:190
#9 0x000000000053f062 in mdcache_put_ref (obj_hdl=0x7f4378028028) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1709
#10 0x000000000049bf0f in nlm4_Unlock (args=0x7f4294165830,
req=0x7f4294165028, res=0x7f43f001e0e0)
at /usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/Prot
ocols/NLM/nlm_Unlock.c:128
#11 0x000000000044c719 in nfs_rpc_execute (reqdata=0x7f4294165000) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/Main
NFSD/nfs_worker_thread.c:1290
#12 0x000000000044cf23 in worker_run (ctx=0x3c200e0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/Main
NFSD/nfs_worker_thread.c:1562
#13 0x000000000050a3e7 in fridgethr_start_routine (arg=0x3c200e0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/supp
ort/fridgethr.c:550
#14 0x00007f4758725dc5 in start_thread () from /lib64/libpthread.so.0
#15 0x00007f4757de673d in clone () from /lib64/libc.so.6
A closer look at the backtrace indicates that there was cyclic flow of
execution as below:
nlm4_Unlock -> mdcache_put_ref -> mdcache_put -> _mdcache_lru_unref ->
mdcache_lru_clean -> fsal_obj_handle_fini and then mdc_clean_entry ->
cih_remove_checked -> (purposely coping next flow on below line)
-> _mdcache_lru_unref -> mdcache_lru_clean -> fsal_obj_handle_fini
(currently crashing here)
Do we see any code issue here ? Any hints on how to RCA this issue ?
Thanks in advance.
--
with regards,
Sachin Punadikar
--
with regards,
Sachin Punadikar
6 years, 3 months
Change in ffilz/nfs-ganesha[next]: FSAL_CEPH: add flag to mask for setting atime/mtime to server time
by GerritHub
From Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn>:
Zhu Shangzhong has uploaded this change for review. ( https://review.gerrithub.io/426017
Change subject: FSAL_CEPH: add flag to mask for setting atime/mtime to server time
......................................................................
FSAL_CEPH: add flag to mask for setting atime/mtime to server time
Change-Id: I94fc83d5c1cfe2e5fb964ad970353212f8520012
Signed-off-by: Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn>
---
M src/FSAL/FSAL_CEPH/handle.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/426017/1
--
To view, visit https://review.gerrithub.io/426017
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94fc83d5c1cfe2e5fb964ad970353212f8520012
Gerrit-Change-Number: 426017
Gerrit-PatchSet: 1
Gerrit-Owner: Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn>
6 years, 3 months
[NFS-Ganesha-Devel]ceph_fsal_setattr2 returned Operation not permitted
by zhu.shangzhong＠zte.com.cn
How to reproduce:
1. mount the nfs-ganesha export directory with NFSV3
2. create new users: user1 and user2, there is the same user group for user1 and user2
uid=9998(user1) gid=100(users) groups=100(users)
uid=9997(user2) gid=100(users) groups=100(users)
3. log in using user1 and create new file named abc.txt
4. chmod 664 abc.txt
5. log in using user2, and write new content to abc.txt
echo 'Hello' > abc.txt
6. The error "Operation not permitted" will be output
Expected result:
user2 may write data to file abc.txt successfully.
The more detailed info could be found in http://tracker.ceph.com/issues/35961
The issue may be fixed by changing the following code, is it appropriate changes for fixing the issue?
src\FSAL\FSAL_CEPH\handle.c
fsal_status_t ceph_setattr2(struct fsal_obj_handle *obj_hdl, bool bypass, struct state_t *state, struct attrlist *attrib_set)
{
...
if (FSAL_TEST_MASK(attrib_set->valid_mask, ATTR_ATIME_SERVER)) {
struct timespec timestamp;
mask |= CEPH_SETATTR_ATIME; // s/CEPH_SETATTR_ATIME/CEPH_SETATTR_ATIME_NOW
...
if (FSAL_TEST_MASK(attrib_set->valid_mask, ATTR_MTIME_SERVER)) {
struct timespec timestamp;
mask |= CEPH_SETATTR_MTIME; // s/CEPH_SETATTR_MTIME/CEPH_SETATTR_MTIME_NOW
...
}
6 years, 3 months
Announce Push of V2.7.0
by Frank Filz
Branch next
Tag:V2.7.0
This release contains a libntirpc pullup, please refresh your submodule.
Release Highlights
* Some minor fixes in final merge
* Pull up libntirpc 1.7.0
* Support for async I/O operations in the FSALs
* Many bug fixes (many backported to V2.6-stable)
* Strip out legacy dirent cache
* Change dirent AVL tree to index by name instead of hash
* fs_locations fixes
* FSAL_LUSTRE reintroduced, built on FSAL_VFS
* NLM Fixups to allow Windowws NFS client to work
* BIND_CONN_TO_SESSION
* response size tracking
* Only cache NFS v4.1 responses that are requested to be cached
* Grace period enhancements including better cluster grace period handling
* FSAL_GLUSTER implementation of V4.2 SEEK
* Improved V4.2 fallocate operation with Ceph implementation
* MDCACHE imrovements in thread wait and open fd high water mark handling
* Make expire_time_attr settable in EXPORT_DEFAULTS
* Fixed a number of places where op_ctx was not set including in upcalls
* Big expansion of gtest suite with modularity improvements
* Delegation bug fixes
* Close races in export/unexport
* Compilation fixes for FreeBSD
* Implement NFS v4.1 TEST_STATEID
* Stats improvements
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
924ea8b Frank S. Filz V2.7.0
be1060c Frank S. Filz Bump FSAL API major version to 8
9a2dd01 Daniel Gryniewicz Fix default config IPv6 connections
fc7ec37 Daniel Gryniewicz Pull up ntirpc to 1.7.0
eef07bc Daniel Gryniewicz GLUSTER - Disable readdir plus chunk reloading
e97c9f2 Jeff Layton mdcache: mask off ATTR4_FS_LOCATIONS when testing for
requested attrs
839d44d Fatih Acar FSAL_UP: prevent races when doing an async deleg recall
6 years, 3 months
Change in ffilz/nfs-ganesha[next]: mdcache: mask off ATTR4_FS_LOCATIONS when testing for requested attrs
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/425612
Change subject: mdcache: mask off ATTR4_FS_LOCATIONS when testing for requested attrs
......................................................................
mdcache: mask off ATTR4_FS_LOCATIONS when testing for requested attrs
Dan pointed out that this check is wrong if fs_locations were requested.
Change-Id: Ifcb731b420502f7bf867cd56a76a0771839e5dd1
Cc: Daniel Gryniewicz <dang(a)redhat.com>
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/425612/1
--
To view, visit https://review.gerrithub.io/425612
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcb731b420502f7bf867cd56a76a0771839e5dd1
Gerrit-Change-Number: 425612
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-CC: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 3 months
Change in ffilz/nfs-ganesha[next]: FSAL_CEPH: add support for security labels
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/425601
Change subject: FSAL_CEPH: add support for security labels
......................................................................
FSAL_CEPH: add support for security labels
Have FSAL_CEPH set and provide security labels using an xattr. Add a
new export option that specifies the name of the xattr in which
the labels should be stored. The default is security.selinux.
Change-Id: I604cc72942487e12d1dd6376601806bd6f0ffd45
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/handle.c
M src/FSAL/FSAL_CEPH/internal.h
M src/FSAL/FSAL_CEPH/main.c
3 files changed, 55 insertions(+), 12 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/425601/1
--
To view, visit https://review.gerrithub.io/425601
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I604cc72942487e12d1dd6376601806bd6f0ffd45
Gerrit-Change-Number: 425601
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 3 months
Change in ffilz/nfs-ganesha[next]: FSAL_CEPH: add wrapper functions for xattrs
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/425600
Change subject: FSAL_CEPH: add wrapper functions for xattrs
......................................................................
FSAL_CEPH: add wrapper functions for xattrs
Change-Id: Id177dd030585ec31cf088f65571a64144ed55637
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/statx_compat.h
1 file changed, 72 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/425600/1
--
To view, visit https://review.gerrithub.io/425600
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id177dd030585ec31cf088f65571a64144ed55637
Gerrit-Change-Number: 425600
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 3 months