Change in ffilz/nfs-ganesha[next]: Don't define variables in the middle of function
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424863
Change subject: Don't define variables in the middle of function
......................................................................
Don't define variables in the middle of function
Change-Id: Ic57f47a39cc54082fa964b875553ed7057f718fd
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_GLUSTER/handle.c
M src/Protocols/NFS/mnt_Mnt.c
M src/Protocols/NFS/nfs3_fsinfo.c
M src/Protocols/NFS/nfs3_mknod.c
M src/Protocols/NFS/nfs4_op_getfh.c
M src/Protocols/NFS/nfs4_op_secinfo.c
M src/Protocols/NFS/nfs4_op_setattr.c
7 files changed, 12 insertions(+), 14 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/424863/1
--
To view, visit https://review.gerrithub.io/424863
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic57f47a39cc54082fa964b875553ed7057f718fd
Gerrit-Change-Number: 424863
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: hashtable - mark falltrhough to keep coverity happy
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424862
Change subject: hashtable - mark falltrhough to keep coverity happy
......................................................................
hashtable - mark falltrhough to keep coverity happy
Change-Id: I7d080e117f694579d5ddeab6ba1b756c5eb1481a
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/hashtable/hashtable.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/62/424862/1
--
To view, visit https://review.gerrithub.io/424862
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d080e117f694579d5ddeab6ba1b756c5eb1481a
Gerrit-Change-Number: 424862
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: NFS - Unlock, rather than double locking
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424861
Change subject: NFS - Unlock, rather than double locking
......................................................................
NFS - Unlock, rather than double locking
Change-Id: Icb40960d45b0539e36e6d7f484ab51fe407ef5c1
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_layoutreturn.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/424861/1
--
To view, visit https://review.gerrithub.io/424861
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb40960d45b0539e36e6d7f484ab51fe407ef5c1
Gerrit-Change-Number: 424861
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: VFS - Make sure to unlock on failure case
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424860
Change subject: VFS - Make sure to unlock on failure case
......................................................................
VFS - Make sure to unlock on failure case
If find_fd() fails, it was returning with fdlock taken, causing
potential deadlock. Re-arrange so it can use the normal error exit
path.
Change-Id: Ie84458c120b183715208ae643482826abbeb696b
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_VFS/file.c
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/424860/1
--
To view, visit https://review.gerrithub.io/424860
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie84458c120b183715208ae643482826abbeb696b
Gerrit-Change-Number: 424860
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: NFS - Initialize new_state out parameter
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424859
Change subject: NFS - Initialize new_state out parameter
......................................................................
NFS - Initialize new_state out parameter
Change-Id: I4c0a6526eb212ca9764db03ed5ac0b6c923c97c5
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_open.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/424859/1
--
To view, visit https://review.gerrithub.io/424859
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c0a6526eb212ca9764db03ed5ac0b6c923c97c5
Gerrit-Change-Number: 424859
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: NFS - Don't nest locks
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424858
Change subject: NFS - Don't nest locks
......................................................................
NFS - Don't nest locks
nfs_export_get_root_entry() takes the export lock, so don't take it
before that call.
Change-Id: I45f11dd31a6dda68ec8cca1dc807ed562766e6ce
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_lookupp.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/424858/1
--
To view, visit https://review.gerrithub.io/424858
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45f11dd31a6dda68ec8cca1dc807ed562766e6ce
Gerrit-Change-Number: 424858
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Can't check prev_chunk unless right is valid
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424857
Change subject: MDCACHE - Can't check prev_chunk unless right is valid
......................................................................
MDCACHE - Can't check prev_chunk unless right is valid
Change-Id: I7dc92d7ae9f6886236a44bf6b3b363b2be74a850
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
1 file changed, 15 insertions(+), 12 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/424857/1
--
To view, visit https://review.gerrithub.io/424857
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dc92d7ae9f6886236a44bf6b3b363b2be74a850
Gerrit-Change-Number: 424857
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: MEM - Use correct handle for FD
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424856
Change subject: MEM - Use correct handle for FD
......................................................................
MEM - Use correct handle for FD
Change-Id: I8b9110024c639c3013e8cba57f3836f45b7555f2
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/424856/1
--
To view, visit https://review.gerrithub.io/424856
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b9110024c639c3013e8cba57f3836f45b7555f2
Gerrit-Change-Number: 424856
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - set atime, not mtime
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/424855
Change subject: MDCACHE - set atime, not mtime
......................................................................
MDCACHE - set atime, not mtime
Change-Id: Id524c659c806588ecb2417a2133ff6f1226bfe0e
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/424855/1
--
To view, visit https://review.gerrithub.io/424855
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id524c659c806588ecb2417a2133ff6f1226bfe0e
Gerrit-Change-Number: 424855
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 7 months
Change in ffilz/nfs-ganesha[next]: rados_grace: allow lift/remove to proceed if we're not in a grace period
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/424694
Change subject: rados_grace: allow lift/remove to proceed if we're not in a grace period
......................................................................
rados_grace: allow lift/remove to proceed if we're not in a grace period
There's no need to deny a lift operation if we're not in a grace period
in the first place. Doing so also prevents shrinking the cluster when
we're not in a grace period.
Fixes: e3a13410430f rados_cluster: don't lift grace period unless everyone is enforcing
Change-Id: I395c3a970c0511a8628dd1c5c7e74368f76c865c
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/support/rados_grace.c
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/424694/1
--
To view, visit https://review.gerrithub.io/424694
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I395c3a970c0511a8628dd1c5c7e74368f76c865c
Gerrit-Change-Number: 424694
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 7 months