November 2019 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Avoid twice free.
by xijinyu (GerritHub) 11 Nov '19

11 Nov '19

xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473844 ) Change subject: Avoid twice free. ...................................................................... Avoid twice free. Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com> Change-Id: I3ad4c7ebf450505741964e64361882b8d8044d6b --- M src/Protocols/NFS/nfs4_op_setclientid.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/473844/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473844 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3ad4c7ebf450505741964e64361882b8d8044d6b Gerrit-Change-Number: 473844 Gerrit-PatchSet: 1 Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: The return value type of snprintf function is int.
by xijinyu (GerritHub) 11 Nov '19

11 Nov '19

xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473839 ) Change subject: The return value type of snprintf function is int. ...................................................................... The return value type of snprintf function is int. If it set to unsigned, the "if (owner len < 0)" statement will never be executed. Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com> Change-Id: Iedc4a149227851bb4280c17d830bc75bae60d501 --- M src/FSAL/FSAL_PROXY/handle.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/473839/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473839 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iedc4a149227851bb4280c17d830bc75bae60d501 Gerrit-Change-Number: 473839 Gerrit-PatchSet: 1 Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Unsigned integer is positive.
by xijinyu (GerritHub) 09 Nov '19

09 Nov '19

xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473776 ) Change subject: Unsigned integer is positive. ...................................................................... Unsigned integer is positive. Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com> Change-Id: Ic20a387a1d585eec524cd75d0e9ab69a2e889d61 --- M src/SAL/state_deleg.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/473776/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473776 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic20a387a1d585eec524cd75d0e9ab69a2e889d61 Gerrit-Change-Number: 473776 Gerrit-PatchSet: 1 Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com> Gerrit-MessageType: newchange

1 0

Soft release of V3.0
by Frank Filz 08 Nov '19

08 Nov '19

Since I've messed a few things up in the past releasing the GA merge, and it's the end of a mildly crazy week, I thought I'd do a soft release first using my github, so: https://github.com/ffilz/nfs-ganesha/commits/next Please take a look and see if I've missed anything. Since it isn't official, I can re-do the signed tag if you'd like to see other things mentioned in the release, and if anything is broken from a packaging standpoint, we can fix it. On Monday, after an opportunity to fix anything, I'll push the final V3.0 to nfs-ganesha github and gerrithub. Thanks for all the good work. We've got some major contributions in this release and a lot of good bug fixing and code cleanup. Frank

1 0

Change in ...nfs-ganesha[next]: Bump FSAL_API version to 10
by Frank Filz (GerritHub) 08 Nov '19

08 Nov '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473755 ) Change subject: Bump FSAL_API version to 10 ...................................................................... Bump FSAL_API version to 10 This should actually change now that most of Ganesha is in libganeshanfsd.so. What we care about is if an FSAL works with the API expected between libganesha_nfsd.so and the fsal.so, which includes the API defined in fsal_api.h but also the API of the functions exported from libganesha_nfsd.so. Now that we have src/MainNFSD/libganesha_nfsd.ver specifying the functions that libganesha_nfsd.so exports, it will be easier to monitor for API changes, if that file changes or any functions specified in it change API, then the API between the FSAL and Ganesha has changed. Change-Id: If8b24c4b7a215b27ebc80b5c53e47c4cd06a24bf Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/fsal_api.h 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/473755/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473755 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If8b24c4b7a215b27ebc80b5c53e47c4cd06a24bf Gerrit-Change-Number: 473755 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: use errno
by Xie Changlong (GerritHub) 08 Nov '19

08 Nov '19

Xie Changlong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473649 ) Change subject: use errno ...................................................................... use errno Signed-off-by: Xie Changlong <xiechanglong(a)cmss.chinamobile.com> Signed-off-by: Xie Changlong <xiechanglong_d(a)126.com> Change-Id: I3bacd885c9964c7b5f074355813ec6f124858370 --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/473649/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473649 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3bacd885c9964c7b5f074355813ec6f124858370 Gerrit-Change-Number: 473649 Gerrit-PatchSet: 1 Gerrit-Owner: Xie Changlong <xiechanglong_d(a)126.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: avoid use after free
by Xie Changlong (GerritHub) 08 Nov '19

08 Nov '19

Xie Changlong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473648 ) Change subject: avoid use after free ...................................................................... avoid use after free Signed-off-by: Xie Changlong <xiechanglong(a)cmss.chinamobile.com> Signed-off-by: Xie Changlong <xiechanglong_d(a)126.com> Change-Id: I27cdd13e83eb591aa54348c419e77d310d6fb4f7 --- M src/FSAL_UP/fsal_up_top.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/473648/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473648 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I27cdd13e83eb591aa54348c419e77d310d6fb4f7 Gerrit-Change-Number: 473648 Gerrit-PatchSet: 1 Gerrit-Owner: Xie Changlong <xiechanglong_d(a)126.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: avoid memory leak
by Xie Changlong (GerritHub) 08 Nov '19

08 Nov '19

Xie Changlong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473647 ) Change subject: avoid memory leak ...................................................................... avoid memory leak Signed-off-by: Xie Changlong <xiechanglong(a)cmss.chinamobile.com> Signed-off-by: Xie Changlong <xiechanglong_d(a)126.com> Change-Id: I803a4a84d1bc1667d7b00bf717c67e8efbd7d0a7 --- M src/RPCAL/gss_credcache.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/473647/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473647 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I803a4a84d1bc1667d7b00bf717c67e8efbd7d0a7 Gerrit-Change-Number: 473647 Gerrit-PatchSet: 1 Gerrit-Owner: Xie Changlong <xiechanglong_d(a)126.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: avoid free uninitialized tracker.entries
by Xie Changlong (GerritHub) 08 Nov '19

08 Nov '19

Xie Changlong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473646 ) Change subject: avoid free uninitialized tracker.entries ...................................................................... avoid free uninitialized tracker.entries Signed-off-by: Xie Changlong <xiechanglong(a)cmss.chinamobile.com> Signed-off-by: Xie Changlong <xiechanglong_d(a)126.com> Change-Id: Ic10e6eb12fb3e7a7aac50f427bbaccf2b3025c5b --- M src/Protocols/NFS/nfs3_readdirplus.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/46/473646/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473646 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic10e6eb12fb3e7a7aac50f427bbaccf2b3025c5b Gerrit-Change-Number: 473646 Gerrit-PatchSet: 1 Gerrit-Owner: Xie Changlong <xiechanglong_d(a)126.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: fix wrong size
by Xie Changlong (GerritHub) 08 Nov '19

08 Nov '19

Xie Changlong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473645 ) Change subject: fix wrong size ...................................................................... fix wrong size Signed-off-by: Xie Changlong <xiechanglong(a)cmss.chinamobile.com> Signed-off-by: Xie Changlong <xiechanglong_d(a)126.com> Change-Id: Id3e689b0d9b7224f85c47236360658e310b04cab --- M src/support/client_mgr.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/473645/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473645 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id3e689b0d9b7224f85c47236360658e310b04cab Gerrit-Change-Number: 473645 Gerrit-PatchSet: 1 Gerrit-Owner: Xie Changlong <xiechanglong_d(a)126.com> Gerrit-MessageType: newchange

1 0