November 2019 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Return when cannot create tcp socket.
by xijinyu (GerritHub) 08 Nov '19

08 Nov '19

xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473631 ) Change subject: Return when cannot create tcp socket. ...................................................................... Return when cannot create tcp socket. Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com> Change-Id: Idf57cdc2e3fef2ff5849c9345ea5f1d7745e802f --- M src/FSAL/FSAL_PROXY/handle.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/473631/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473631 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idf57cdc2e3fef2ff5849c9345ea5f1d7745e802f Gerrit-Change-Number: 473631 Gerrit-PatchSet: 1 Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Function find_fd miss error checking.
by xijinyu (GerritHub) 08 Nov '19

08 Nov '19

xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473628 ) Change subject: Function find_fd miss error checking. ...................................................................... Function find_fd miss error checking. status = fetch_attrs(myself, my_fd, attrs); parameter my_fd cannot be negative. Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com> Change-Id: I9c0188b9bffe17359d85970830d8dbbb24bc6d0d --- M src/FSAL/FSAL_VFS/file.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/473628/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473628 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9c0188b9bffe17359d85970830d8dbbb24bc6d0d Gerrit-Change-Number: 473628 Gerrit-PatchSet: 1 Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add check for sysconf failed.
by xijinyu (GerritHub) 08 Nov '19

08 Nov '19

xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473618 ) Change subject: Add check for sysconf failed. ...................................................................... Add check for sysconf failed. Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com> Change-Id: I82e1ed298b539048623dd7ab61b06ad7091efd61 --- M src/SAL/nfs4_recovery.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/473618/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473618 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I82e1ed298b539048623dd7ab61b06ad7091efd61 Gerrit-Change-Number: 473618 Gerrit-PatchSet: 1 Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Mention unit for latency stats
by Sachin Punadikar (GerritHub) 07 Nov '19

07 Nov '19

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473613 ) Change subject: Mention unit for latency stats ...................................................................... Mention unit for latency stats Few latency stats are in milliseconds. To get more clarity, display the unit in which the latencies are displayed. Change-Id: I99a2995f431f56f515e1caa5b0efa9053e369139 Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com> --- M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/473613/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473613 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I99a2995f431f56f515e1caa5b0efa9053e369139 Gerrit-Change-Number: 473613 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Convert RecoveryBackend from CONF_ITEM_STR to CONF_ITEM_TOKEN
by Frank Filz (GerritHub) 06 Nov '19

06 Nov '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473487 ) Change subject: Convert RecoveryBackend from CONF_ITEM_STR to CONF_ITEM_TOKEN ...................................................................... Convert RecoveryBackend from CONF_ITEM_STR to CONF_ITEM_TOKEN Then use an enum instead of doing strcmp. Also refine behavior when USE_RADOS_RECOV is not defined. Change-Id: I07823a4d568eff27c3f28ac236e9a7e10772731b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_init.c M src/SAL/nfs4_recovery.c M src/include/gsh_config.h M src/include/sal_functions.h M src/support/nfs_read_conf.c 5 files changed, 99 insertions(+), 51 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/473487/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473487 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I07823a4d568eff27c3f28ac236e9a7e10772731b Gerrit-Change-Number: 473487 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Pull up ntirpc to 3.0
by Daniel Gryniewicz (GerritHub) 06 Nov '19

06 Nov '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473480 ) Change subject: Pull up ntirpc to 3.0 ...................................................................... Pull up ntirpc to 3.0 Change-Id: I6c6b8ad7598d6052676898b4f92eb34605c7a902 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/SAL/CMakeLists.txt M src/config_parsing/CMakeLists.txt M src/include/config-h.in.cmake M src/libganeshaNFS.pc.cmake M src/libntirpc 7 files changed, 13 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/473480/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473480 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6c6b8ad7598d6052676898b4f92eb34605c7a902 Gerrit-Change-Number: 473480 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: rados_recov: abort (or not) correctly based on config and shlib
by Kaleb KEITHLEY (GerritHub) 06 Nov '19

06 Nov '19

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473479 ) Change subject: rados_recov: abort (or not) correctly based on config and shlib ...................................................................... rados_recov: abort (or not) correctly based on config and shlib With RADOS_RECOV=YES: If a rados recovery back end is configured, and the library is present, just work. If a back end is configured and the library is not present, abort. If a back end is not configured, don't load the library and don't abort. WRT load_backend(), the nfsd will successfully load the shlib and resolve the symbols, or abort. Later, when load_backend() is called, it's safe to assume the pointers are initialized and it's not necessary to check them before calling them. With RADOS_RECOV=NO: Any rados back end in the config is ignored or is an error and no attempt to dlopen() the shlib is ever attempted. Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: I409abc01eca083fb17d9f4d7444219d4fd49882f --- M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_rados_kv.c 2 files changed, 30 insertions(+), 33 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/473479/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473479 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I409abc01eca083fb17d9f4d7444219d4fd49882f Gerrit-Change-Number: 473479 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Avoid calling stat() on NFS mount points
by Malahal (GerritHub) 06 Nov '19

06 Nov '19

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473471 ) Change subject: Avoid calling stat() on NFS mount points ...................................................................... Avoid calling stat() on NFS mount points NFS mount points are prone to get stuck in kernel, so avoid stat() on them as we don't support exporting "nfs" mount points. Change-Id: I4a0de8e0c7a236159371601bbba507c1f962aee7 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 14 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/473471/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473471 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4a0de8e0c7a236159371601bbba507c1f962aee7 Gerrit-Change-Number: 473471 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Avoid autofs in our list of posix file systems
by Malahal (GerritHub) 06 Nov '19

06 Nov '19

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473470 ) Change subject: Avoid autofs in our list of posix file systems ...................................................................... Avoid autofs in our list of posix file systems Avoid "autofs" file systems in addition to "nfs" file systems. Change-Id: I07f5f5f2b5325a8f315dcbd8c59f9a2b3aa932e2 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/473470/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473470 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I07f5f5f2b5325a8f315dcbd8c59f9a2b3aa932e2 Gerrit-Change-Number: 473470 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL option for compliance with NFS v3 end-of-file read behavior
by Nathaniel Roiger (GerritHub) 06 Nov '19

06 Nov '19

Nathaniel Roiger has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473427 ) Change subject: FSAL option for compliance with NFS v3 end-of-file read behavior ...................................................................... FSAL option for compliance with NFS v3 end-of-file read behavior Change-Id: I40c8054e373dd51e7f008174943649e7244c7c8e Signed-off-by: TweakySolution <nroiger(a)gmail.com> --- M src/Protocols/NFS/nfs3_read.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/473427/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/473427 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I40c8054e373dd51e7f008174943649e7244c7c8e Gerrit-Change-Number: 473427 Gerrit-PatchSet: 1 Gerrit-Owner: Nathaniel Roiger <nate_roiger(a)atavium.com> Gerrit-MessageType: newchange

1 0