March 2019 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: build: (lib)ganesha_nfsd as a DSO
by Name of user not set (GerritHub) 26 Mar '19

26 Mar '19

kaleb(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/449182 Change subject: build: (lib)ganesha_nfsd as a DSO ...................................................................... build: (lib)ganesha_nfsd as a DSO Build ganesha as a DSO, i.e. libganesha_nfsd.so. Final (or is it?, addressing comments from all prior reviews. The ganesha.nfsd daemon consists of just nfs_main:main() and is linked with the DSO. Then all the FSALs (except FSAL_PSEUDO and FSAL_MDCACHE*) are linked with libganesha_nfsd to resolve functions in ganesha.nfsd itself. This will be required if, e.g., Fedora, decides to require default linking with '-z defs'. They tried to do it for F29 but retreated when they found that too many applications broke. In the end this may all be just an exercise in "truth and beauty." There are other use cases envisioned where ganesha is embedded as a component as part of other software components. *FSAL_PSEUDO and FSAL_MDCACHE are special; they are included in the DSO so should not need to be (and can't be) linked with the DSO. Cmake OBJECT libraries are not actual libraries like .a static or .so shared libs; they just compile the sources to .o files which are collectively referenced with cmake's $<TARGET_OBJECTS:...>. As such it is necessary to use set_target_properties(... COMPILE_FLAGS "-fPIC") everywhere. A few other things that could be done in the future are 1) link libganesha_nfsd.so with a .sym file to explicitly control which symbols are exposed or visible to the outside world. 2) build with -flto (Link Time Optimization) Annecdotes claim a 5-10% speed improvement is typical, and some applications have seen as much as 45-50% boost. Of course we have to do the experiment to see what we can really achieve. 3) don't link ganesha.nfsd with -bdynamic as it's no longer needed Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: Icf911663394a38e774884a658b2ddbb0e3e75bfa --- M src/CMakeLists.txt M src/FSAL/FSAL_GLUSTER/CMakeLists.txt M src/FSAL/FSAL_GPFS/CMakeLists.txt M src/FSAL/FSAL_MEM/CMakeLists.txt M src/FSAL/FSAL_PROXY/CMakeLists.txt M src/FSAL/FSAL_PSEUDO/CMakeLists.txt M src/FSAL/FSAL_RGW/CMakeLists.txt M src/FSAL/FSAL_VFS/CMakeLists.txt M src/FSAL/FSAL_VFS/os/CMakeLists.txt M src/FSAL/FSAL_VFS/panfs/CMakeLists.txt M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/Protocols/9P/CMakeLists.txt M src/Protocols/CMakeLists.txt M src/Protocols/NFS/CMakeLists.txt M src/Protocols/NLM/CMakeLists.txt M src/Protocols/RQUOTA/CMakeLists.txt M src/Protocols/XDR/CMakeLists.txt M src/RPCAL/CMakeLists.txt M src/SAL/CMakeLists.txt M src/avl/CMakeLists.txt M src/cidr/CMakeLists.txt M src/config_parsing/CMakeLists.txt M src/dbus/CMakeLists.txt M src/hashtable/CMakeLists.txt M src/idmapper/CMakeLists.txt M src/log/CMakeLists.txt M src/nfs-ganesha.spec-in.cmake M src/os/CMakeLists.txt M src/support/CMakeLists.txt M src/support/murmur3.c M src/tools/CMakeLists.txt 35 files changed, 211 insertions(+), 161 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/449182/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/449182 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icf911663394a38e774884a658b2ddbb0e3e75bfa Gerrit-Change-Number: 449182 Gerrit-PatchSet: 1 Gerrit-Owner: kaleb(a)redhat.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_GLUSTER: fill acl attribute at lookup and readdir when request
by Kinglong Mee (GerritHub) 22 Mar '19

22 Mar '19

Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448852 Change subject: FSAL_GLUSTER: fill acl attribute at lookup and readdir when request ...................................................................... FSAL_GLUSTER: fill acl attribute at lookup and readdir when request Mdcache sets entry's mde_flags depends on the request_mask flag in mdc_fixup_md, if a mdcache entry is created by lookup/readdir, the MDCACHE_TRUST_ACL flag is set when ATTR_ACL requested, but gluster doesnot fill it, so that mdcache caches bad (empty) ACL. Change-Id: Iedbcec1e7e0b538c1cc56028fbb14f9ed6949b3a Signed-off-by: Kinglong Mee <kinglongmee(a)gmail.com> --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/448852/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448852 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iedbcec1e7e0b538c1cc56028fbb14f9ed6949b3a Gerrit-Change-Number: 448852 Gerrit-PatchSet: 1 Gerrit-Owner: Kinglong Mee <kinglongmee(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix the mounted_on_fileid attribute for referral directories
by Sriram Patil (GerritHub) 22 Mar '19

22 Mar '19

Sriram Patil has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448844 Change subject: Fix the mounted_on_fileid attribute for referral directories ...................................................................... Fix the mounted_on_fileid attribute for referral directories When returning attributes for the referral directories, mounted_on_fileid attribute was set incorrectly in getattr. It was always set to zero. Because of this all the referrals were treated as the same directory by the NFS client. So, whichever referral is mounted first, all other referrals will also point to the same export even though the fs locations were set correctly. Change-Id: I259ae04e8ea542682abd19fa37a1e70edef9856d Signed-off-by: Sriram Patil <sriramp(a)vmware.com> --- M src/Protocols/NFS/nfs4_op_getattr.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/nfs_proto_tools.h 3 files changed, 24 insertions(+), 42 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/448844/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448844 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I259ae04e8ea542682abd19fa37a1e70edef9856d Gerrit-Change-Number: 448844 Gerrit-PatchSet: 1 Gerrit-Owner: Sriram Patil <sriramp(a)vmware.com> Gerrit-MessageType: newchange

1 0

NFS referrals do not seem to work
by Sriram Patil 21 Mar '19

21 Mar '19

Hi, I am observing strange behavior with referrals. NFS client always is always taking the fs locations of the first referral and not honoring rest of the referrals. For example, I have 3 exports e1, e2 and e3. e2 is a referral pointing to e1 and e3 is a referral pointing to a remote server. $> getfattr -n user.fs_location /exports/e2 getfattr: Removing leading '/' from absolute path names # file: exports/e2 user.fs_location="localhost:/e1" $> getfattr -n user.fs_location /exports/e3 getfattr: Removing leading '/' from absolute path names # file: exports/e3 user.fs_location="10.193.9.87:/TestShare-1" Here’s what happens when the localhost:/ is mounted $> sudo mount -t nfs4 -o minorversion=1,sec=sys localhost:/ /mnt/m1 $> ls -l /mnt/m1 total 4 drwxr-xr-x 4 root root 4096 Mar 16 19:51 e1 dr-xr-xr-x 2 4294967294 4294967294 0 Dec 31 1969 e2 # referral dr-xr-xr-x 2 4294967294 4294967294 0 Dec 31 1969 e3 # referral $> ls -l /mnt/m1/e2 # follows referral and mounts localhost:/e1 total 8 drwxr-xr-x 2 root root 4096 Mar 16 19:59 tmp drwxr-xr-x 3 root root 4096 Mar 16 19:51 tree $> ls -li /mnt/m1 total 12 1 drwxr-xr-x 4 root root 4096 Mar 16 19:51 e1 5505026 drwxr-xr-x 4 root root 4096 Mar 16 19:51 e2 # after referral mount both e2 and e3 show the same inode number 5505026 drwxr-xr-x 4 root root 4096 Mar 16 19:51 e3 $> ls -l /mnt/m1/e3 # trying to mount e3 but shows the same contents as e2 total 8 drwxr-xr-x 2 root root 4096 Mar 16 19:59 tmp drwxr-xr-x 3 root root 4096 Mar 16 19:51 tree $> mount -t nfs4 localhost:/ on /mnt/m1 type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=127.0.0.1,local_lock=none,addr=127.0.0.1) localhost:/e1 on /mnt/m1/e3 type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=127.0.0.1,local_lock=none,addr=127.0.0.1) As observed from the mount command output above, "localhost:/e1" is mounted at /mnt/m1/e3. However, e3 was pointing to "10.193.9.87:/TestShare-1". Whichever referral is mounted first, all the other referral point to the same one no matter what. Confusing thing is ganesha log, NFS packets and client side rpcdebug log, all show correct values of fs locations. But the client does not trigger a sub-mount if we already have one referral mounted. Still trying to figure what has caused this. Thanks, Sriram

2 4

Change in ...nfs-ganesha[next]: Invalidate parent handle of a directory for invalidate UP call
by Madhu Thorat (GerritHub) 21 Mar '19

21 Mar '19

Madhu Thorat has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448631 Change subject: Invalidate parent handle of a directory for invalidate UP call ...................................................................... Invalidate parent handle of a directory for invalidate UP call Currently when mdc_up_invalidate() is called for a directory we are not invalidating the parent handle saved inside the 'entry' for the directory. And if mdcache_put() doesn't free that 'entry', there is a chance that we may later on use that 'entry' whose parent handle may not be valid. To avoid this in mdc_up_invalidate() we now free the parent handle for a directory. Change-Id: I3d480733e18406f3d6af219254d1d1bf9a52d7fd Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/448631/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448631 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3d480733e18406f3d6af219254d1d1bf9a52d7fd Gerrit-Change-Number: 448631 Gerrit-PatchSet: 1 Gerrit-Owner: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

memory leak while handling requests for a deleted transport
by Malahal Naineni 21 Mar '19

21 Mar '19

Please review this patch. Will apply to V2.5-stable once it is reviewed. https://github.com/malahal/nfs-ganesha/commit/8e6212c7042b2f047737ed3290993… Regards, Malahal.

1 1

Change in ...nfs-ganesha[next]: FSAL_GLUSTER: freeing sec label xattr pointer
by Arjun Sharma (GerritHub) 21 Mar '19

21 Mar '19

Arjun Sharma has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448595 Change subject: FSAL_GLUSTER: freeing sec label xattr pointer ...................................................................... FSAL_GLUSTER: freeing sec label xattr pointer Signed-off-by: Arjun Sharma <arjsharm(a)redhat.com> Change-Id: I541992716151a2f7cae3077aeda219963c55894c --- M src/FSAL/FSAL_GLUSTER/export.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/448595/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448595 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I541992716151a2f7cae3077aeda219963c55894c Gerrit-Change-Number: 448595 Gerrit-PatchSet: 1 Gerrit-Owner: Arjun Sharma <arjsharm(a)redhat.com> Gerrit-MessageType: newchange

1 0

Memory growth with DRC
by Pradeep Thomas 20 Mar '19

20 Mar '19

Hello, With NFS traffic simulators like Load-Dynamix (LDX), I see that the ganesha takes up few of gigs of memory very quickly. For example, with 100 client IPs and 2000 ports per IP, ganesha will create 200K DRCs (drc_t) with 1K DRC-entries in each (each entry keeps an NFS request of size around 1K). Is it a good idea to cleanup DRCs at some point? Thanks, Pradeep

3 3

Question about trunking support in ganesha
by fanzi2009＠hotmail.com 19 Mar '19

19 Mar '19

Hi, Experts, Some questions about trunking 1. Does ganesha support session trunking now? 2. Does ganesha support client id trunking now? 3. As RFC rfc5661 said, The association of multiple sessions to the same client ID. But how to create more than one sessions in between server and client? Thanks, Marvin

1 0

Change in ...nfs-ganesha[next]: build: (lib)ganesha_nfsd as a DSO
by Name of user not set (GerritHub) 18 Mar '19

18 Mar '19

kaleb(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448349 Change subject: build: (lib)ganesha_nfsd as a DSO ...................................................................... build: (lib)ganesha_nfsd as a DSO Build ganesha as a DSO, i.e. libganesha_nfsd.so. Take three, addressing comments from the first go-arounds. The ganesha.nfsd daemon consists of just nfs_main:main() and is linked with the DSO. Then all the FSALs (except FSAL_PSEUDO and FSAL_MDCACHE*) are linked with libganesha_nfsd to resolve functions in ganesha.nfsd itself. This will be required if, e.g., Fedora, decides to require default linking with '-z defs'. They tried to do it for F29 but retreated when they found that too many applications broke. In the end this may all be just an exercise in "truth and beauty." There are other use cases envisioned where ganesha is embedded as a component as part of other software components. *FSAL_PSEUDO and FSAL_MDCACHE are special; they are included in the DSO so should not need to be (and can't be) linked with the DSO. This is pretty close to what I think the final solution looks like. Cmake OBJECT libraries are not actual libraries like .a static or .so shared libs; they just compile the sources to .o files which are collectively referenced with cmake's $<TARGET_OBJECTS:...>. As such it is necessary to use set_target_properties(... COMPILE_FLAGS "-fPIC") everywhere. A few other things that could be done in the future are 1) link libganesha_nfsd.so with a .sym file to explicitly control which symbols are exposed or visible to the outside world. 2) build with -flto (Link Time Optimization) Annecdotes claim a 5-10% speed improvement is typical, and some applications have seen as much as 45-50% boost. Of course we have to do the experiment to see what we can really achieve. 3) don't link ganesha.nfsd with -bdynamic as it's no longer needed Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: I874a5ea9f31c5500c7dc7c5c0349b0ab1dabbfc0 --- M src/CMakeLists.txt M src/FSAL/FSAL_GLUSTER/CMakeLists.txt M src/FSAL/FSAL_MEM/CMakeLists.txt M src/FSAL/FSAL_PROXY/CMakeLists.txt M src/FSAL/FSAL_PSEUDO/CMakeLists.txt M src/FSAL/FSAL_RGW/CMakeLists.txt M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/Protocols/9P/CMakeLists.txt M src/Protocols/NFS/CMakeLists.txt M src/Protocols/NLM/CMakeLists.txt M src/Protocols/RQUOTA/CMakeLists.txt M src/Protocols/XDR/CMakeLists.txt M src/RPCAL/CMakeLists.txt M src/SAL/CMakeLists.txt M src/avl/CMakeLists.txt M src/cidr/CMakeLists.txt M src/config_parsing/CMakeLists.txt M src/dbus/CMakeLists.txt M src/hashtable/CMakeLists.txt M src/idmapper/CMakeLists.txt M src/log/CMakeLists.txt M src/nfs-ganesha.spec-in.cmake M src/os/CMakeLists.txt M src/support/CMakeLists.txt M src/support/murmur3.c 29 files changed, 177 insertions(+), 116 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/448349/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448349 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I874a5ea9f31c5500c7dc7c5c0349b0ab1dabbfc0 Gerrit-Change-Number: 448349 Gerrit-PatchSet: 1 Gerrit-Owner: kaleb(a)redhat.com Gerrit-MessageType: newchange

1 0