March 2019 - Devel - Nfs Ganesha List Archives

Change in ...nfs-ganesha[next]: MDCACHE - Fix mis-set of first ck in directory

by Daniel Gryniewicz (GerritHub)

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448057 Change subject: MDCACHE - Fix mis-set of first ck in directory ...................................................................... MDCACHE - Fix mis-set of first ck in directory After the unchaining, we set look_ck to 0 when we don't know the next chunk. This triggered the setting of first ck for the directory in the middle, skipping whole chunks of the directory. Make sure we skip this when look_ck is zero. Change-Id: Ie14ecac3d41f6fb6cf2ee95d86a2b41e369601fb Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/448057/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448057 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie14ecac3d41f6fb6cf2ee95d86a2b41e369601fb Gerrit-Change-Number: 448057 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: MDCACHE_DEBUG - Fix for updated lock structures

by Daniel Gryniewicz (GerritHub)

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448056 Change subject: MDCACHE_DEBUG - Fix for updated lock structures ...................................................................... MDCACHE_DEBUG - Fix for updated lock structures Change-Id: I19712c693d6fc90e92ba42466b396ae24ae1e6c4 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 2 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/448056/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448056 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I19712c693d6fc90e92ba42466b396ae24ae1e6c4 Gerrit-Change-Number: 448056 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: rados_kv: don't track the client's address in the recovery database

by Jeff Layton (GerritHub)

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448042 Change subject: rados_kv: don't track the client's address in the recovery database ...................................................................... rados_kv: don't track the client's address in the recovery database We currently store a combination of the long-form clientid, its length and the client's address. Storing the address here means that we can't deal with trunking in the future. We should just be storing the long form clientid and using that for comparison. Unfortunately, this change may break reboot recovery so we will probably want to only add this patch to the next major release. Change-Id: Ibc600b95c625910ec8c8a0e0ac80a81ea67cc570 Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/SAL/recovery/recovery_rados_kv.c 1 file changed, 3 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/448042/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448042 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibc600b95c625910ec8c8a0e0ac80a81ea67cc570 Gerrit-Change-Number: 448042 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: rados_cluster: use rados_ng_pop_clid_entry

by Jeff Layton (GerritHub)

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448041 Change subject: rados_cluster: use rados_ng_pop_clid_entry ...................................................................... rados_cluster: use rados_ng_pop_clid_entry rados_kv_pop_clid_entry can make modifications to the database for the previous epoch, which is not something we want happening. Switch it to use the rados_ng_pop_clid_entry which is simpler and does just what is needed. Change-Id: I487e1d95337ccee47277076f18859dc1d7691fde Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/SAL/recovery/recovery_rados.h M src/SAL/recovery/recovery_rados_cluster.c M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c 4 files changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/448041/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448041 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I487e1d95337ccee47277076f18859dc1d7691fde Gerrit-Change-Number: 448041 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: rados_recov: fix buffer handling of clid entries from rados omap

by Jeff Layton (GerritHub)

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448040 Change subject: rados_recov: fix buffer handling of clid entries from rados omap ...................................................................... rados_recov: fix buffer handling of clid entries from rados omap The RADOS recovery backends store the client recovery blobs as unterminated strings. When they are read in at boot time however, we expect them to be terminated. This means that we can end up reading past the end of the buffer. Fix this by passing the value length to the callback, and have the callback use that to properly terminate the string in memory. Change-Id: I0a07672cd5855f329540bed235d260a43f248605 Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/SAL/recovery/recovery_rados.h M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c 3 files changed, 16 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/448040/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448040 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0a07672cd5855f329540bed235d260a43f248605 Gerrit-Change-Number: 448040 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: MainNFSD: add the RADOS_INCLUDE_DIR if it was specified during the build

by Jeff Layton (GerritHub)

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448039 Change subject: MainNFSD: add the RADOS_INCLUDE_DIR if it was specified during the build ...................................................................... MainNFSD: add the RADOS_INCLUDE_DIR if it was specified during the build This is needed since some recent changes to the RADOS_URLs code. Change-Id: I8783f6f61735f6f48660435d2984e837d6c3a51b Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/MainNFSD/CMakeLists.txt 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/448039/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/448039 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8783f6f61735f6f48660435d2984e837d6c3a51b Gerrit-Change-Number: 448039 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: If NFSv4 filehandle is NULL, don't log its fields

by Madhu Thorat (GerritHub)

Madhu Thorat has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/447879 Change subject: If NFSv4 filehandle is NULL, don't log its fields ...................................................................... If NFSv4 filehandle is NULL, don't log its fields In nfs4_Is_Fh_Invalid() if NFSv4 filehandle is NULL then don't log its fields. Change-Id: I9030903281a88e6189bf2e79fdc234f9f988b716 Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/support/nfs_filehandle_mgmt.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/447879/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/447879 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9030903281a88e6189bf2e79fdc234f9f988b716 Gerrit-Change-Number: 447879 Gerrit-PatchSet: 1 Gerrit-Owner: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: FSAL_VFS: Freeing FSAL handle when unable to get fs locations

by Sriram Patil (GerritHub)

Sriram Patil has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/447525 Change subject: FSAL_VFS: Freeing FSAL handle when unable to get fs locations ...................................................................... FSAL_VFS: Freeing FSAL handle when unable to get fs locations Change-Id: I7355ce1af63cd35056f760130287689e30edd8bb Signed-off-by: Sriram Patil <sriramp(a)vmware.com> --- M src/FSAL/FSAL_VFS/handle.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/25/447525/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/447525 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7355ce1af63cd35056f760130287689e30edd8bb Gerrit-Change-Number: 447525 Gerrit-PatchSet: 1 Gerrit-Owner: Sriram Patil <sriramp(a)vmware.com> Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

Re: Better interop for NFS/SMB file share mode/reservation

by J. Bruce Fields

On Wed, Mar 06, 2019 at 09:09:21AM +0200, Amir Goldstein wrote: > On Tue, Mar 5, 2019 at 11:48 PM J. Bruce Fields <bfields(a)fieldses.org> wrote: > > > > On Thu, Feb 14, 2019 at 04:06:52PM -0500, J. Bruce Fields wrote: > > > After this: > > > > > > https://marc.info/?l=linux-nfs&m=154966239918297&w=2 > > > > > > delegations would no longer conflict with opens from the same tgid. So > > > if your threads all run in the same process and you're willing to manage > > > conflicts among your own clients, that should still allow you to do > > > multiple opens of the same file without giving up your lease/delegation. > > > > > > I'd be curious to know whether that works with Samba's design. > > > > Any idea whether that would work? > > > > (Easy? Impossible? Possible, but realistically the changes required to > > Samba would be painful enough that it'd be unlikely to get done?) > > > > [CC Ralph Boehme] > > I am not a samba team member, but seems to me that your proposal > fits samba design like a glove. With one smbd process per client connection, > with your proposal, opens (for read) from same smbd process will not break the > shared read lease from same client, so oplocks level II could be implemented > using kernel oplocks (new flavor). OK. So I wonder about Ganesha. I'm not sure, but I *think* it's like knfsd in that it has a bunch of worker threads that can each take rpc's from any client. I don't remember if they're actually threads or processes. > IOW, can someone from samba team please elaborate on this quote > from samba wiki [1]: "Linux kernel oplocks don't provide the needed features. > (They don't even work correctly for oplocks...) ==> SMB-only feature." > > [1] https://wiki.samba.org/index.php/Samba3/SMB2#new_concepts Yes, it'd be useful to get those details written down in one place. > I would like to use this opportunity to ask samba team members to raise > any (*) other pain points about missing or lacking Linux kernel interfaces. > I promise to use my time in LSF/MM 2019 to try and promote samba > needs among Linux filesystem developers. I feel like this particular problem is about details of oplock/lease/delegation semantics that will interest a small number of people, so should mainly be handled as a hallway-track thing. But, maybe it's good to bring it up in a session if only to make sure anyone interested is aware. > (*) OK, not RichACLs. I know my own limitations. Hah. --b.

5 years, 9 months

3
3
0 / 0

Change in ...nfs-ganesha[next]: Unref 'prev_chunk' after it is used by 'glist_last_entry'

by Name of user not set (GerritHub)

madhu.punjabi(a)in.ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/447495 Change subject: Unref 'prev_chunk' after it is used by 'glist_last_entry' ...................................................................... Unref 'prev_chunk' after it is used by 'glist_last_entry' Coverity Scan fix: To be extra safe, unref 'prev_chunk' after it is used by 'glist_last_entry', so that there is no chance of using 'prev_chunk' pointer after it is freed. Change-Id: Idb09d15719572f86be0c7dfef70029e314ca6775 Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/447495/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/447495 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idb09d15719572f86be0c7dfef70029e314ca6775 Gerrit-Change-Number: 447495 Gerrit-PatchSet: 1 Gerrit-Owner: madhu.punjabi(a)in.ibm.com Gerrit-MessageType: newchange

5 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel March 2019